Code review comment for autopkgtest-cloud:launchpadcontent

Revision history for this message
Paride Legovini (paride) wrote :

I don't think this is very useful alone, as the script will continue adding PPAs using ppa.launchpad.net, see:

https://git.launchpad.net/autopkgtest-cloud/tree/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/worker/worker?id=92bb0adb7a6d8c6237d7f7d5d1b792c2213f044c#n645

The ppa.launchpad.net URLs will continue to work indefinitely, see [1].

Switching to ppa.launchpadcontent.net is necessary if we want to switch to https, which is a nice improvement. We should change the code I linked above and then also update TEMPORARY_TEST_FAIL_STRINGS (this time using port 443), and drop ppa.launchpad.net:80.

[1] https://blog.launchpad.net/ppa/new-domain-names-for-ppas

review: Needs Fixing

« Back to merge proposal