Merge autopkgtest-cloud:lxd-no-trusty into autopkgtest-cloud:master

Proposed by Brian Murray
Status: Merged
Merged at revision: 9950ce51549cd1ccbdf782385330068c34625f26
Proposed branch: autopkgtest-cloud:lxd-no-trusty
Merge into: autopkgtest-cloud:master
Diff against target: 57 lines (+5/-5)
3 files modified
charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd-cluster-template.userdata.in.unused (+2/-2)
charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata (+2/-2)
lxc-slave-admin/setup-adt-lxc.commands (+1/-1)
Reviewer Review Type Date Requested Status
Olivier Gayot (community) Approve
Ubuntu Release Team Pending
Review via email: mp+427968@code.launchpad.net

Description of the change

There are no trusty images available so the jobs would fail if they try to use trusty.

https://us.lxd.images.canonical.com/

To post a comment you must log in.
Revision history for this message
Olivier Gayot (ogayot) wrote (last edit ):

LGTM!

One suggestion that you can apply if you feel like it:

Suggestion - replacing:

[...] | grep -v $(distro-info --devel)\|trusty

with

[...] | grep -v -F -e "$(distro-info --devel)" -e trusty

IMO this is easier to read but it might not be very objective :)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd-cluster-template.userdata.in.unused b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd-cluster-template.userdata.in.unused
2index 20cbac3..d60806d 100644
3--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd-cluster-template.userdata.in.unused
4+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd-cluster-template.userdata.in.unused
5@@ -51,7 +51,7 @@ write_files:
6 # development release
7 37 2 * * * MIRROR=http://ftpmaster.internal/ubuntu/ ~/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$(distro-info --devel)/armhf
8 # stable releases
9- 1 0 * * 0 for r in $({ distro-info --supported; distro-info --supported-esm; } | sort -u | grep -v $(distro-info --devel)); do MIRROR=http://ftpmaster.internal/ubuntu/ ~/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$r/armhf; done
10+ 1 0 * * 0 for r in $({ distro-info --supported; distro-info --supported-esm; } | sort -u | grep -v "$(distro-info --devel)\|trusty"); do MIRROR=http://ftpmaster.internal/ubuntu/ ~/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$r/armhf; done
11 {%- endif %}
12
13 - path: /var/tmp/setup/lxd-init
14@@ -121,7 +121,7 @@ write_files:
15 systemctl start snap.lxd.daemon.unix.socket snap.lxd.daemon.service
16 python3 -c "from jinja2 import Template; import netifaces as ni; ni.ifaddresses('eth0'); ip = ni.ifaddresses('eth0')[ni.AF_INET][0]['addr']; f = open('/var/tmp/setup/lxd-init'); print(Template(f.read()).render(myip=ip))" | lxd init --preseed
17 {%- if role == 'bootstrap' or role == 'leader' %}
18- for r in $({ distro-info --supported; distro-info --supported-esm; } | sort -u); do /home/ubuntu/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$r/armhf; done
19+ for r in $({ distro-info --supported; distro-info --supported-esm; } | sort -u | grep -v trusty); do /home/ubuntu/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$r/armhf; done
20 {%- endif %}
21 echo "Finished building - rebooting so changed kernel command line comes into effect..."
22 reboot
23diff --git a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata
24index 03f1fc6..38d33ce 100644
25--- a/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata
26+++ b/charms/focal/autopkgtest-cloud-worker/autopkgtest-cloud/tools/armhf-lxd.userdata
27@@ -48,7 +48,7 @@ write_files:
28 # development release
29 37 2 * * * MIRROR=http://ftpmaster.internal/ubuntu/ ~/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$(distro-info --devel)/armhf
30 # stable releases
31- 1 0 * * 0 for r in $({ distro-info --supported; distro-info --supported-esm; } | sort -u | grep -v $(distro-info --devel)); do MIRROR=http://ftpmaster.internal/ubuntu/ ~/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$r/armhf; done
32+ 1 0 * * 0 for r in $({ distro-info --supported; distro-info --supported-esm; } | sort -u | grep -v "$(distro-info --devel)\|trusty"); do MIRROR=http://ftpmaster.internal/ubuntu/ ~/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$r/armhf; done
33
34 - path: /var/tmp/setup/lxd-init
35 content: |
36@@ -100,7 +100,7 @@ write_files:
37 systemctl stop snap.lxd.daemon.unix.socket snap.lxd.daemon.service || true
38 systemctl start snap.lxd.daemon.unix.socket snap.lxd.daemon.service
39 lxd init --preseed < /var/tmp/setup/lxd-init
40- for r in $({ distro-info --supported; distro-info --supported-esm; } | sort -u); do /home/ubuntu/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$r/armhf; done
41+ for r in $({ distro-info --supported; distro-info --supported-esm; } | sort -u | grep -v trusty); do /home/ubuntu/autopkgtest/tools/autopkgtest-build-lxd images:ubuntu/$r/armhf; done
42 echo "Finished building - rebooting so changed kernel command line comes into effect..."
43 reboot
44
45diff --git a/lxc-slave-admin/setup-adt-lxc.commands b/lxc-slave-admin/setup-adt-lxc.commands
46index f0a6c42..337027b 100644
47--- a/lxc-slave-admin/setup-adt-lxc.commands
48+++ b/lxc-slave-admin/setup-adt-lxc.commands
49@@ -6,7 +6,7 @@ sudo apt-get update
50 sudo apt-get install -y distro-info
51
52 LXCPATH=/data/lxc
53-RELEASES=$({ distro-info --supported; distro-info --supported-esm; } | sort -u)
54+RELEASES=$({ distro-info --supported; distro-info --supported-esm; } | sort -u | grep -v trusty)
55 ARCH=$(dpkg --print-architecture)
56 if [ "$ARCH" = s390x ]; then
57 RELEASES=$(echo "$RELEASES" | grep -Ev 'precise|trusty')

Subscribers

People subscribed via source and target branches