Merge lp:~ubuntu-mate-dev/unity-gtk-module/properly-complete-lp1710999 into lp:unity-gtk-module

Proposed by Martin Wimpress 
Status: Merged
Approved by: Didier Roche
Approved revision: 347
Merged at revision: 347
Proposed branch: lp:~ubuntu-mate-dev/unity-gtk-module/properly-complete-lp1710999
Merge into: lp:unity-gtk-module
Diff against target: 12 lines (+1/-1)
1 file modified
src/main.c (+1/-1)
To merge this branch: bzr merge lp:~ubuntu-mate-dev/unity-gtk-module/properly-complete-lp1710999
Reviewer Review Type Date Requested Status
Didier Roche Approve
Review via email:

Commit message

Properly limit the workaround to DnD windows only to complete the intended implementation for LP: #1710999. Thanks to Konstantin Putin. (LP: #1658996)

Description of the change

This merge proposal properly limits the workaround, from LP:#1710999, to DnD only windows and completes the intended implementation.

To post a comment you must log in.
Revision history for this message
Didier Roche (didrocks) wrote :

LGTM. Thanks:)

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/main.c'
2--- src/main.c 2017-08-16 01:17:18 +0000
3+++ src/main.c 2017-08-17 10:28:59 +0000
4@@ -553,7 +553,7 @@
6 GdkScreen *screen = gtk_widget_get_screen(widget);
7 GdkVisual *visual = gdk_screen_get_rgba_visual(screen);
8- if (visual)
9+ if (visual && (gtk_window_get_type_hint (GTK_WINDOW (widget)) == GDK_WINDOW_TYPE_HINT_DND))
10 gtk_widget_set_visual(widget, visual);
12 if (pre_hijacked_window_realize != NULL)


People subscribed via source and target branches