Merge lp:~ubuntu-mate-dev/landscape-client/show-in-mate into lp:~landscape/landscape-client/trunk

Proposed by Martin Wimpress 
Status: Merged
Approved by: Chris Glass
Approved revision: 823
Merged at revision: 823
Proposed branch: lp:~ubuntu-mate-dev/landscape-client/show-in-mate
Merge into: lp:~landscape/landscape-client/trunk
Diff against target: 12 lines (+1/-1)
1 file modified
applications/landscape-client-settings.desktop.in (+1/-1)
To merge this branch: bzr merge lp:~ubuntu-mate-dev/landscape-client/show-in-mate
Reviewer Review Type Date Requested Status
Geoff Teale (community) Approve
Chris Glass (community) Approve
Ubuntu Sponsors Pending
Review via email: mp+265243@code.launchpad.net

Commit message

Let the landscape-client-ui show up in Ubuntu MATE

Description of the change

I'd like to include the landscape-client in Ubuntu MATE but the icon is not visible under MATE desktop. This merge proposal simply makes the landscape-client desktop entry visible under MATE.

To post a comment you must log in.
Revision history for this message
Chris Glass (tribaal) wrote :

(Adding a second slot for Landscape developers as per landscape policy)

This MP is in the right place, we'll look at it as soon as possible. Thanks a lot!

Revision history for this message
Chris Glass (tribaal) wrote :

Thanks for the MP, this looks good (at least, harmless), however:

I installed Ubuntu Mate 15.04 in a KVM, and applied this diff to /usr/share/app-install/desktop/landscape-client-ui-install:landscape-client-settings.desktop in order to assert that it works.

Being a complete MATE newbie - where should I look for the landscape-client entry? Most of my (arguably short) discovery testing by poking around in the menus didn't show anything new in the system settings panel. Is there something I need to regenerate for this to show?

How can I check this actually works?

Thanks for you help.

- Chris

review: Needs Information
Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

IIRC it should appear under the top panel menu System -> Preferences -> Other.

Revision history for this message
Chris Glass (tribaal) wrote :

> IIRC it should appear under the top panel menu System -> Preferences -> Other.

I looked there and in every other menu entry, to no avail.

Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

I installed "landscape-client-ui-install" then editted /usr/share/applications/landscape-client-settings.desktop and added MATE; to OnlyShowIn. After running "sudo update-desktop-database" the Lanscape Service menu entry appeared in System - Preferences - Other. Hope that helps :-)

Revision history for this message
Chris Glass (tribaal) wrote :

Verified this works in a new 15.04 MATE install with the provided instructions, no idea what went wrong the first time.

Thanks for you work!

review: Approve
Revision history for this message
Geoff Teale (tealeg) wrote :

+1 Also working here.

review: Approve
Revision history for this message
Chris Glass (tribaal) wrote :

This patch was merged in landscape-client trunk.

Thanks a lot for your contribution!

We will roll it out with the rest of the changes next time we release a landscape-client package (we usually SRU the update back ourselves).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'applications/landscape-client-settings.desktop.in'
2--- applications/landscape-client-settings.desktop.in 2014-01-15 19:25:15 +0000
3+++ applications/landscape-client-settings.desktop.in 2015-07-20 10:02:33 +0000
4@@ -7,7 +7,7 @@
5 Type=Application
6 StartupNotify=true
7 Categories=GNOME;GTK;Settings;X-GNOME-SystemSettings;X-GNOME-Settings-Panel;X-Unity-Settings-Panel;
8-OnlyShowIn=GNOME;Unity;
9+OnlyShowIn=GNOME;Unity;MATE;
10 X-Unity-Settings-Panel=landscape
11 X-GNOME-Settings-Panel=landscape
12 X-Ubuntu-Gettext-Domain=landscape-client

Subscribers

People subscribed via source and target branches

to all changes: