Merge lp:~ubuntu-mate-dev/compiz/fix-1067951 into lp:compiz/0.9.12

Proposed by Martin Wimpress 
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: 3994
Merged at revision: 3996
Proposed branch: lp:~ubuntu-mate-dev/compiz/fix-1067951
Merge into: lp:compiz/0.9.12
Diff against target: 9 lines (+2/-0)
1 file modified
debian/mate.ini (+2/-0)
To merge this branch: bzr merge lp:~ubuntu-mate-dev/compiz/fix-1067951
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
Ubuntu Sponsors Pending
Review via email: mp+283039@code.launchpad.net

Commit message

mate.ini: Enable 'Keep Minimzed Windows' by default for the MATE profile

Description of the change

This merge proposal fixes LP: #1067951.

  * https://bugs.launchpad.net/ubuntu-mate/+bug/1067951

Prior to applying this fix the bug can be reproduced as follows:

  * Use MATE TWeak to switch to Compiz as Window Manager
  * Open Firefox as it was the last time, history is on to remember previous opened tabs
  * Minimize the Firefox window
  * Use CRTL + ALT + t to open a terminal
  * Execute 'firefox http://www.ubuntu.com'
  * Firefox will restore but will be missing window decorations.

After applying this fix Firefox doesn't loose Window decorations.

To post a comment you must log in.
Revision history for this message
Sam Spilsbury (smspillaz) wrote :

I'm still not sure if this is the best idea. As I mentioned in the last merge review, all this does is mask the underlying problem.

I haven't tracked Ubuntu release cycles for a while now, but if this is an urgent fix for an RC release I think it'd be sensible to make a note and track down why windows are losing their decorations upon being unmapped post-release. That sounds like a pretty serious issue to me.

Note that keeping minimised window previews around is not really spec-compliant functionality. It works in 95% of cases, which is convenient, but there's a plausible case where an application could require that its window be unmapped in order to stop refreshing its content. Video players and games are examples that come to mind. I also recall having some issues with Chromium when I implied this feature for Unity. Mostly just something to be aware of.

Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

Without this change Chrom{e|ium} will adopt extra decorations on occasion, regardless of the window decorator settings in Chrom{e|ium} and Firefox will drop window decorations as described earlier. This can be reproduced on XFCE and LXDE, but nither ship with Compiz. I have not experienced any regressions as a result of enabling "Keep Minimised Windows".

I would very much like this change merged into the mate.ini Compiz profile.

Revision history for this message
Martin Wimpress  (flexiondotorg) wrote :

Just to confirm that I would still like this configuration change merging.

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Approve
Revision history for this message
Michael Kogan (michael-kogan) wrote :

Is there still work ongoing on a proper fix for this? I experience bug #1067951 on Manjaro Linux Xfce running Compiz 0.9.13.1.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/mate.ini'
2--- debian/mate.ini 2015-07-13 15:51:32 +0000
3+++ debian/mate.ini 2016-01-19 06:49:08 +0000
4@@ -175,3 +175,5 @@
5 s0_arrow_base_color = #e6e6e6d9
6 s0_arrow_shadow_color = #dcdcdcd9
7
8+[workarounds]
9+s0_keep_minimized_windows = true

Subscribers

People subscribed via source and target branches