lp:~ubuntu-kernel/ubuntu/+source/linux/+git/bionic

Author: Luke Nowakowski-Krijger
Author Date: 2023-06-07 21:55:12 UTC

UBUNTU: Ubuntu-hwe-5.4-5.4.0-152.169~18.04.1

Signed-off-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>

Author: Mauricio Faria de Oliveira
Author Date: 2023-03-30 21:56:29 UTC

loop: fix I/O error on fsync() in detached loop devices

BugLink: https://bugs.launchpad.net/bugs/1856871

There's an I/O error on fsync() in a detached loop device
if it has been previously attached.

The issue is write cache is enabled in the attach path in
loop_configure() but it isn't disabled in the detach path;
thus it remains enabled in the block device regardless of
whether it is attached or not.

Now fsync() can get an I/O request that will just be failed
later in loop_queue_rq() as device's state is not 'Lo_bound'.

So, disable write cache in the detach path.

Do so based on the queue flag, not the loop device flag for
read-only (used to enable) as the queue flag can be changed
via sysfs even on read-only loop devices (e.g., losetup -r.)

Test-case:

    # DEV=/dev/loop7

    # IMG=/tmp/image
    # truncate --size 1M $IMG

    # losetup $DEV $IMG
    # losetup -d $DEV

Before:

    # strace -e fsync parted -s $DEV print 2>&1 | grep fsync
    fsync(3) = -1 EIO (Input/output error)
    Warning: Error fsyncing/closing /dev/loop7: Input/output error
    [ 982.529929] blk_update_request: I/O error, dev loop7, sector 0 op 0x1:(WRITE) flags 0x800 phys_seg 0 prio class 0

After:

    # strace -e fsync parted -s $DEV print 2>&1 | grep fsync
    fsync(3) = 0

Co-developed-by: Eric Desrochers <eric.desrochers@canonical.com>
Signed-off-by: Eric Desrochers <eric.desrochers@canonical.com>
Signed-off-by: Mauricio Faria de Oliveira <mfo@canonical.com>
Tested-by: Gabriel Krisman Bertazi <krisman@collabora.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
(backported from commit 4ceddce55eb35d15b0f87f5dcf6f0058fd15d3a4)
[Jorge Merlino: move patch to loop_clr_fd function]
Signed-off-by: Jorge Merlino <jorge.merlino@canonical.com>
Acked-by: Tim Gardner <tim.gardner@canonical.com>
Acked-by: Cory Todd <cory.todd@canonical.com>
Signed-off-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>

Author: Thadeu Lima de Souza Cascardo
Author Date: 2023-05-23 12:17:00 UTC

UBUNTU: Ubuntu-4.15.0-212.223

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

Author: Stefan Bader
Author Date: 2022-11-30 15:35:25 UTC

UBUNTU: Ubuntu-hwe-5.4-5.4.0-136.153~18.04.1

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

Author: Luke Nowakowski-Krijger
Author Date: 2022-10-27 20:56:02 UTC

UBUNTU: Ubuntu-4.15.0-196.207

Signed-off-by: Luke Nowakowski-Krijger <luke.nowakowskikrijger@canonical.com>

Author: Thadeu Lima de Souza Cascardo
Author Date: 2021-07-15 09:36:31 UTC

UBUNTU: Ubuntu-hwe-5.3.0-76.72

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

Author: Stefan Bader
Author Date: 2021-04-16 08:22:31 UTC

UBUNTU: Ubuntu-hwe-5.3.0-74.70

Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

Author: Thadeu Lima de Souza Cascardo
Author Date: 2021-02-01 22:04:45 UTC

UBUNTU: Ubuntu-hwe-5.0-5.0.0-65.71

Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@canonical.com>

Author: Kleber Sacilotto de Souza
Author Date: 2019-11-26 11:41:15 UTC

UBUNTU: Ubuntu-hwe-edge-5.3.0-24.26~18.04.2

Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>

Author: Khaled El Mously
Author Date: 2019-10-01 03:02:24 UTC

UBUNTU: Ubuntu-4.15.0-66.75

Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>

Author: Kai-Heng Feng
Author Date: 2018-11-26 07:15:57 UTC

HID: multitouch: Add pointstick support for Cirque Touchpad

BugLink: https://bugs.launchpad.net/bugs/1805081

Cirque Touchpad/Pointstick combo is similar to Alps devices, it requires
MT_CLS_WIN_8_DUAL to expose its pointstick as a mouse.

Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
(cherry picked from commit 12d43aacf9a74d0eb66fd0ea54ebeb79ca28940f)
Signed-off-by: Kai-Heng Feng <kai.heng.feng@canonical.com>
Acked-by: Seth Forshee <seth.forshee@canonical.com>
Acked-by: Khalid Elmously <khalid.elmously@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>