Merge ubiquity:sb-password-visible into ubiquity:main

[Brian Murray]

When ubiquity was modified to make it possible to hide and unhide the encryption password and user password (c.f. https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1960306) the secure boot password was missed. While the keyboard layout bug (https://bugs.launchpad.net/ubuntu/+source/ubiquity/+bug/1875062) is now fixed it is inconsistent to have some passwords be visible and others not. We should either merge this change (provided it works) or remove the ability to unhide the other passwords.

b1ecf3a... by Brian Murray on 2022-08-31

Allow displaying of the sb password

Unmerged commits

b1ecf3a... by Brian Murray on 2022-08-31

Allow displaying of the sb password

diff --git a/gui/gtk/stepPrepare.ui b/gui/gtk/stepPrepare.ui
index 7a5d2e8..f3ed233 100644
--- a/gui/gtk/stepPrepare.ui
+++ b/gui/gtk/stepPrepare.ui
@@ -465,7 +465,9 @@
                                         <property name="invisible_char">●</property>
                                         <property name="activates_default">True</property>
                                         <property name="width_chars">35</property>
+                                        <property name="secondary-icon-name">view-reveal-symbolic</property>
                                         <signal name="changed" handler="info_loop" swapped="no"/>
+                                        <signal name="icon-press" handler="on_password_toggle_visibility" swapped="no"/>
                                       </object>
                                       <packing>
                                         <property name="left_attach">1</property>
diff --git a/ubiquity/plugins/ubi-prepare.py b/ubiquity/plugins/ubi-prepare.py
index 6f5d1fe..14a571b 100644
--- a/ubiquity/plugins/ubi-prepare.py
+++ b/ubiquity/plugins/ubi-prepare.py
@@ -305,6 +305,14 @@ class PageGtk(PreparePageBase):
         dialog.run()
         dialog.destroy()
 
+    def on_password_toggle_visibility(self, widget, icon_pos, event):
+        from gi.repository import Gtk
+        visibility = self.password.get_visibility()
+        self.password.set_visibility(not visibility)
+        self.verified_password.set_visibility(not visibility)
+        self.password.set_icon_from_icon_name(
+            Gtk.EntryIconPosition.SECONDARY, ('view-conceal-symbolic', 'view-reveal-symbolic')[visibility])
+
 
 class PageKde(PreparePageBase):
     plugin_breadcrumb = 'ubiquity/text/breadcrumb_prepare'