Merge ubiquity:gtk-show-passwords into ubiquity:master
Status: | Merged |
---|---|
Merged at revision: | 6b6cb1924317548ec4adfbcba881cbcd2a4b5763 |
Proposed branch: | ubiquity:gtk-show-passwords |
Merge into: | ubiquity:master |
Diff against target: |
85 lines (+26/-1) 5 files modified
debian/changelog (+6/-1) gui/gtk/stepPartCrypto.ui (+2/-0) gui/gtk/stepUserInfo.ui (+2/-0) ubiquity/plugins/ubi-partman.py (+8/-0) ubiquity/plugins/ubi-usersetup.py (+8/-0) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sebastien Bacher | Approve | ||
Review via email: mp+414410@code.launchpad.net |
Commit message
Add the ability to show passwords that are being typed-in on various stages (GTK only for now).
Description of the change
Add the ability to show passwords that are being typed-in on various stages (GTK only for now).
The rationale for this change is the following: currently users are suffering from bugs like LP: #1875062 which are really hard to pin-point and reproduce. A semi-workaround for that is this change, meaning that users can double-check if the password they think they write was actually written correctly (in case the keyboard layout is wrong).
This is by no means a real fix for that issue, but I think such an ability is good anyway.
I'll look into doing the same for KDE, although I see KDE has a very much less intuitive UI for disk encryption. This will be a separate MP.
We could backport that to focal as well and have it part of 20.04.4.