Ubuntu Docker Images

Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/utils:jq-always-specify-filter into ~ubuntu-docker-images/ubuntu-docker-images/+git/utils:master

  1. Git
  2. lp:~ubuntu-docker-images/ubuntu-docker-images/+git/utils
  3. jq-always-specify-filter
  4. Merge into master
Proposed by Paride Legovini
Status: Merged
Merged at revision: bb5f669c1ce5f565ed2a3a3d98fe0f27f3cd10bc
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/utils:jq-always-specify-filter
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/utils:master
Diff against target: 11 lines (+1/-1)
1 file modified
lib/image.sh (+1/-1)
Reviewer Review Type Date Requested Status
Utkarsh Gupta Approve
Sergio Durigan Junior Approve
Review via email: mp+403461@code.launchpad.net

Commit message

Always speficy a filter when calling `jq`.

See https://github.com/stedolan/jq/issues/1110 (still affecting Bionic).

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, LGTM! And thanks a lot for the whole investigation that led to discovering this bug :-).

review: Approve
Revision history for this message
Utkarsh Gupta (utkarsh) wrote :

Interesting issue & fix! Approving since it's obvious and Sergio already did, so... \o/

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/lib/image.sh b/lib/image.sh
2index 9e072a4..e2c362f 100644
3--- a/lib/image.sh
4+++ b/lib/image.sh
5@@ -97,5 +97,5 @@ print_manifest_for_image ()
6 error "Unable to obtain manifest file for image (return code $ret)"
7 fi
8
9- cat "${outfile}" | jq
10+ cat "${outfile}" | jq .
11 }

Subscribers

People subscribed via source and target branches

to all changes: