Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/templates:remove-focal-refs into ~ubuntu-docker-images/ubuntu-docker-images/+git/templates:master
Proposed by
Sergio Durigan Junior
Status: | Merged |
---|---|
Merged at revision: | 5525d5d3ae35fbe4c83dda8e99b5fc2077a8ccf0 |
Proposed branch: | ~ubuntu-docker-images/ubuntu-docker-images/+git/templates:remove-focal-refs |
Merge into: | ~ubuntu-docker-images/ubuntu-docker-images/+git/templates:master |
Diff against target: |
48 lines (+6/-4) 3 files modified
templates/HACKING_deb.md (+1/-1) templates/README_DOCKERHUB.md (+2/-1) templates/README_DOCKERHUB_LTS.md (+3/-2) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Lucas Kanashiro | Approve | ||
Bryce Harrington | Pending | ||
Valentin Viennot | Pending | ||
Review via email:
|
Description of the change
This commit aims to make the templates fully generic, by removing the (few) references to Focal that are still present in them.
I tested it by re-generating Apache2's README.md and HACKING.md and checking that everything works as expected.
Arguably, the "distroversion" manipulation that I've added to the README_DOCKERHUB.md template is a bit fragile in the sense that it requires the "base" parameter to always have the Ubuntu release number there, and not its name, but I don't foresee a situation where we will deviate from this, so I think it's fine.
To post a comment you must log in.
You will see that there is an extra hunk at the end of the diff. My Emacs is configured to always insert a newline at the end of the file, that's why it's there.