Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/telegraf:1.15-20.04-fix-missing-manifest into ~ubuntu-docker-images/ubuntu-docker-images/+git/telegraf:1.15-20.04
Proposed by
Athos Ribeiro
Status: | Merged |
---|---|
Merge reported by: | Athos Ribeiro |
Merged at revision: | 494f64219fa87afb968c9793666bb9b8d15b82f1 |
Proposed branch: | ~ubuntu-docker-images/ubuntu-docker-images/+git/telegraf:1.15-20.04-fix-missing-manifest |
Merge into: | ~ubuntu-docker-images/ubuntu-docker-images/+git/telegraf:1.15-20.04 |
Diff against target: |
25 lines (+7/-3) 1 file modified
Dockerfile (+7/-3) |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Sergio Durigan Junior | Approve | ||
Ubuntu Docker Images | Pending | ||
Review via email:
|
Description of the change
Do not use pipes in RUN commands
Using pipes without properly handling the earlier commands may conceal errors even when "set -e" is used.
Since setting the pipefail option may not be an alternative (we are using dash), we should refactor commands using pipes to avoid concealing errors.
This should avoid releasing images with missing bits.
To post a comment you must log in.
LGTM, thanks.