Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/squid:4.13-21.04-wip into ~ubuntu-docker-images/ubuntu-docker-images/+git/squid:main

Proposed by Athos Ribeiro
Status: Merged
Merge reported by: Athos Ribeiro
Merged at revision: 5f81e3c3dd29f1266b0c0de9e80b8812e5a5de2d
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/squid:4.13-21.04-wip
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/squid:main
Diff against target: 67 lines (+6/-6)
4 files modified
Dockerfile (+1/-1)
HACKING.md (+1/-1)
README.md (+3/-3)
data/squid.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Bryce Harrington Pending
Canonical Server Pending
Review via email: mp+408294@code.launchpad.net

Description of the change

This is the proposed branch for the new squid hirsute OCI.

Note that this MP was filed against the main branch for review purposes only. After approval, a new 4.13-21.04 branch will be created.

I ran the squid OCI test suite for this new branch locally. Here are the results:

athos@pollux:~/src/server-test-scripts/oci-unit-tests$ DOCKER_IMAGE=localhost/squid:hirsute sh squid_test.sh
Error response from daemon: Get http://localhost/v2/: dial tcp 127.0.0.1:80: connect: connection refused
test_start_and_connect
test_start_and_connect_ipv6
test_custom_configuration
test_persistent_logs
test_persistent_cache
test_manifest_exists

Ran 6 tests.

OK

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Athos.

Built & tested locally, everything OK.

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index f7a01f4..610df62 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -1,4 +1,4 @@
6-FROM ubuntu:impish
7+FROM ubuntu:hirsute
8
9 ENV TZ=UTC
10 LABEL maintainer="Ubuntu Server team <ubuntu-server@lists.ubuntu.com>"
11diff --git a/HACKING.md b/HACKING.md
12index 39941c0..e29be91 100644
13--- a/HACKING.md
14+++ b/HACKING.md
15@@ -1,7 +1,7 @@
16 # Contributing
17
18 In Ubuntu, Squid is available as a `.deb` package. For this reason,
19-this image was built by installing the Squid Ubuntu 21.10 package
20+this image was built by installing the Squid Ubuntu 21.04 package
21 inside a docker container.
22
23 In order to contribute to the Squid OCI image, do the following:
24diff --git a/README.md b/README.md
25index 7eccbf1..0d7a024 100644
26--- a/README.md
27+++ b/README.md
28@@ -19,7 +19,7 @@ _Tags in italics are not available in ubuntu/squid but are shown here for comple
29
30 | Channel Tag | | | Currently | Architectures |
31 |---|---|---|---|---|
32-| **`4.13-21.10_beta`** &nbsp;&nbsp; | | | Squid 4.13 on Ubuntu 21.10 | `amd64`, `arm64`, `ppc64el`, `s390x` |
33+| **`4.13-21.04_beta`** &nbsp;&nbsp; | | | Squid 4.13 on Ubuntu 21.04 | `amd64`, `arm64`, `ppc64el`, `s390x` |
34 | _`track_risk`_ |
35
36 Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.
37@@ -30,7 +30,7 @@ Channel tag shows the most stable channel for that track ordered `stable`, `cand
38 Launch this image locally:
39
40 ```sh
41-docker run -d --name squid-container -e TZ=UTC -p 3128:3128 ubuntu/squid:4.13-21.10_beta
42+docker run -d --name squid-container -e TZ=UTC -p 3128:3128 ubuntu/squid:4.13-21.04_beta
43 ```
44 Access your Squid proxy at `localhost:3128`.
45
46@@ -65,7 +65,7 @@ Works with any Kubernetes; if you don't have one, we recommend you [install Micr
47
48 Download
49 [squid.conf](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/squid/plain/examples/config/squid.conf) and
50-[squid-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/squid/plain/examples/squid-deployment.yml) and set `containers.squid.image` in `squid-deployment.yml` to your chosen channel tag (e.g. `ubuntu/squid:4.13-21.10_beta`), then:
51+[squid-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/squid/plain/examples/squid-deployment.yml) and set `containers.squid.image` in `squid-deployment.yml` to your chosen channel tag (e.g. `ubuntu/squid:4.13-21.04_beta`), then:
52
53 ```sh
54 kubectl create configmap squid-config --from-file=squid=squid.conf
55diff --git a/data/squid.yaml b/data/squid.yaml
56index 6f90f3c..759ea9f 100644
57--- a/data/squid.yaml
58+++ b/data/squid.yaml
59@@ -8,7 +8,7 @@ description: >
60 a great server accelerator. It runs on most available operating systems,
61 including Windows and is licensed under the GNU GPL.
62 version: "4.13"
63-base: Ubuntu 21.10
64+base: Ubuntu 21.04
65 architectures:
66 - amd64
67 - arm64

Subscribers

People subscribed via source and target branches

to all changes: