Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/redis:6.0-21.10-wip into ~ubuntu-docker-images/ubuntu-docker-images/+git/redis:6.0-21.04

Proposed by Athos Ribeiro
Status: Merged
Merge reported by: Sergio Durigan Junior
Merged at revision: 45185956de2eb4bb9b5f0ac35f2e07b2c9295357
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/redis:6.0-21.10-wip
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/redis:6.0-21.04
Diff against target: 76 lines (+7/-7)
4 files modified
Dockerfile (+1/-1)
HACKING.md (+1/-1)
README.md (+4/-4)
data/redis.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Bryce Harrington Pending
Canonical Server Pending
Review via email: mp+403468@code.launchpad.net

Description of the change

This change creates the redis OCI image for impish.

Just the trivial changes were needed and no regressions were detected when running the unit test.

Note that this MP is targeting the 6.0-21.04 branch solely for comparing purposes. When accepted, these changes should be pushed into a new 6.0-21.10 branch.

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Heh, there's a "thinko" in the MP description: this is the redis OCI image, not apache2's :-P.

Other than that, this LGTM. I've built and tested it locally and everything passes indeed. Thanks!

review: Approve
Revision history for this message
Sergio Durigan Junior (sergiodj) :
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Pushed to 6.0-21.10 and removed the 6.0-21.10-wip branch

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index f7a24d6..01eed53 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -1,4 +1,4 @@
6-FROM ubuntu:hirsute
7+FROM ubuntu:impish
8
9 ENV TZ UTC
10
11diff --git a/HACKING.md b/HACKING.md
12index 9c274c0..74898e4 100644
13--- a/HACKING.md
14+++ b/HACKING.md
15@@ -1,7 +1,7 @@
16 # Contributing
17
18 In Ubuntu, Redis is available as a `.deb` package. For this reason,
19-this image was built by installing the Redis Ubuntu 21.04 package
20+this image was built by installing the Redis Ubuntu 21.10 package
21 inside a docker container.
22
23 In order to contribute to the Redis OCI image, do the following:
24diff --git a/README.md b/README.md
25index d3a02ff..9adf316 100644
26--- a/README.md
27+++ b/README.md
28@@ -19,7 +19,7 @@ _Tags in italics are not available in ubuntu/redis but are shown here for comple
29
30 | Channel Tag | | | Currently | Architectures |
31 |---|---|---|---|---|
32-| **`6.0-21.04_beta`**    | | | Redis 6.0.9 on Ubuntu 21.04 | `amd64`, `arm64`, `ppc64el`, `s390x` |
33+| **`6.0-21.10_beta`**    | | | Redis 6.0.9 on Ubuntu 21.10 | `amd64`, `arm64`, `ppc64el`, `s390x` |
34 | _`track_risk`_ |
35
36 Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.
37@@ -30,7 +30,7 @@ Channel tag shows the most stable channel for that track ordered `stable`, `cand
38 Launch this image locally:
39
40 ```sh
41-docker run -d --name redis-container -e TZ=UTC -p 30073:6379 -e REDIS_PASSWORD=mypassword ubuntu/redis:6.0-21.04_beta
42+docker run -d --name redis-container -e TZ=UTC -p 30073:6379 -e REDIS_PASSWORD=mypassword ubuntu/redis:6.0-21.10_beta
43 ```
44 Access your Redis server at `localhost:30073`.
45
46@@ -67,7 +67,7 @@ This image also includes the `redis-cli` client for interactive container use:
47 ```sh
48 $ docker network create redis-network
49 $ docker network connect redis-network redis-container
50-$ docker run -it --rm --network redis-network ubuntu/redis:6.0-21.04_beta redis-cli -h redis-container
51+$ docker run -it --rm --network redis-network ubuntu/redis:6.0-21.10_beta redis-cli -h redis-container
52 ```
53 Now you can:
54 ```
55@@ -85,7 +85,7 @@ Works with any Kubernetes; if you don't have one, we recommend you [install Micr
56
57 Download
58 [redis.conf](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/redis/plain/examples/config/redis.conf) and
59-[redis-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/redis/plain/examples/redis-deployment.yml) and set `containers.redis.image` in `redis-deployment.yml` to your chosen channel tag (e.g. `ubuntu/redis:6.0-21.04_beta`), then:
60+[redis-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/redis/plain/examples/redis-deployment.yml) and set `containers.redis.image` in `redis-deployment.yml` to your chosen channel tag (e.g. `ubuntu/redis:6.0-21.10_beta`), then:
61
62 ```sh
63 kubectl create configmap redis-config --from-file=redis=redis.conf
64diff --git a/data/redis.yaml b/data/redis.yaml
65index 5cb6db2..75131cb 100644
66--- a/data/redis.yaml
67+++ b/data/redis.yaml
68@@ -7,7 +7,7 @@ description: >
69 Redis has built-in replication, Lua scripting, LRU eviction, transactions and different levels of on-disk persistence, and provides high availability via Redis Sentinel and automatic partitioning with Redis Cluster.
70 Read more on the [Redis website](https://redis.io/topics/introduction).
71 version: 6.0.9
72-base: Ubuntu 21.04
73+base: Ubuntu 21.10
74 architectures:
75 - amd64
76 - arm64

Subscribers

People subscribed via source and target branches

to all changes: