Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/redis:6.0-21.04 into ~ubuntu-docker-images/ubuntu-docker-images/+git/redis:edge

Proposed by Bryce Harrington
Status: Merged
Merge reported by: Bryce Harrington
Merged at revision: 3b16fa2fe658b091883b1d980e61742df98bb951
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/redis:6.0-21.04
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/redis:edge
Diff against target: 118 lines (+26/-18)
4 files modified
Dockerfile (+19/-11)
HACKING.md (+1/-1)
README.md (+4/-4)
data/redis.yaml (+2/-2)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Review via email: mp+398852@code.launchpad.net

Description of the change

Enforce consistency across Dockerfile's

Please review with an eye towards cross-package standardization of packaging.
Particular strategic questions that this MP poses includes:

  * Should images adhere to base dist images, or fully update to current?
  * Perform smoke checks, consistently
  * Perform a full-upgrade on container before installing on it
  * Use --no-install-recommends
  * Use set -eux consistently

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

LGTM, +1. (although the MP will not be merged into edge, of course).

review: Approve
ac0469f... by Sergio Durigan Junior

Add missing backslashes

Signed-off-by: Sergio Durigan Junior <email address hidden>

3b16fa2... by Sergio Durigan Junior

Update README.md and HACKING.md

Signed-off-by: Sergio Durigan Junior <email address hidden>

Revision history for this message
Bryce Harrington (bryce) wrote :

This is merged to the 21.04 branch, and complete

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index 3f2758d..f7a24d6 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -1,21 +1,27 @@
6-FROM ubuntu:focal
7+FROM ubuntu:hirsute
8
9 ENV TZ UTC
10
11 RUN set -eux; \
12- apt-get update \
13- && DEBIAN_FRONTEND=noninteractive apt-get upgrade -y \
14+# installation
15+ apt-get update; \
16+ DEBIAN_FRONTEND=noninteractive apt-get full-upgrade -y; \
17 # Needed for generating random passwords.
18- && DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y pwgen redis-server tzdata \
19- && rm -rf /var/lib/apt/lists/* \
20- && redis-server --version \
21+ DEBIAN_FRONTEND=noninteractive apt-get install -y --no-install-recommends \
22+ pwgen \
23+ redis-server \
24+ tzdata \
25+ ; \
26+ DEBIAN_FRONTEND=noninteractive apt-get remove --purge --auto-remove -y; \
27+ rm -rf /var/lib/apt/lists/*; \
28+# smoke test
29+ redis-server --version; \
30 # create manifest
31- && mkdir -p /usr/share/rocks \
32- && (echo "# os-release" && cat /etc/os-release && echo "# dpkg-query" && dpkg-query -f '${db:Status-Abbrev},${binary:Package},${Version},${source:Package},${Source:Version}\n' -W) > /usr/share/rocks/dpkg.query
33+ mkdir -p /usr/share/rocks; \
34+ (echo "# os-release" && cat /etc/os-release && echo "# dpkg-query" && dpkg-query -f '${db:Status-Abbrev},${binary:Package},${Version},${source:Package},${Source:Version}\n' -W) > /usr/share/rocks/dpkg.query;
35
36-EXPOSE 6379
37-
38-RUN mkdir /data && chown redis:redis /data
39+RUN mkdir /data; \
40+ chown redis:redis /data
41 VOLUME /data
42 WORKDIR /data
43
44@@ -23,4 +29,6 @@ COPY start-redis.sh /usr/local/bin/
45 RUN ln -s /usr/local/bin/start-redis.sh /entrypoint.sh # backwards compat
46
47 ENTRYPOINT [ "start-redis.sh" ]
48+
49+EXPOSE 6379
50 CMD [ "redis-server" ]
51diff --git a/HACKING.md b/HACKING.md
52index d09b9a4..9c274c0 100644
53--- a/HACKING.md
54+++ b/HACKING.md
55@@ -1,7 +1,7 @@
56 # Contributing
57
58 In Ubuntu, Redis is available as a `.deb` package. For this reason,
59-this image was built by installing the Redis Ubuntu Focal package
60+this image was built by installing the Redis Ubuntu 21.04 package
61 inside a docker container.
62
63 In order to contribute to the Redis OCI image, do the following:
64diff --git a/README.md b/README.md
65index d45b62a..d3a02ff 100644
66--- a/README.md
67+++ b/README.md
68@@ -19,7 +19,7 @@ _Tags in italics are not available in ubuntu/redis but are shown here for comple
69
70 | Channel Tag | | | Currently | Architectures |
71 |---|---|---|---|---|
72-| **`5.0-20.04_beta`** &nbsp;&nbsp; | | | Redis 5.0.7 on Ubuntu 20.04 LTS | `amd64`, `arm64`, `ppc64el`, `s390x` |
73+| **`6.0-21.04_beta`** &nbsp;&nbsp; | | | Redis 6.0.9 on Ubuntu 21.04 | `amd64`, `arm64`, `ppc64el`, `s390x` |
74 | _`track_risk`_ |
75
76 Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.
77@@ -30,7 +30,7 @@ Channel tag shows the most stable channel for that track ordered `stable`, `cand
78 Launch this image locally:
79
80 ```sh
81-docker run -d --name redis-container -e TZ=UTC -p 30073:6379 -e REDIS_PASSWORD=mypassword ubuntu/redis:5.0-20.04_beta
82+docker run -d --name redis-container -e TZ=UTC -p 30073:6379 -e REDIS_PASSWORD=mypassword ubuntu/redis:6.0-21.04_beta
83 ```
84 Access your Redis server at `localhost:30073`.
85
86@@ -67,7 +67,7 @@ This image also includes the `redis-cli` client for interactive container use:
87 ```sh
88 $ docker network create redis-network
89 $ docker network connect redis-network redis-container
90-$ docker run -it --rm --network redis-network ubuntu/redis:5.0-20.04_beta redis-cli -h redis-container
91+$ docker run -it --rm --network redis-network ubuntu/redis:6.0-21.04_beta redis-cli -h redis-container
92 ```
93 Now you can:
94 ```
95@@ -85,7 +85,7 @@ Works with any Kubernetes; if you don't have one, we recommend you [install Micr
96
97 Download
98 [redis.conf](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/redis/plain/examples/config/redis.conf) and
99-[redis-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/redis/plain/examples/redis-deployment.yml) and set `containers.redis.image` in `redis-deployment.yml` to your chosen channel tag (e.g. `ubuntu/redis:5.0-20.04_beta`), then:
100+[redis-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/redis/plain/examples/redis-deployment.yml) and set `containers.redis.image` in `redis-deployment.yml` to your chosen channel tag (e.g. `ubuntu/redis:6.0-21.04_beta`), then:
101
102 ```sh
103 kubectl create configmap redis-config --from-file=redis=redis.conf
104diff --git a/data/redis.yaml b/data/redis.yaml
105index 74fba08..5cb6db2 100644
106--- a/data/redis.yaml
107+++ b/data/redis.yaml
108@@ -6,8 +6,8 @@ description: >
109 It supports data structures such as strings, hashes, lists, sets, sorted sets with range queries, bitmaps, hyperloglogs, geospatial indexes with radius queries and streams.
110 Redis has built-in replication, Lua scripting, LRU eviction, transactions and different levels of on-disk persistence, and provides high availability via Redis Sentinel and automatic partitioning with Redis Cluster.
111 Read more on the [Redis website](https://redis.io/topics/introduction).
112-version: 5.0.7
113-base: Ubuntu 20.04 LTS
114+version: 6.0.9
115+base: Ubuntu 21.04
116 architectures:
117 - amd64
118 - arm64

Subscribers

People subscribed via source and target branches

to all changes: