Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus:update-21.04 into ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus:update-20.04-snap

Proposed by Sergio Durigan Junior
Status: Merged
Merge reported by: Sergio Durigan Junior
Merged at revision: 5c5220a229468e921854a9148bf5eb8d3ec8b02f
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus:update-21.04
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus:update-20.04-snap
Diff against target: 110 lines (+16/-16)
3 files modified
Dockerfile (+3/-3)
README.md (+6/-6)
data/prometheus.yaml (+7/-7)
Reviewer Review Type Date Requested Status
Bryce Harrington Approve
Canonical Server Pending
Review via email: mp+400425@code.launchpad.net

Description of the change

This is the 21.04 branch for prometheus. It's worth mentioning a few things:

- This MP is based on https://code.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/+merge/400420.

- This MP's target branch is update-20.04-snap, but that's just to simplify the review. Obviously the intention is to create a new M.N-21.04 branch when this MP is approved.

- Although the prometheus version listed here is 2.25.2, the prometheus snap on the 21.04 track hasn't been updated yet (it will be soon, though).

Having said all that, once the 20.04 MP has been approved, this one will should be breeze to review.

To post a comment you must log in.
Revision history for this message
Bryce Harrington (bryce) wrote :

Straightforward, essentially just updating the release number.

Build worked fine:

Step 14/15 : ENTRYPOINT [ "/usr/bin/prometheus" ]
 ---> Running in ce42ca5d50f6
Removing intermediate container ce42ca5d50f6
 ---> 14fa37a23267
Step 15/15 : CMD [ "--config.file=/etc/prometheus/prometheus.yml", "--storage.tsdb.path=/prometheus" ]
 ---> Running in 10e0503c49b4
Removing intermediate container 10e0503c49b4
 ---> 29f3294a9577
Successfully built 29f3294a9577

LGTM, +1

Revision history for this message
Bryce Harrington (bryce) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index 51f175d..c810437 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -1,4 +1,4 @@
6-FROM ubuntu:focal AS snap-installer
7+FROM ubuntu:hirsute AS snap-installer
8
9 RUN set -eux; \
10 apt-get update; \
11@@ -7,11 +7,11 @@ RUN set -eux; \
12 jq curl ca-certificates squashfs-tools; \
13 # taken from https://snapcraft.io/docs/build-on-docker
14 # Alternatively, we can install snapd, and issue `snap download prometheus`
15- curl -L $(curl -H 'X-Ubuntu-Series: 16' 'https://api.snapcraft.io/api/v1/snaps/details/prometheus?channel=20.04/edge' | jq '.download_url' -r) --output prometheus.snap; \
16+ curl -L $(curl -H 'X-Ubuntu-Series: 16' 'https://api.snapcraft.io/api/v1/snaps/details/prometheus?channel=21.04/edge' | jq '.download_url' -r) --output prometheus.snap; \
17 mkdir -p /snap; \
18 unsquashfs -d /snap/prometheus prometheus.snap
19
20-FROM ubuntu:focal
21+FROM ubuntu:hirsute
22
23 ENV TZ UTC
24
25diff --git a/README.md b/README.md
26index a1e5136..9c98e64 100644
27--- a/README.md
28+++ b/README.md
29@@ -19,7 +19,7 @@ _Tags in italics are not available in ubuntu/prometheus but are shown here for c
30
31 | Channel Tag | | | Currently | Architectures |
32 |---|---|---|---|---|
33-| **`2.20-20.04_beta`**    | | | Prometheus 2.20.1 on Ubuntu 20.04 LTS | `amd64`, `arm64`, `ppc64el`, `s390x` |
34+| **`2.25-21.04_beta`**    | | | Prometheus 2.25.2 on Ubuntu 21.04 | `amd64`, `arm64`, `ppc64el`, `s390x` |
35 | _`track_risk`_ |
36
37 Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.
38@@ -30,7 +30,7 @@ Channel tag shows the most stable channel for that track ordered `stable`, `cand
39 Launch this image locally:
40
41 ```sh
42-docker run -d --name prometheus-container -e TZ=UTC -p 30090:9090 ubuntu/prometheus:2.20-20.04_beta
43+docker run -d --name prometheus-container -e TZ=UTC -p 30090:9090 ubuntu/prometheus:2.25-21.04_beta
44 ```
45 Access your Prometheus server at `localhost:30090`.
46
47@@ -40,8 +40,8 @@ Access your Prometheus server at `localhost:30090`.
48 |---|---|
49 | `-e TZ=UTC` | Timezone. |
50 | `-p 30090:9090` | Expose Prometheus server on `localhost:30090`. |
51-| `-v /path/to/prometheus.yml:/etc/prometheus/prometheus.yml` | Local [configuration file](https://prometheus.io/docs/prometheus/2.20/configuration/configuration/) `prometheus.yml` (try [this example](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/prometheus.yml?h=2.20-20.04)). |
52-| `-v /path/to/alerts.yml:/etc/prometheus/alerts.yml` | Local [alert configuration file](https://prometheus.io/docs/prometheus/2.20/configuration/configuration/) `alerts.yml` (try [this example](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/alerts.yml?h=2.20-20.04)). |
53+| `-v /path/to/prometheus.yml:/etc/prometheus/prometheus.yml` | Local [configuration file](https://prometheus.io/docs/prometheus/2.25/configuration/configuration/) `prometheus.yml` (try [this example](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/prometheus.yml?h=2.25-21.04)). |
54+| `-v /path/to/alerts.yml:/etc/prometheus/alerts.yml` | Local [alert configuration file](https://prometheus.io/docs/prometheus/2.25/configuration/configuration/) `alerts.yml` (try [this example](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/alerts.yml?h=2.25-21.04)). |
55
56
57 #### Testing/Debugging
58@@ -64,8 +64,8 @@ docker exec -it prometheus-container /bin/bash
59 Works with any Kubernetes; if you don't have one, we recommend you [install MicroK8s](https://microk8s.io/) and `microk8s.enable dns storage` then `snap alias microk8s.kubectl kubectl`.
60
61 Download
62-[prometheus.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/prometheus.yml?h=2.20-20.04), [alerts.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/alerts.yml?h=2.20-20.04) and
63-[prometheus-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/prometheus-deployment.yml?h=2.20-20.04) and set `containers.prometheus.image` in `prometheus-deployment.yml` to your chosen channel tag (e.g. `ubuntu/prometheus:2.20-20.04_beta`), then:
64+[prometheus.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/prometheus.yml?h=2.25-21.04), [alerts.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/alerts.yml?h=2.25-21.04) and
65+[prometheus-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/prometheus-deployment.yml?h=2.25-21.04) and set `containers.prometheus.image` in `prometheus-deployment.yml` to your chosen channel tag (e.g. `ubuntu/prometheus:2.25-21.04_beta`), then:
66
67 ```sh
68 kubectl create configmap prometheus-config --from-file=prometheus=prometheus.yml --from-file=prometheus-alerts=alerts.yml
69diff --git a/data/prometheus.yaml b/data/prometheus.yaml
70index a766c44..e01e1c9 100644
71--- a/data/prometheus.yaml
72+++ b/data/prometheus.yaml
73@@ -3,8 +3,8 @@ main: false
74 repo: prometheus
75 description: >
76 Prometheus is a systems and service monitoring system. It collects metrics from configured targets at given intervals, evaluates rule expressions, displays the results, and can trigger alerts if some condition is observed to be true. Read more on the [Prometheus website](https://prometheus.io/).
77-version: 2.20.1
78-base: Ubuntu 20.04 LTS
79+version: 2.25.2
80+base: Ubuntu 21.04
81 architectures:
82 - amd64
83 - arm64
84@@ -23,10 +23,10 @@ parameters:
85 description: Expose Prometheus server on `localhost:30090`.
86 - type: -v
87 value: /path/to/prometheus.yml:/etc/prometheus/prometheus.yml
88- description: Local [configuration file](https://prometheus.io/docs/prometheus/2.20/configuration/configuration/) `prometheus.yml` (try [this example](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/prometheus.yml?h=2.20-20.04)).
89+ description: Local [configuration file](https://prometheus.io/docs/prometheus/2.25/configuration/configuration/) `prometheus.yml` (try [this example](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/prometheus.yml?h=2.25-21.04)).
90 - type: -v
91 value: /path/to/alerts.yml:/etc/prometheus/alerts.yml
92- description: Local [alert configuration file](https://prometheus.io/docs/prometheus/2.20/configuration/configuration/) `alerts.yml` (try [this example](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/alerts.yml?h=2.20-20.04)).
93+ description: Local [alert configuration file](https://prometheus.io/docs/prometheus/2.25/configuration/configuration/) `alerts.yml` (try [this example](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/alerts.yml?h=2.25-21.04)).
94 debug:
95 - nothing
96 microk8s:
97@@ -34,10 +34,10 @@ microk8s:
98 files:
99 - key: prometheus
100 name: prometheus.yml
101- link: https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/prometheus.yml?h=2.20-20.04
102+ link: https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/prometheus.yml?h=2.25-21.04
103 - key: prometheus-alerts
104 name: alerts.yml
105- link: https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/alerts.yml?h=2.20-20.04
106+ link: https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/config/alerts.yml?h=2.25-21.04
107 deploy:
108- link: https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/prometheus-deployment.yml?h=2.20-20.04
109+ link: https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/prometheus/plain/examples/prometheus-deployment.yml?h=2.25-21.04
110 access: You will now be able to connect to the Prometheus on `http://localhost:30090`.

Subscribers

People subscribed via source and target branches