Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus:update-20.04-snap into ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus:2.20-20.04
Proposed by
Sergio Durigan Junior
| Status: | Merged |
|---|---|
| Merged at revision: | 44a4c76c0180be03198c55c1827cc9b0f31bc33c |
| Proposed branch: | ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus:update-20.04-snap |
| Merge into: | ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus:2.20-20.04 |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Bryce Harrington | Approve | ||
| Lucas Kanashiro | Pending | ||
| Canonical Server | Pending | ||
|
Review via email:
|
|||
Description of the change
This is another one of those huge MPs that delete the (now unused) upstream source and convert the OCI image to build from the snap instead. Now that we have access to the prometheus snap/LP project, we're able to finally do this conversion.
I've built and tested the resulting image against our unit tests, and everything is OK. Something that caught my attention was the fact that the old Dockerfile was passing a few more arguments to prometheus when starting the service, and these arguments seemed to be related to the web interface, so I quickly brought a prometheus container up and checked that the web interface still works.
To post a comment you must log in.
Revision history for this message
| Sergio Durigan Junior (sergiodj) wrote | # |
As usual, the real changes happened with the Dockerfile, HACKING.md, README.md and data/*.yaml. I'm adding Lucas to the list of potential reviewers because he authored the first version of this image.