Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus-alertmanager:snap-channel into ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus-alertmanager:0.21-21.04

Proposed by Sergio Durigan Junior
Status: Merged
Merged at revision: a0f5cedf57b783ac464e4893ec3bcac8a345184d
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus-alertmanager:snap-channel
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/prometheus-alertmanager:0.21-21.04
Diff against target: 12 lines (+1/-1)
1 file modified
Dockerfile (+1/-1)
Reviewer Review Type Date Requested Status
Lucas Kanashiro Approve
Bryce Harrington Pending
Review via email: mp+399683@code.launchpad.net

Description of the change

Use the proper snap channel when downloading the snap, now that we have tracks for 20.04 and 21.04.

To post a comment you must log in.
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

LGTM, +1.

It built fine locally and the tests are passing.

review: Approve
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Lucas. I've merged the branch.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index 2b5caa0..28a5cba 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -7,7 +7,7 @@ RUN set -eux; \
6 jq curl ca-certificates squashfs-tools; \
7 # taken from https://snapcraft.io/docs/build-on-docker
8 # Alternatively, we can install snapd, and issue `snap download prometheus-alertmanager`
9- curl -L $(curl -H 'X-Ubuntu-Series: 16' 'https://api.snapcraft.io/api/v1/snaps/details/prometheus-alertmanager?channel=edge' | jq '.download_url' -r) --output prometheus-alertmanager.snap; \
10+ curl -L $(curl -H 'X-Ubuntu-Series: 16' 'https://api.snapcraft.io/api/v1/snaps/details/prometheus-alertmanager?channel=21.04/edge' | jq '.download_url' -r) --output prometheus-alertmanager.snap; \
11 mkdir -p /snap; \
12 unsquashfs -d /snap/prometheus-alertmanager prometheus-alertmanager.snap
13

Subscribers

People subscribed via source and target branches

to all changes: