Ubuntu Docker Images

Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/memcached:1.6-23.04 into ~ubuntu-docker-images/ubuntu-docker-images/+git/memcached:1.6-22.10

  1. Git
  2. lp:~ubuntu-docker-images/ubuntu-docker-images/+git/memcached
  3. 1.6-23.04
  4. Merge into 1.6-22.10
Proposed by Athos Ribeiro
Status: Merged
Merge reported by: Athos Ribeiro
Merged at revision: a8a60750fb49a6a4b399bdf2a79553be0be57cc6
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/memcached:1.6-23.04
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/memcached:1.6-22.10
Diff against target: 9 lines (+1/-1)
1 file modified
Dockerfile (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Bryce Harrington Pending
Canonical Server packageset reviewers Pending
Canonical Server Reporter Pending
Review via email: mp+441364@code.launchpad.net

Description of the change

This is the new branch for the lunar OCI. Once reviewed and approved, I will proceed to create the OCI recipes.

memcached had errors due to changes in the upstream code. The new 1.1.x version
refactored the code base to consolidate the command line tools i/o. This
required a change in the test scripts.

A fix was proposed and merged at
https://github.com/canonical/server-test-scripts/pull/175

with that patch, the tests pass for both the current images available in the
registry and the lunar one.

$ DOCKER_IMAGE=localhost/memcached:1.6-23.04 sh memcached_test.sh
test_local_connection
test_network_connection
test_custom_flags
test_libmemcached_compliance
test_data_storage_and_retrieval
test_manifest_exists

Ran 6 tests.

OK

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

I'll take a look tomorrow.

Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Athos.

Builds and tests fine. LGTM, +1.

review: Approve
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Sergio!

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index 356af00..c1f2db9 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -1,4 +1,4 @@
6-FROM ubuntu:kinetic
7+FROM ubuntu:lunar
8
9 ENV TZ UTC
10

Subscribers

People subscribed via source and target branches

to all changes: