Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:7.4-21.10-wip into ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:7.4-21.04

Proposed by Athos Ribeiro
Status: Rejected
Rejected by: Athos Ribeiro
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:7.4-21.10-wip
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/grafana:7.4-21.04
Diff against target: 79 lines (+7/-7)
4 files modified
Dockerfile (+2/-2)
HACKING.md (+1/-1)
README.md (+3/-3)
data/grafana.yaml (+1/-1)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Needs Fixing
Bryce Harrington Pending
Canonical Server Pending
Review via email: mp+403533@code.launchpad.net

Description of the change

This change creates the grafana OCI image for impish.

Just the trivial changes were needed and no regressions were detected when running the unit test.

Note that this MP is targeting the 7.4-21.04 branch solely for comparing purposes. When accepted, these changes should be pushed into a new 7.4-21.10 branch.

Moreover, we did not change the snap track for fetching the snap, since an impish track is not available yet.

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks for the MP, Athos.

For these images, I think it's better if we work on creating the proper snap tracks and then updating the snaps themselves. Let's put this MP on hold until then.

review: Needs Fixing
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

BTW, the same applies to the other images are based on snaps.

Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Closing this one for now. I will either reopen it or file a new MP when the time comes for us to create and build new impish OCI images.

Unmerged commits

012b37e... by Athos Ribeiro

Regenerate documentation

Signed-off-by: Athos Ribeiro <email address hidden>

1d1c2f6... by Athos Ribeiro

Update to impish

Update the image to be based on impish. Note that until there is an
impish track for the grafana snap, we will keep using the hirsute one.

Signed-off-by: Athos Ribeiro <email address hidden>

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index ba826ca..5e36aae 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -4,7 +4,7 @@
6 # and adapted to use the grafana snap built from
7 # https://github.com/auria/snap-grafana and installed from
8 # https://snapcraft.io/grafana
9-FROM ubuntu:hirsute AS snap-installer
10+FROM ubuntu:impish AS snap-installer
11
12 RUN apt-get update && \
13 DEBIAN_FRONTEND=noninteractive apt-get dist-upgrade -y && \
14@@ -18,7 +18,7 @@ RUN curl -L $(curl -H 'X-Ubuntu-Series: 16' 'https://api.snapcraft.io/api/v1/sna
15 RUN mkdir -p /snap && unsquashfs -d /snap/grafana grafana.snap
16
17
18-FROM ubuntu:hirsute
19+FROM ubuntu:impish
20
21 EXPOSE 3000
22 LABEL maintainer="Ubuntu Server team <ubuntu-server@lists.ubuntu.com>"
23diff --git a/HACKING.md b/HACKING.md
24index 9448300..fca4771 100644
25--- a/HACKING.md
26+++ b/HACKING.md
27@@ -7,7 +7,7 @@ In order to contribute to the Grafana OCI image do the following:
28 * Build a new image with your changes. You can use the following command:
29
30 ```
31-$ docker build -t ubuntu/grafana:test
32+$ docker build -t ubuntu/grafana:test .
33 ```
34
35 * Test the new image. Run it in some way that exercise your changes, you can also check th README.md file.
36diff --git a/README.md b/README.md
37index 2f3e897..d6aea31 100644
38--- a/README.md
39+++ b/README.md
40@@ -19,7 +19,7 @@ _Tags in italics are not available in ubuntu/grafana but are shown here for comp
41
42 | Channel Tag | | | Currently | Architectures |
43 |---|---|---|---|---|
44-| **`7.4-21.04_beta`** &nbsp;&nbsp; | | | Grafana 7.4.1 on Ubuntu 21.04 | `amd64`, `arm64`, `ppc64el`, `s390x` |
45+| **`7.4-21.10_beta`** &nbsp;&nbsp; | | | Grafana 7.4.1 on Ubuntu 21.10 | `amd64`, `arm64`, `ppc64el`, `s390x` |
46 | _`track_risk`_ |
47
48 Channel tag shows the most stable channel for that track ordered `stable`, `candidate`, `beta`, `edge`. More risky channels are always implicitly available. So if `beta` is listed, you can also pull `edge`. If `candidate` is listed, you can pull `beta` and `edge`. When `stable` is listed, all four are available. Images are guaranteed to progress through the sequence `edge`, `beta`, `candidate` before `stable`.
49@@ -30,7 +30,7 @@ Channel tag shows the most stable channel for that track ordered `stable`, `cand
50 Launch this image locally:
51
52 ```sh
53-docker run -d --name grafana-container -e TZ=UTC -p 30000:3000 ubuntu/grafana:7.4-21.04_beta
54+docker run -d --name grafana-container -e TZ=UTC -p 30000:3000 ubuntu/grafana:7.4-21.10_beta
55 ```
56 Access your Grafana server at `localhost:30000`.
57
58@@ -65,7 +65,7 @@ Works with any Kubernetes; if you don't have one, we recommend you [install Micr
59
60 Download
61 [datasource.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/config/datasource.yml), [dashboard.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/config/dashboard.yml), [system-stats-dashboard.json](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/config/system-stats-dashboard.json) and
62-[grafana-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/grafana-deployment.yml) and set `containers.grafana.image` in `grafana-deployment.yml` to your chosen channel tag (e.g. `ubuntu/grafana:7.4-21.04_beta`), then:
63+[grafana-deployment.yml](https://git.launchpad.net/~canonical-server/ubuntu-docker-images/+git/grafana/plain/examples/grafana-deployment.yml) and set `containers.grafana.image` in `grafana-deployment.yml` to your chosen channel tag (e.g. `ubuntu/grafana:7.4-21.10_beta`), then:
64
65 ```sh
66 kubectl create configmap grafana-config --from-file=grafana-datasource=datasource.yml --from-file=grafana-dashboard-definition=dashboard.yml --from-file=grafana-dashboard=system-stats-dashboard.json
67diff --git a/data/grafana.yaml b/data/grafana.yaml
68index efcd5f5..ec600f9 100644
69--- a/data/grafana.yaml
70+++ b/data/grafana.yaml
71@@ -5,7 +5,7 @@ description: >
72 Grafana is a feature rich metrics dashboard and graph editor for Cloudwatch, Elasticsearch, Graphite, InfluxDB, OpenTSB, Prometheus, and Hosted Metrics.
73 Read more on the [Grafana website](https://grafana.com/docs/).
74 version: 7.4.1
75-base: Ubuntu 21.04
76+base: Ubuntu 21.10
77 architectures:
78 - amd64
79 - arm64

Subscribers

People subscribed via source and target branches

to all changes: