Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/cortex:1.7-21.04-fix-missing-manifest into ~ubuntu-docker-images/ubuntu-docker-images/+git/cortex:1.7-21.04

Proposed by Athos Ribeiro
Status: Merged
Merge reported by: Athos Ribeiro
Merged at revision: e2fd798601fa167e6a2bfb6a098d41fc84f1ad53
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/cortex:1.7-21.04-fix-missing-manifest
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/cortex:1.7-21.04
Diff against target: 17 lines (+4/-2)
1 file modified
oci/Dockerfile.ubuntu (+4/-2)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Ubuntu Docker Images Pending
Review via email: mp+406556@code.launchpad.net

Description of the change

Using pipes without properly handling the earlier commands may conceal errors even when "set -e" is used.

Since setting the pipefail option may not be an alternative (we are
using dash), we should refactor commands using pipes to avoid concealing
errors.

This should avoid releasing images with missing bits.

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

LGTM, thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/oci/Dockerfile.ubuntu b/oci/Dockerfile.ubuntu
2index 0775c33..237d6f9 100644
3--- a/oci/Dockerfile.ubuntu
4+++ b/oci/Dockerfile.ubuntu
5@@ -28,8 +28,10 @@ RUN set -eux; \
6 #
7 # https://github.com/golang/go/issues/35224
8 # https://bugs.launchpad.net/docker.io/+bug/1916296
9- go list -mod=mod -m all | tail -n +2 > /src/cortex/cortex-mods.txt; \
10- /src/cortex/utils/golang-manifest-builder.py /src/cortex/cortex-mods.txt | tee /src/cortex/manifest-upstream.txt
11+ go list -mod=mod -m all > /tmp/cortex-go-list.output; \
12+ tail -n +2 /tmp/cortex-go-list.output > /src/cortex/cortex-mods.txt; \
13+ /src/cortex/utils/golang-manifest-builder.py /src/cortex/cortex-mods.txt > /src/cortex/manifest-upstream.txt; \
14+ cat /src/cortex/manifest-upstream.txt;
15
16 # Prepare the final container
17 FROM ubuntu:hirsute

Subscribers

People subscribed via source and target branches

to all changes: