Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/cassandra:4.0-20.04-wip into ~ubuntu-docker-images/ubuntu-docker-images/+git/cassandra:main

Proposed by Athos Ribeiro
Status: Merged
Merge reported by: Athos Ribeiro
Merged at revision: 3a205549014000a2604fa466083d020a2eb37afc
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/cassandra:4.0-20.04-wip
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/cassandra:main
Diff against target: 15 lines (+2/-2)
1 file modified
Dockerfile (+2/-2)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Bryce Harrington Pending
Canonical Server Pending
Review via email: mp+404894@code.launchpad.net

Description of the change

New 20.04 branch. Note that this is targeting main for comparison purposes only. This will be pushed to a new 4.0-20.04 branch from where the OCI will be built.

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Athos.

I looked at the MP and the modifications LGTM.

I am approving it, but we shouldn't publish anything until we have at least the unit tests ready for the image. It is really helpful when we can perform the tests after building the image locally and make sure that everything is working.

Thanks again.

review: Approve
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks, Sergio!

I will finish working on the integration tests before we start publishing these images :)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index ef4d6da..7d28709 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -7,10 +7,10 @@ RUN set -eux; \
6 apt-get update && \
7 DEBIAN_FRONTEND=noninteractive apt-get full-upgrade -y && \
8 DEBIAN_FRONTEND=noninteractive apt-get install -y \
9- curl ca-certificates squashfs-tools && \
10+ jq curl ca-certificates squashfs-tools && \
11 # taken from https://snapcraft.io/docs/build-on-docker
12 # Alternatively, we can install snapd, and issue `snap download cassandra`
13- curl -L 'https://launchpad.net/~athos-ribeiro/+snap/cassandra-test/+build/1437307/+files/cassandra_4.0-rc1_amd64.snap' --output cassandra.snap && \
14+ curl -L $(curl -H 'X-Ubuntu-Series: 16' -H "X-Ubuntu-Architecture: $(dpkg --print-architecture)" 'https://api.snapcraft.io/api/v1/snaps/details/cassandra?channel=20.04/edge' | jq '.download_url' -r) --output cassandra.snap && \
15 mkdir -p /snap && unsquashfs -d /snap/cassandra cassandra.snap
16
17

Subscribers

People subscribed via source and target branches

to all changes: