Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:2.4-22.10 into ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:2.4-22.04

Proposed by Athos Ribeiro
Status: Merged
Merge reported by: Athos Ribeiro
Merged at revision: 9ac9231be1ec378a8248cb6446bbc7c7c75a3b1f
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:2.4-22.10
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:2.4-22.04
Diff against target: 23 lines (+6/-2)
1 file modified
Dockerfile (+6/-2)
Reviewer Review Type Date Requested Status
Sergio Durigan Junior Approve
Bryce Harrington Pending
Canonical Server Reporter Pending
Review via email: mp+429067@code.launchpad.net

Description of the change

This is the proposal for the new apache2 kinietic ROCK. The new branch will be named 2.4-22.10.

This also introduces a change to forward logs to stdout/stderr but default.

Local test suite run:

$ DOCKER_IMAGE=localhost/apache2:kinetic sh apache2_test.sh
Error response from daemon: Get "http://localhost/v2/": dial tcp 127.0.0.1:80: connect: connection refused
test_default_config
test_default_config_ipv6
test_static_content
test_custom_config
test_manifest_exists

Ran 5 tests.

OK

To post a comment you must log in.
Revision history for this message
Sergio Durigan Junior (sergiodj) wrote :

Thanks, Athos.

I verified that the configuration files are properly adjusted to write logs to stdout/stderr. The image builds & tests fine locally.

LGMT.

review: Approve
Revision history for this message
Athos Ribeiro (athos-ribeiro) wrote :

Thanks Sergio!

I created the recipe without a push rule for this one.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index 82a612d..e137092 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -1,4 +1,4 @@
6-FROM ubuntu:jammy
7+FROM ubuntu:kinetic
8
9 ENV TZ UTC
10
11@@ -16,7 +16,11 @@ RUN set -eux; \
12 apache2 -v; \
13 # create manifest
14 mkdir -p /usr/share/rocks; \
15- (echo "# os-release" && cat /etc/os-release && echo "# dpkg-query" && dpkg-query -f '${db:Status-Abbrev},${binary:Package},${Version},${source:Package},${Source:Version}\n' -W) > /usr/share/rocks/dpkg.query
16+ (echo "# os-release" && cat /etc/os-release && echo "# dpkg-query" && dpkg-query -f '${db:Status-Abbrev},${binary:Package},${Version},${source:Package},${Source:Version}\n' -W) > /usr/share/rocks/dpkg.query; \
17+# Write logs to stderr/stdout
18+ sed -i 's|^ErrorLog .*$|ErrorLog /dev/stderr|' /etc/apache2/apache2.conf; \
19+ sed -i '/^ErrorLog /a TransferLog /dev/stdout' /etc/apache2/apache2.conf; \
20+ sed -i -e '/ErrorLog /d' -e '/CustomLog /d' /etc/apache2/sites-available/000-default.conf /etc/apache2/sites-available/default-ssl.conf
21
22 # https://httpd.apache.org/docs/2.4/stopping.html#gracefulstop
23 STOPSIGNAL SIGWINCH

Subscribers

People subscribed via source and target branches

to all changes: