Merge ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:set-tz-utc into ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:edge

Proposed by Sergio Durigan Junior
Status: Merged
Merged at revision: 0cad654a5557f7942bb8494043282acffa85c749
Proposed branch: ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:set-tz-utc
Merge into: ~ubuntu-docker-images/ubuntu-docker-images/+git/apache2:edge
Diff against target: 19 lines (+3/-1)
1 file modified
Dockerfile (+3/-1)
Reviewer Review Type Date Requested Status
Lucas Kanashiro Approve
Valentin Viennot (community) Approve
Canonical Server Pending
Review via email: mp+394117@code.launchpad.net

Description of the change

Set TZ=UTC on the image.

To post a comment you must log in.
Revision history for this message
Valentin Viennot (valentinviennot) wrote :

+1, LGTM. Doesn't seem to change the image size too much!

review: Approve
Revision history for this message
Lucas Kanashiro (lucaskanashiro) wrote :

It also LGTM, +1.

To make sure the TZ is correctly set to UTC I ran this:

$ docker build -t squeakywheel/apache2:test .
$ docker run -it squeakywheel/apache2:test /bin/bash
root@9fd40662020d:/# date
Wed Nov 18 17:25:59 UTC 2020

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/Dockerfile b/Dockerfile
2index 580c818..344133f 100644
3--- a/Dockerfile
4+++ b/Dockerfile
5@@ -217,11 +217,13 @@ FROM ubuntu:focal
6 # # smoke test
7 # httpd -v
8
9+ENV TZ UTC
10+
11 RUN set -eux; \
12 apt-get update \
13 && DEBIAN_FRONTEND=noninteractive apt-get upgrade -y \
14 # Needed for generating random passwords.
15- && DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y apache2 \
16+ && DEBIAN_FRONTEND=noninteractive apt-get install --no-install-recommends -y apache2 tzdata \
17 && rm -rf /var/lib/apt/lists/* \
18 # smoke test
19 && apache2 -v

Subscribers

People subscribed via source and target branches

to all changes: