Merge ~ubuntu-docker-images/prometheus-alertmanager-snap:update-to-version-0.21.0 into ~canonical-is-sa/prometheus-alertmanager-snap:master

[Lucas Kanashiro]

Update to version 0.21.0 (LP: #1883945)

Update prometheus-alertmanager snap to the latest upstream version (0.21.0). The Server team is working on prometheus-alertmanager for the LMA stack we want to support, and we noticed the prometheus-alertmanager snap is quite outdated (there is also a request for update in LP #1883945). We think we can work together with the IS team to provide and up-to-dated snap. A summary of the proposed changes:

- Update to version 0.21.0
- Build the snap based on core18
- Build the snap for different architectures: amd64, arm64, ppc64el and s390x
- Rewrite part of 'alertmanager' parts section
  + Run a set of upstream tests during build time

I have personally played with it locally and AFAICS it looks good, works well. I also built the snap in all 4 architectures here:

https://code.launchpad.net/~lucaskanashiro/+snap/prometheus-alertmanager

Thanks for considering those changes, feedback is appreciated.

[Lucas Kanashiro (lucaskanashiro)]

Any feedback?

[Tom Haddon (mthaddon)]

I suspect there should be someone else involved in the review of this, as jldev owns the snap. I'll reach out to him and confirm one way or the other.

[Junien F (axino)]

LGTM (with just a very minor issue), thanks a lot for doing that !

review: Approve

[Tom Haddon (mthaddon)]

One other minor comment inline

[Lucas Kanashiro (lucaskanashiro)]

Thanks again Junien and Tom! Comments addressed and up for review again.

[Lucas Kanashiro (lucaskanashiro)]

Is there something blocking this MP?

[Junien F (axino)]

llama charmers approval I would say

[Jeremy Lounder (jldev)]

review: Approve

[Haw Loeung (hloeung)]

LGTM

review: Approve (+1)

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

[Tom Haddon (mthaddon)]

LGTM

review: Approve

[🤖 Canonical IS Merge Bot (canonical-is-mergebot)]

Failed to merge change (no changes to merge), setting status to needs review.

diff --git a/snapcraft.yaml b/snapcraft.yaml
index d343c22..5f8a4db 100644
--- a/snapcraft.yaml
+++ b/snapcraft.yaml
@@ -1,10 +1,17 @@
 name: prometheus-alertmanager
-version: 0.15.2
+version: 0.21.0
+base: core18
 grade: stable
 summary: The Prometheus alertmanager
 description: |
   The Alertmanager handles alerts sent by client applications such as the Prometheus server. It takes care of deduplicating, grouping, and routing them to the correct receiver integration such as email, PagerDuty, or OpsGenie. It also takes care of silencing and inhibition of alerts.
 confinement: strict
+architectures:
+  - build-on: amd64
+  - build-on: arm64
+  - build-on: ppc64el
+  - build-on: s390x
+
 apps:
   alertmanager:
     command: 'bin/prometheus-alertmanager.wrapper'
@@ -14,26 +21,23 @@ apps:
     command: 'bin/amtool'
     plugs: [network]
 parts:
-  go:
-    source-tag: go1.9
   alertmanager:
-    after: [go]
     plugin: go
+    go-channel: 1.14/stable
     source: https://github.com/prometheus/alertmanager.git
-    source-tag: v0.15.2
+    source-tag: v${SNAPCRAFT_PROJECT_VERSION}
     go-importpath: github.com/prometheus/alertmanager
-    build: |
-        export "GOPATH=$PWD/../go"
-        cd ../go/src/github.com/prometheus/alertmanager/
+    build-packages: [build-essential, curl, make]
+    override-build: |
         make build
-    install: |
-        mkdir $SNAPCRAFT_PART_INSTALL/bin
-        cp -p $SNAPCRAFT_PART_INSTALL/../src/alertmanager $SNAPCRAFT_PART_INSTALL/bin/
-        cp -p $SNAPCRAFT_PART_INSTALL/../src/amtool $SNAPCRAFT_PART_INSTALL/bin/
+        make common-test-short
+        mkdir -p $SNAPCRAFT_PART_INSTALL/bin
+        cp -p $SNAPCRAFT_PART_BUILD/alertmanager $SNAPCRAFT_PART_INSTALL/bin/
+        cp -p $SNAPCRAFT_PART_BUILD/amtool $SNAPCRAFT_PART_INSTALL/bin/
   example-config:
     plugin: dump
     source: https://github.com/prometheus/alertmanager.git
-    source-tag: v0.15.2
+    source-tag: v${SNAPCRAFT_PROJECT_VERSION}
     organize:
       doc/examples/simple.yml: etc/prometheus/alertmanager.yml.example
     prime: