Ubuntu
gnome-initial-setup package

Merge ~ubuntu-desktop/ubuntu/+source/gnome-initial-setup:report-keyboard-navigation into ~ubuntu-desktop/ubuntu/+source/gnome-initial-setup:ubuntu/master

Proposed by Sebastien Bacher on 2019-01-17

Status:	Merged
Merged at revision:	aaf7f6120ef8d0003bf4595d1416a54dbf343172
Proposed branch:	~ubuntu-desktop/ubuntu/+source/gnome-initial-setup:report-keyboard-navigation
Merge into:	~ubuntu-desktop/ubuntu/+source/gnome-initial-setup:ubuntu/master
Diff against target:	22 lines (+2/-2) 1 file modified debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch (+2/-2)
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Andrea Azzarone (community)		2019-01-17	Approve on 2019-01-17
Review via email: mp+361873@code.launchpad.net

Set the ubuntu-report yes/no controls to accept focus

Those options can't be changed by keyboard navigation otherwise

Set the ubuntu-report yes/no controls to accept focus

Those options can't be changed by keyboard navigation otherwise

Revision history for this message

Andrea Azzarone (azzar1) wrote on 2019-01-17:

LGTM.

review: Approve

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk

People subscribed via source and target branches

to all changes:

1	diff --git a/debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch b/debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch
2	index ddef978..f5f66d5 100644
3	--- a/debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch
4	+++ b/debian/patches/0001-Add-Ubuntu-mode-with-special-pages.patch
5	@@ -3295,7 +3295,7 @@ index 0000000..f8474a2
6	+ <child>
7	+ <object class="GtkRadioButton" id="opt_in_radio">
8	+ <property name="visible">True</property>
9	-+ <property name="can_focus">False</property>
10	++ <property name="can_focus">True</property>
11	+ <property name="margin_top">18</property>
12	+ <property name="xalign">0</property>
13	+ <property name="label" translatable="yes">Yes, send system info to Canonical</property>
14	@@ -3304,7 +3304,7 @@ index 0000000..f8474a2
15	+ <child>
16	+ <object class="GtkRadioButton" id="opt_out_radio">
17	+ <property name="visible">True</property>
18	-+ <property name="can_focus">False</property>
19	++ <property name="can_focus">True</property>
20	+ <property name="margin_top">6</property>
21	+ <property name="xalign">0</property>
22	+ <property name="label" translatable="yes">No, don't send system info</property>