Merge ~ubuntu-core-dev/grub/+git/ubuntu:wip/postinst-check into ~ubuntu-core-dev/grub/+git/ubuntu:focal

Proposed by Dimitri John Ledkov
Status: Rejected
Rejected by: Dimitri John Ledkov
Proposed branch: ~ubuntu-core-dev/grub/+git/ubuntu:wip/postinst-check
Merge into: ~ubuntu-core-dev/grub/+git/ubuntu:focal
Diff against target: 13 lines (+1/-1)
1 file modified
debian/postinst.in (+1/-1)
Reviewer Review Type Date Requested Status
Ubuntu Core Development Team Pending
Review via email: mp+388432@code.launchpad.net

Commit message

grub-pc/postinst: fail noninteractive installation if devices failed to install

To post a comment you must log in.

Unmerged commits

f5399ac... by Dimitri John Ledkov

grub-pc/postinst: fail noninteractive installation if devices failed to install

When upgrading non-interactively, and grub-pc installation fails on to
the configured devices fail the package configuration.

This will generate apport crash report and signal that one may fail to
reboot due to potential missmatch between core and modules..

LP: #1889556

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/debian/postinst.in b/debian/postinst.in
2index 4e1dafa..d0e68ae 100644
3--- a/debian/postinst.in
4+++ b/debian/postinst.in
5@@ -658,7 +658,7 @@ case "$1" in
6 continue
7 fi
8 else
9- break # noninteractive
10+ exit 1 # noninteractive
11 fi
12 fi
13 fi

Subscribers

People subscribed via source and target branches