Merge lp:~ubuntu-clock-dev/ubuntu-clock-app/5-finish-alarm-migration into lp:ubuntu-clock-app

Proposed by Nekhelesh Ramananthan
Status: Merged
Approved by: Nekhelesh Ramananthan
Approved revision: 280
Merged at revision: 313
Proposed branch: lp:~ubuntu-clock-dev/ubuntu-clock-app/5-finish-alarm-migration
Merge into: lp:ubuntu-clock-app
Prerequisite: lp:~ubuntu-clock-dev/ubuntu-clock-app/4-migrate-alarm-listitems
Diff against target: 130 lines (+16/-11)
5 files modified
app/alarm/AlarmRepeat.qml (+4/-4)
app/alarm/AlarmSound.qml (+8/-3)
app/alarm/EditAlarmPage.qml (+0/-1)
debian/changelog (+1/-0)
po/com.ubuntu.clock.pot (+3/-3)
To merge this branch: bzr merge lp:~ubuntu-clock-dev/ubuntu-clock-app/5-finish-alarm-migration
Reviewer Review Type Date Requested Status
Ubuntu Phone Apps Jenkins Bot continuous-integration Approve
Bartosz Kosiorek Approve
Review via email: mp+263890@code.launchpad.net

Commit message

Finishes alarm lists migrations

Description of the change

Finishes alarm lists migrations

To post a comment you must log in.
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bartosz Kosiorek (gang65) wrote :

It's works perfectly

review: Approve
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) wrote :

FAILED: Autolanding.
More details in the following jenkins job:
http://91.189.93.70:8080/job/ubuntu-clock-app-autolanding/268/
Executed test runs:
    FAILURE: http://91.189.93.70:8080/job/ubuntu-clock-app-vivid-amd64-autolanding/25/console

review: Needs Fixing (continuous-integration)
Revision history for this message
Ubuntu Phone Apps Jenkins Bot (ubuntu-phone-apps-jenkins-bot) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'app/alarm/AlarmRepeat.qml'
2--- app/alarm/AlarmRepeat.qml 2015-05-27 16:03:23 +0000
3+++ app/alarm/AlarmRepeat.qml 2015-07-24 13:36:33 +0000
4@@ -18,7 +18,6 @@
5
6 import QtQuick 2.4
7 import Ubuntu.Components 1.2
8-import Ubuntu.Components.ListItems 1.0 as ListItem
9
10 Page {
11 id: _alarmRepeatPage
12@@ -109,7 +108,7 @@
13
14 model: daysModel
15
16- ListItem.Standard {
17+ ListItem {
18 id: _alarmDayHolder
19 objectName: "alarmDayHolder" + index
20
21@@ -129,13 +128,14 @@
22 text: day
23 }
24
25- control: CheckBox {
26+ CheckBox {
27 id: daySwitch
28 objectName: 'daySwitch' + index
29
30 anchors {
31 right: parent.right
32- rightMargin: units.gu(-0.2)
33+ rightMargin: units.gu(2)
34+ verticalCenter: parent.verticalCenter
35 }
36
37 checked: (alarm.daysOfWeek & flag) == flag
38
39=== modified file 'app/alarm/AlarmSound.qml'
40--- app/alarm/AlarmSound.qml 2015-05-27 16:03:23 +0000
41+++ app/alarm/AlarmSound.qml 2015-07-24 13:36:33 +0000
42@@ -19,7 +19,6 @@
43 import QtQuick 2.4
44 import QtMultimedia 5.0
45 import Ubuntu.Components 1.2
46-import Ubuntu.Components.ListItems 1.0 as ListItem
47
48 Page {
49 id: _alarmSoundPage
50@@ -67,7 +66,7 @@
51
52 model: soundModel
53
54- ListItem.Standard {
55+ ListItem {
56 id: _alarmSoundDelegate
57
58 property alias isChecked: _soundStatus.checked
59@@ -89,10 +88,16 @@
60 text: fileBaseName
61 }
62
63- control: CheckBox {
64+ CheckBox {
65 id: _soundStatus
66 objectName: "soundStatus" + index
67
68+ anchors {
69+ right: parent.right
70+ rightMargin: units.gu(2)
71+ verticalCenter: parent.verticalCenter
72+ }
73+
74 checked: alarmSound.subText === _soundName.text ? true
75 : false
76 onCheckedChanged: {
77
78=== modified file 'app/alarm/EditAlarmPage.qml'
79--- app/alarm/EditAlarmPage.qml 2015-05-27 16:03:23 +0000
80+++ app/alarm/EditAlarmPage.qml 2015-07-24 13:36:33 +0000
81@@ -21,7 +21,6 @@
82 import Ubuntu.Components 1.2
83 import Qt.labs.folderlistmodel 2.1
84 import Ubuntu.Components.Pickers 1.0
85-import Ubuntu.Components.ListItems 1.0 as ListItem
86 import "../components"
87
88 Page {
89
90=== modified file 'debian/changelog'
91--- debian/changelog 2015-07-21 11:40:58 +0000
92+++ debian/changelog 2015-07-24 13:36:33 +0000
93@@ -3,6 +3,7 @@
94 [ Nekhelesh Ramananthan ]
95 * Fixed bottom edge title showing incorrect status on app startup (LP: #1381432)
96 * Migrate to Ubuntu 15.04 SDK Framework and QtQuick 2.4.
97+ * Migrated add-city, settings, main alarm page to the new list items.
98
99 [ Nicholas Skaggs ]
100 * Update testing layout.
101
102=== modified file 'po/com.ubuntu.clock.pot'
103--- po/com.ubuntu.clock.pot 2015-07-24 13:36:33 +0000
104+++ po/com.ubuntu.clock.pot 2015-07-24 13:36:33 +0000
105@@ -46,7 +46,7 @@
106 msgid "Select None"
107 msgstr ""
108
109-#: ../app/alarm/AlarmPage.qml:76 ../app/alarm/AlarmRepeat.qml:38
110+#: ../app/alarm/AlarmPage.qml:76 ../app/alarm/AlarmRepeat.qml:37
111 msgid "Select All"
112 msgstr ""
113
114@@ -58,7 +58,7 @@
115 msgid "Tap the + icon to add an alarm"
116 msgstr ""
117
118-#: ../app/alarm/AlarmRepeat.qml:34 ../app/alarm/EditAlarmPage.qml:281
119+#: ../app/alarm/AlarmRepeat.qml:33 ../app/alarm/EditAlarmPage.qml:281
120 msgid "Repeat"
121 msgstr ""
122
123@@ -100,7 +100,7 @@
124 msgid "Change time and date"
125 msgstr ""
126
127-#: ../app/alarm/AlarmSound.qml:28 ../app/alarm/EditAlarmPage.qml:304
128+#: ../app/alarm/AlarmSound.qml:27 ../app/alarm/EditAlarmPage.qml:304
129 msgid "Sound"
130 msgstr ""
131

Subscribers

People subscribed via source and target branches

to all changes: