Merge lp:ubuntu/vivid-updates/grub2 into lp:ubuntu/vivid/grub2

Proposed by roe shapiro
Status: Rejected
Rejected by: Marc Deslauriers
Proposed branch: lp:ubuntu/vivid-updates/grub2
Merge into: lp:ubuntu/vivid/grub2
Diff against target: 158 lines (+45/-21)
5 files modified
.pc/mkconfig_recovery_title.patch/docs/grub.texi (+9/-4)
debian/changelog (+8/-0)
debian/patches/quick_boot.patch (+18/-12)
docs/grub.texi (+9/-4)
util/grub.d/00_header.in (+1/-1)
To merge this branch: bzr merge lp:ubuntu/vivid-updates/grub2
Reviewer Review Type Date Requested Status
Marc Deslauriers Disapprove
Review via email: mp+270090@code.launchpad.net

Commit message

help: see above

Description of the change

all. nothing works. cant install any updates. doesnt recognize my computer administrator password

To post a comment you must log in.
Revision history for this message
Marc Deslauriers (mdeslaur) :
review: Disapprove

Unmerged revisions

127. By Michael Vogt

[ Mathieu Trudel-Lapierre ]
debian/build-efi-images: look for grub.cfg in $cmdpath too in gcdx64.efi,
to simplify embedded scenarios: putting a grub.cfg snippet that loads the
right "real" grub.cfg can be useful. (LP: #1468111)

126. By Robie Basak

Do not hang headless servers indefinitely on boot after edge case power
failure timing (LP: #1443735). Instead, time out after 30 seconds and boot
anyway, including on non-headless systems.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.pc/mkconfig_recovery_title.patch/docs/grub.texi'
2--- .pc/mkconfig_recovery_title.patch/docs/grub.texi 2014-03-10 13:39:33 +0000
3+++ .pc/mkconfig_recovery_title.patch/docs/grub.texi 2015-09-03 17:14:42 +0000
4@@ -1491,10 +1491,15 @@
5 @file{grub.cfg}.
6
7 @item GRUB_RECORDFAIL_TIMEOUT
8-If this option is set, it overrides the default recordfail setting. The
9-default setting is -1, which causes GRUB to wait for user input. This option
10-should be set on headless and appliance systems where access to a console is
11-restricted or limited.
12+If this option is set, it overrides the default recordfail setting. A
13+setting of -1 causes GRUB to wait for user input indefinitely. However, a
14+false positive in the recordfail mechanism may occur if power is lost during
15+boot before boot success is recorded in userspace. The default setting is
16+30, which causes GRUB to wait for user input for thirty seconds before
17+continuing. This default allows interactive users the opportunity to switch
18+to a different, working kernel, while avoiding a false positive causing the
19+boot to block indefinitely on headless and appliance systems where access to
20+a console is restricted or limited.
21
22 This option is only effective when GRUB was configured with the
23 @option{--enable-quick-boot} option.
24
25=== modified file 'debian/changelog'
26--- debian/changelog 2015-04-06 15:15:24 +0000
27+++ debian/changelog 2015-09-03 17:14:42 +0000
28@@ -1,3 +1,11 @@
29+grub2 (2.02~beta2-22ubuntu1.1) vivid; urgency=medium
30+
31+ * Do not hang headless servers indefinitely on boot after edge case power
32+ failure timing (LP: #1443735). Instead, time out after 30 seconds and boot
33+ anyway, including on non-headless systems.
34+
35+ -- Robie Basak <robie.basak@ubuntu.com> Tue, 19 May 2015 13:47:00 +0100
36+
37 grub2 (2.02~beta2-22ubuntu1) vivid; urgency=medium
38
39 * debian/patches/arp_icmp_oversize_handling.patch: better handle oversized
40
41=== modified file 'debian/patches/quick_boot.patch'
42--- debian/patches/quick_boot.patch 2014-11-30 17:15:21 +0000
43+++ debian/patches/quick_boot.patch 2015-09-03 17:14:42 +0000
44@@ -1,4 +1,4 @@
45-From 211894b6333be68c2ddaa2f3a8d9b0df7b13b60c Mon Sep 17 00:00:00 2001
46+From a6c14d009f574b026c8aebb977cd1e808827961b Mon Sep 17 00:00:00 2001
47 From: Colin Watson <cjwatson@ubuntu.com>
48 Date: Mon, 13 Jan 2014 12:13:28 +0000
49 Subject: Add configure option to bypass boot menu if possible
50@@ -17,19 +17,20 @@
51 of the normal runlevels), then show the boot menu regardless.
52
53 Author: Richard Laager <rlaager@wiktel.com>
54+Author: Robie Basak <robie.basak@ubuntu.com>
55 Forwarded: no
56-Last-Update: 2014-01-17
57+Last-Update: 2015-05-14
58
59 Patch-Name: quick_boot.patch
60 ---
61 configure.ac | 11 +++++++++
62- docs/grub.texi | 9 +++++++
63+ docs/grub.texi | 14 +++++++++++
64 grub-core/normal/menu.c | 24 +++++++++++++++++++
65 util/grub-mkconfig.in | 3 ++-
66 util/grub.d/00_header.in | 58 +++++++++++++++++++++++++++++++++++----------
67 util/grub.d/10_linux.in | 4 ++++
68 util/grub.d/30_os-prober.in | 21 ++++++++++++++++
69- 7 files changed, 117 insertions(+), 13 deletions(-)
70+ 7 files changed, 122 insertions(+), 13 deletions(-)
71
72 diff --git a/configure.ac b/configure.ac
73 index 7c8d0af..2a7e410 100644
74@@ -54,18 +55,23 @@
75
76 AC_SUBST([FONT_SOURCE])
77 diff --git a/docs/grub.texi b/docs/grub.texi
78-index 46b9e7f..28743d5 100644
79+index 46b9e7f..a79256b 100644
80 --- a/docs/grub.texi
81 +++ b/docs/grub.texi
82-@@ -1490,6 +1490,15 @@ This option may be set to a list of GRUB module names separated by spaces.
83+@@ -1490,6 +1490,20 @@ This option may be set to a list of GRUB module names separated by spaces.
84 Each module will be loaded as early as possible, at the start of
85 @file{grub.cfg}.
86
87 +@item GRUB_RECORDFAIL_TIMEOUT
88-+If this option is set, it overrides the default recordfail setting. The
89-+default setting is -1, which causes GRUB to wait for user input. This option
90-+should be set on headless and appliance systems where access to a console is
91-+restricted or limited.
92++If this option is set, it overrides the default recordfail setting. A
93++setting of -1 causes GRUB to wait for user input indefinitely. However, a
94++false positive in the recordfail mechanism may occur if power is lost during
95++boot before boot success is recorded in userspace. The default setting is
96++30, which causes GRUB to wait for user input for thirty seconds before
97++continuing. This default allows interactive users the opportunity to switch
98++to a different, working kernel, while avoiding a false positive causing the
99++boot to block indefinitely on headless and appliance systems where access to
100++a console is restricted or limited.
101 +
102 +This option is only effective when GRUB was configured with the
103 +@option{--enable-quick-boot} option.
104@@ -123,7 +129,7 @@
105 if test "x${grub_cfg}" != "x"; then
106 rm -f "${grub_cfg}.new"
107 diff --git a/util/grub.d/00_header.in b/util/grub.d/00_header.in
108-index 0c82f23..8dc5592 100644
109+index 0c82f23..2e6b5a4 100644
110 --- a/util/grub.d/00_header.in
111 +++ b/util/grub.d/00_header.in
112 @@ -21,6 +21,8 @@ prefix="@prefix@"
113@@ -181,7 +187,7 @@
114 {
115 + cat << EOF
116 +if [ "\${recordfail}" = 1 ] ; then
117-+ set timeout=${GRUB_RECORDFAIL_TIMEOUT:--1}
118++ set timeout=${GRUB_RECORDFAIL_TIMEOUT:-30}
119 +else
120 +EOF
121 if [ "x${3}" != "x" ] ; then
122
123=== modified file 'docs/grub.texi'
124--- docs/grub.texi 2014-03-10 13:39:33 +0000
125+++ docs/grub.texi 2015-09-03 17:14:42 +0000
126@@ -1491,10 +1491,15 @@
127 @file{grub.cfg}.
128
129 @item GRUB_RECORDFAIL_TIMEOUT
130-If this option is set, it overrides the default recordfail setting. The
131-default setting is -1, which causes GRUB to wait for user input. This option
132-should be set on headless and appliance systems where access to a console is
133-restricted or limited.
134+If this option is set, it overrides the default recordfail setting. A
135+setting of -1 causes GRUB to wait for user input indefinitely. However, a
136+false positive in the recordfail mechanism may occur if power is lost during
137+boot before boot success is recorded in userspace. The default setting is
138+30, which causes GRUB to wait for user input for thirty seconds before
139+continuing. This default allows interactive users the opportunity to switch
140+to a different, working kernel, while avoiding a false positive causing the
141+boot to block indefinitely on headless and appliance systems where access to
142+a console is restricted or limited.
143
144 This option is only effective when GRUB was configured with the
145 @option{--enable-quick-boot} option.
146
147=== modified file 'util/grub.d/00_header.in'
148--- util/grub.d/00_header.in 2014-03-10 13:39:33 +0000
149+++ util/grub.d/00_header.in 2015-09-03 17:14:42 +0000
150@@ -311,7 +311,7 @@
151 {
152 cat << EOF
153 if [ "\${recordfail}" = 1 ] ; then
154- set timeout=${GRUB_RECORDFAIL_TIMEOUT:--1}
155+ set timeout=${GRUB_RECORDFAIL_TIMEOUT:-30}
156 else
157 EOF
158 if [ "x${3}" != "x" ] ; then

Subscribers

People subscribed via source and target branches

to all changes: