Merge lp:~ubuntu-branches/ubuntu/trusty/folks/trusty-201402211552 into lp:ubuntu/trusty/folks

Proposed by Ubuntu Package Importer
Status: Needs review
Proposed branch: lp:~ubuntu-branches/ubuntu/trusty/folks/trusty-201402211552
Merge into: lp:ubuntu/trusty/folks
Diff against target: 83 lines (+71/-0) (has conflicts)
2 files modified
debian/patches/bz724058.patch (+26/-0)
debian/patches/bz724809.patch (+45/-0)
Conflict adding file debian/patches/bz724058.patch.  Moved existing file to debian/patches/bz724058.patch.moved.
Conflict adding file debian/patches/bz724809.patch.  Moved existing file to debian/patches/bz724809.patch.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/trusty/folks/trusty-201402211552
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+207687@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/trusty/folks reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/trusty/folks/trusty-201402211552. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

55. By Ken VanDine

releasing package folks version 0.9.5-1ubuntu3

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/patches/bz724058.patch'
2--- debian/patches/bz724058.patch 1970-01-01 00:00:00 +0000
3+++ debian/patches/bz724058.patch 2014-02-21 15:59:23 +0000
4@@ -0,0 +1,26 @@
5+From 3f3c9658dd50ec3a1e66713c0c3b9635db5bbfbd Mon Sep 17 00:00:00 2001
6+From: Renato Araujo Oliveira Filho <renato.filho@canonical.com>
7+Date: Tue, 11 Feb 2014 20:12:17 -0300
8+Subject: [PATCH] check for '*' in anti link list.
9+
10+If '*' exists this mean that the persona should not be linked.
11+---
12+ folks/anti-linkable.vala | 3 ++-
13+ 1 file changed, 2 insertions(+), 1 deletion(-)
14+
15+diff --git a/folks/anti-linkable.vala b/folks/anti-linkable.vala
16+index 93a82c7..5d45e3c 100644
17+--- a/folks/anti-linkable.vala
18++++ b/folks/anti-linkable.vala
19+@@ -93,7 +93,8 @@ public interface Folks.AntiLinkable : Folks.Persona
20+ */
21+ public bool has_anti_link_with_persona (Persona other_persona)
22+ {
23+- return (other_persona.uid in this.anti_links);
24++ return (("*" in this.anti_links) ||
25++ other_persona.uid in this.anti_links);
26+ }
27+
28+ /**
29+--
30+1.9.0
31
32=== renamed file 'debian/patches/bz724058.patch' => 'debian/patches/bz724058.patch.moved'
33=== added file 'debian/patches/bz724809.patch'
34--- debian/patches/bz724809.patch 1970-01-01 00:00:00 +0000
35+++ debian/patches/bz724809.patch 2014-02-21 15:59:23 +0000
36@@ -0,0 +1,45 @@
37+From 87e037787476ba645ced4b8d6a406b32f7dbfae0 Mon Sep 17 00:00:00 2001
38+From: Renato Araujo Oliveira Filho <renato.filho@canonical.com>
39+Date: Thu, 20 Feb 2014 21:21:27 +0000
40+Subject: Replaced use of EVCard.remove_attribute to EVCard.remove_attributes.
41+
42+https://bugzilla.gnome.org/show_bug.cgi?id=724809
43+---
44+diff --git a/backends/eds/lib/edsf-persona-store.vala b/backends/eds/lib/edsf-persona-store.vala
45+index c27565b..ce4f00d 100644
46+--- a/backends/eds/lib/edsf-persona-store.vala
47++++ b/backends/eds/lib/edsf-persona-store.vala
48+@@ -1325,11 +1325,7 @@ public class Edsf.PersonaStore : Folks.PersonaStore
49+
50+ private void _remove_attribute (E.Contact contact, string attr_name)
51+ {
52+- unowned VCardAttribute? attr = contact.get_attribute (attr_name);
53+- if (attr != null)
54+- {
55+- contact.remove_attribute ((!) attr);
56+- }
57++ contact.remove_attributes (null, attr_name);
58+ }
59+
60+ internal async void _set_avatar (Edsf.Persona persona, LoadableIcon? avatar)
61+@@ -2064,14 +2060,14 @@ public class Edsf.PersonaStore : Folks.PersonaStore
62+
63+ private void _set_contact_system_groups (E.Contact contact, Set<string> system_groups)
64+ {
65++ var group_ids_str = "X-GOOGLE-SYSTEM-GROUP-IDS";
66+ var vcard = (E.VCard) contact;
67+- unowned E.VCardAttribute? prev_attr =
68+- vcard.get_attribute ("X-GOOGLE-SYSTEM-GROUP-IDS");
69++ unowned E.VCardAttribute? prev_attr = vcard.get_attribute (group_ids_str);
70+
71+ if (prev_attr != null)
72+- contact.remove_attribute (prev_attr);
73++ contact.remove_attributes (null, group_ids_str);
74+
75+- E.VCardAttribute new_attr = new E.VCardAttribute ("", "X-GOOGLE-SYSTEM-GROUP-IDS");
76++ E.VCardAttribute new_attr = new E.VCardAttribute ("", group_ids_str);
77+ foreach (var group in system_groups)
78+ {
79+ if (group == null || group == "")
80+--
81+cgit v0.9.2
82
83=== renamed file 'debian/patches/bz724809.patch' => 'debian/patches/bz724809.patch.moved'

Subscribers

People subscribed via source and target branches

to all changes: