Merge lp:~ubuntu-branches/ubuntu/raring/libimobiledevice/raring-201301191442 into lp:ubuntu/raring/libimobiledevice

Proposed by Ubuntu Package Importer
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/raring/libimobiledevice/raring-201301191442
Merge into: lp:ubuntu/raring/libimobiledevice
Diff against target: 124 lines (+78/-1) (has conflicts)
5 files modified
debian/changelog (+18/-0)
debian/patches/fix-ma-includes (+20/-0)
debian/patches/git_utf8_devices_names.patch (+23/-0)
debian/patches/series (+6/-1)
m4/ac_python_devel.m4 (+11/-0)
Text conflict in debian/changelog
Conflict adding file debian/patches/git_utf8_devices_names.patch.  Moved existing file to debian/patches/git_utf8_devices_names.patch.moved.
Text conflict in debian/patches/series
Text conflict in m4/ac_python_devel.m4
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/raring/libimobiledevice/raring-201301191442
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+143990@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/raring/libimobiledevice reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/raring/libimobiledevice/raring-201301191442. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

22. By Iain Lane

Look in python MA path. Import q-updates version to r.

* debian/patches/fix-ma-includes: Look in MA path for python includes.
* FIXME: Still FTBFS due to cython changes
  (http://libiphone.lighthouseapp.com/projects/27916/tickets/285-cant-compile-cython-bindings)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2013-01-19 06:11:28 +0000
3+++ debian/changelog 2013-01-19 14:51:20 +0000
4@@ -1,3 +1,4 @@
5+<<<<<<< TREE
6 libimobiledevice (1.1.4-1ubuntu5) raring; urgency=low
7
8 * 08_cython_0.16_fix.patch: Follow-up cython fix from Michael Bienia:
9@@ -21,6 +22,23 @@
10
11 -- Sebastien Bacher <seb128@ubuntu.com> Wed, 24 Oct 2012 12:01:08 +0200
12
13+=======
14+libimobiledevice (1.1.4-1ubuntu3) UNRELEASED; urgency=low
15+
16+ * debian/patches/fix-ma-includes: Look in MA path for python includes.
17+ * FIXME: Still FTBFS due to cython changes
18+ (http://libiphone.lighthouseapp.com/projects/27916/tickets/285-cant-compile-cython-bindings)
19+
20+ -- Iain Lane <iain.lane@canonical.com> Tue, 18 Dec 2012 16:23:01 +0000
21+
22+libimobiledevice (1.1.4-1ubuntu3) quantal-proposed; urgency=low
23+
24+ * git_utf8_devices_names.patch:
25+ - fix incorrect naming of e.g iphone devices (lp: #1049991)
26+
27+ -- Sebastien Bacher <seb128@ubuntu.com> Wed, 24 Oct 2012 12:01:08 +0200
28+
29+>>>>>>> MERGE-SOURCE
30 libimobiledevice (1.1.4-1ubuntu2) quantal; urgency=low
31
32 * debian/patches/git_handle_unset_environment.patch:
33
34=== added file 'debian/patches/fix-ma-includes'
35--- debian/patches/fix-ma-includes 1970-01-01 00:00:00 +0000
36+++ debian/patches/fix-ma-includes 2013-01-19 14:51:20 +0000
37@@ -0,0 +1,20 @@
38+Description: python puts some stuff into multiarch paths; look there
39+Forwarded: no
40+Author: Iain Lane <iain.lane@canonical.com>
41+
42+Index: b/m4/ac_python_devel.m4
43+===================================================================
44+--- a/m4/ac_python_devel.m4
45++++ b/m4/ac_python_devel.m4
46+@@ -154,8 +154,10 @@
47+ if test -z "$PYTHON_CPPFLAGS"; then
48+ python_path=`$PYTHON -c "import distutils.sysconfig; \
49+ print distutils.sysconfig.get_python_inc();"`
50++ python_platpath=`$PYTHON -c "import distutils.sysconfig; \
51++ print distutils.sysconfig.get_python_inc(plat_specific=True);"`
52+ if test -n "${python_path}"; then
53+- python_path="-I$python_path"
54++ python_path="-I$python_path -I$python_platpath"
55+ fi
56+ PYTHON_CPPFLAGS=$python_path
57+ fi
58
59=== added file 'debian/patches/git_utf8_devices_names.patch'
60--- debian/patches/git_utf8_devices_names.patch 1970-01-01 00:00:00 +0000
61+++ debian/patches/git_utf8_devices_names.patch 2013-01-19 14:51:20 +0000
62@@ -0,0 +1,23 @@
63+From 060e3f2683ed2b0b08e1a31deb9608a99e193b4a Mon Sep 17 00:00:00 2001
64+From: Christophe Fergeau
65+Date: Mon, 25 Jun 2012 22:03:30 +0000
66+Subject: property_list_service: do not strip non-ASCII characters from XML plists
67+
68+'content' is declared as char content[] so if char is signed, all characters with the high bit set will be negative so they will be < 0x20. This means the code will strip all non-ASCII (multi-byte) UTF-8 characters and replace them with spaces. This commit fixes it now by really only considering ASCII characters.
69+---
70+diff --git a/src/property_list_service.c b/src/property_list_service.c
71+index 8634864..c9a8edf 100644
72+--- a/src/property_list_service.c
73++++ b/src/property_list_service.c
74+@@ -250,7 +250,7 @@ static property_list_service_error_t internal_plist_receive_timeout(property_lis
75+ } else {
76+ /* iOS 4.3+ hack: plist data might contain invalid characters, thus we convert those to spaces */
77+ for (bytes = 0; bytes < pktlen-1; bytes++) {
78+- if ((content[bytes] < 0x20) && (content[bytes] != 0x09) && (content[bytes] != 0x0a) && (content[bytes] != 0x0d))
79++ if ((content[bytes] >= 0) && (content[bytes] < 0x20) && (content[bytes] != 0x09) && (content[bytes] != 0x0a) && (content[bytes] != 0x0d))
80+ content[bytes] = 0x20;
81+ }
82+ plist_from_xml(content, pktlen, plist);
83+--
84+cgit v0.9.0.2
85+
86
87=== renamed file 'debian/patches/git_utf8_devices_names.patch' => 'debian/patches/git_utf8_devices_names.patch.moved'
88=== modified file 'debian/patches/series'
89--- debian/patches/series 2013-01-19 06:11:28 +0000
90+++ debian/patches/series 2013-01-19 14:51:20 +0000
91@@ -5,4 +5,9 @@
92 08_cython_0.16_fix.patch
93 09_use_python_config.patch
94 git_handle_unset_environment.patch
95-git_utf8_devices_names.patch
96+<<<<<<< TREE
97+git_utf8_devices_names.patch
98+=======
99+git_utf8_devices_names.patch
100+fix-ma-includes
101+>>>>>>> MERGE-SOURCE
102
103=== modified file 'm4/ac_python_devel.m4'
104--- m4/ac_python_devel.m4 2013-01-19 06:11:28 +0000
105+++ m4/ac_python_devel.m4 2013-01-19 14:51:20 +0000
106@@ -152,7 +152,18 @@
107 #
108 AC_MSG_CHECKING([for Python include path])
109 if test -z "$PYTHON_CPPFLAGS"; then
110+<<<<<<< TREE
111 PYTHON_CPPFLAGS=`$PYTHON-config --includes`
112+=======
113+ python_path=`$PYTHON -c "import distutils.sysconfig; \
114+ print distutils.sysconfig.get_python_inc();"`
115+ python_platpath=`$PYTHON -c "import distutils.sysconfig; \
116+ print distutils.sysconfig.get_python_inc(plat_specific=True);"`
117+ if test -n "${python_path}"; then
118+ python_path="-I$python_path -I$python_platpath"
119+ fi
120+ PYTHON_CPPFLAGS=$python_path
121+>>>>>>> MERGE-SOURCE
122 fi
123 AC_MSG_RESULT([$PYTHON_CPPFLAGS])
124 AC_SUBST([PYTHON_CPPFLAGS])

Subscribers

People subscribed via source and target branches

to all changes: