Merge lp:~ubuntu-branches/ubuntu/quantal/wpa/quantal-201207091727 into lp:ubuntu/quantal/wpa

Proposed by Ubuntu Package Importer
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/quantal/wpa/quantal-201207091727
Merge into: lp:ubuntu/quantal/wpa
Diff against target: 72 lines (+66/-0) (has conflicts)
1 file modified
debian/patches/fix_driver_wext_for_broadcom_wl.patch (+66/-0)
Conflict adding file debian/patches/fix_driver_wext_for_broadcom_wl.patch.  Moved existing file to debian/patches/fix_driver_wext_for_broadcom_wl.patch.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/quantal/wpa/quantal-201207091727
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+114015@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/quantal/wpa reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/quantal/wpa/quantal-201207091727. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

4. By Mathieu Trudel-Lapierre

debian/patches/fix_driver_wext_for_broadcom_wl.patch: Add a workaround for
Broadcom wl driver's first failing scan (LP: #994739)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/patches/fix_driver_wext_for_broadcom_wl.patch'
2--- debian/patches/fix_driver_wext_for_broadcom_wl.patch 1970-01-01 00:00:00 +0000
3+++ debian/patches/fix_driver_wext_for_broadcom_wl.patch 2012-07-09 17:33:09 +0000
4@@ -0,0 +1,66 @@
5+From: Pau Oliva <pau@eslack.org>
6+Bug-Ubuntu: https://bugs.launchpad.net/bugs/994739
7+Origin: other, http://lists.shmoo.com/pipermail/hostap/2011-March/022891.html
8+Subject: fix driver_wext for broadcom wl driver
9+
10+With broadcom's "wl" driver the first scan after ifup always fails with
11+EINVAL. This produces a 30 seconds timeout when establishing a connection
12+either on boot, or after resuming from suspend.
13+This is a workaround to wext driver which will rerun the scan if first
14+scan fails EINVAL.
15+
16+Index: wpa/src/drivers/driver_wext.c
17+===================================================================
18+--- wpa.orig/src/drivers/driver_wext.c 2012-07-09 16:41:16.328347000 +0200
19++++ wpa/src/drivers/driver_wext.c 2012-07-09 16:42:18.149589666 +0200
20+@@ -855,6 +855,8 @@
21+
22+ drv->mlme_sock = -1;
23+
24++ drv->scans = 0;
25++
26+ if (wpa_driver_wext_finish_drv_init(drv) < 0)
27+ goto err3;
28+
29+@@ -1064,10 +1066,13 @@
30+ static u8 * wpa_driver_wext_giwscan(struct wpa_driver_wext_data *drv,
31+ size_t *len)
32+ {
33++ struct wpa_driver_scan_params params;
34+ struct iwreq iwr;
35+ u8 *res_buf;
36+ size_t res_buf_len;
37+
38++ drv->scans++;
39++
40+ res_buf_len = IW_SCAN_MAX_DATA;
41+ for (;;) {
42+ res_buf = os_malloc(res_buf_len);
43+@@ -1090,6 +1095,15 @@
44+ wpa_printf(MSG_DEBUG, "Scan results did not fit - "
45+ "trying larger buffer (%lu bytes)",
46+ (unsigned long) res_buf_len);
47++ } if (errno == EINVAL && drv->scans == 1) {
48++ /*
49++ * Broadcom's wl driver is buggy and the first scan
50++ * after ifup always fail with EINVAL. Rerun the
51++ * scan to get scan results.
52++ */
53++ os_memset(&params, 0, sizeof(params));
54++ wpa_driver_wext_scan(drv, &params);
55++ return NULL;
56+ } else {
57+ perror("ioctl[SIOCGIWSCAN]");
58+ os_free(res_buf);
59+Index: wpa/src/drivers/driver_wext.h
60+===================================================================
61+--- wpa.orig/src/drivers/driver_wext.h 2012-07-09 16:41:16.328347000 +0200
62++++ wpa/src/drivers/driver_wext.h 2012-07-09 16:42:18.149589666 +0200
63+@@ -45,6 +45,7 @@
64+
65+ char mlmedev[IFNAMSIZ + 1];
66+
67++ int scans;
68+ int scan_complete_events;
69+
70+ int cfg80211; /* whether driver is using cfg80211 */
71
72=== renamed file 'debian/patches/fix_driver_wext_for_broadcom_wl.patch' => 'debian/patches/fix_driver_wext_for_broadcom_wl.patch.moved'

Subscribers

People subscribed via source and target branches

to all changes: