Merge lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sina/precise-201203201005 into lp:ubuntu/precise/gwibber-service-sina

Proposed by Ubuntu Package Importer
Status: Needs review
Proposed branch: lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sina/precise-201203201005
Merge into: lp:ubuntu/precise/gwibber-service-sina
Diff against target: 106 lines (+73/-0) (has conflicts)
4 files modified
debian/changelog (+19/-0)
debian/patches/logger.patch (+52/-0)
debian/patches/series (+1/-0)
debian/source/format (+1/-0)
Text conflict in debian/changelog
Conflict adding file debian/patches.  Moved existing file to debian/patches.moved.
Conflict adding file debian/source.  Moved existing file to debian/source.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sina/precise-201203201005
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+98380@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/precise/gwibber-service-sina reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/precise/gwibber-service-sina/precise-201203201005. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

6. By Ken VanDine

releasing version 0.9.1-0ubuntu5

5. By Ken VanDine

releasing version 0.9.1-0ubuntu4

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2012-03-19 15:21:22 +0000
3+++ debian/changelog 2012-03-20 10:09:18 +0000
4@@ -1,3 +1,4 @@
5+<<<<<<< TREE
6 gwibber-service-sina (0.9.1-0ubuntu6) precise; urgency=low
7
8 * debian/patches/gtk3.patch
9@@ -21,6 +22,24 @@
10
11 -- Ken VanDine <ken.vandine@canonical.com> Mon, 19 Mar 2012 13:49:05 -0400
12
13+=======
14+gwibber-service-sina (0.9.1-0ubuntu5) precise; urgency=low
15+
16+ * debian/patches/logger.patch
17+ - Fixed all ocurrances of log.logger
18+
19+ -- Ken VanDine <ken.vandine@canonical.com> Mon, 19 Mar 2012 14:05:28 -0400
20+
21+gwibber-service-sina (0.9.1-0ubuntu4) precise; urgency=low
22+
23+ * debian/patches/logger.patch
24+ - Updated to use the new logger in gwibber-service (LP: #947559)
25+ * debian/control
26+ - require gwibber-service >= 3.3.92 for the logger changes
27+
28+ -- Ken VanDine <ken.vandine@canonical.com> Mon, 19 Mar 2012 13:49:05 -0400
29+
30+>>>>>>> MERGE-SOURCE
31 gwibber-service-sina (0.9.1-0ubuntu3) precise; urgency=low
32
33 * Rebuild to drop dependencies on python2.6.
34
35=== added directory 'debian/patches'
36=== renamed directory 'debian/patches' => 'debian/patches.moved'
37=== added file 'debian/patches/logger.patch'
38--- debian/patches/logger.patch 1970-01-01 00:00:00 +0000
39+++ debian/patches/logger.patch 2012-03-20 10:09:18 +0000
40@@ -0,0 +1,52 @@
41+=== modified file '__init__.py'
42+--- old/__init__.py 2011-06-10 09:11:33 +0000
43++++ new/__init__.py 2012-03-19 18:05:16 +0000
44+@@ -3,10 +3,13 @@
45+ import re
46+ import gnomekeyring
47+ from oauth import oauth
48+-from gwibber.microblog.util import log, resources
49++from gwibber.microblog.util import resources
50+ from gettext import lgettext as _
51+ import sina.utils
52+-log.logger.name = "Sina"
53++
54++import logging
55++logger = logging.getLogger("Sina")
56++logger.debug("Initializing.")
57+
58+ PROTOCOL_INFO = {
59+ "name": "Sina",
60+@@ -107,7 +110,7 @@
61+ m["images"] = images
62+ m["type"] = "photo"
63+ except:
64+- log.logger.error("%s failure - %s", PROTOCOL_INFO["name"], data)
65++ logger.error("%s failure - %s", PROTOCOL_INFO["name"], data)
66+ return {}
67+
68+ return m
69+@@ -219,7 +222,7 @@
70+ if isinstance(data, dict) and data.get("errors", 0):
71+ if "authenticate" in data["errors"][0]["message"]:
72+ logstr = """%s: %s - %s""" % (PROTOCOL_INFO["name"], _("Authentication failed"), error["message"])
73+- log.logger.error("%s", logstr)
74++ logger.error("%s", logstr)
75+ return [{"error": {"type": "auth", "account": self.account, "message": data["errors"][0]["message"]}}]
76+ else:
77+ for error in data["errors"]:
78+@@ -228,11 +231,11 @@
79+ elif isinstance(data, dict) and data.get("error", 0):
80+ if "Incorrect signature" in data["error"]:
81+ logstr = """%s: %s - %s""" % (PROTOCOL_INFO["name"], _("Request failed"), data["error"])
82+- log.logger.error("%s", logstr)
83++ logger.error("%s", logstr)
84+ return [{"error": {"type": "auth", "account": self.account, "message": data["error"]}}]
85+ elif isinstance(data, str):
86+ logstr = """%s: %s - %s""" % (PROTOCOL_INFO["name"], _("Request failed"), data)
87+- log.logger.error("%s", logstr)
88++ logger.error("%s", logstr)
89+ return [{"error": {"type": "request", "account": self.account, "message": data}}]
90+
91+ if parse == "list":
92+
93
94=== added file 'debian/patches/series'
95--- debian/patches/series 1970-01-01 00:00:00 +0000
96+++ debian/patches/series 2012-03-20 10:09:18 +0000
97@@ -0,0 +1,1 @@
98+logger.patch
99
100=== added directory 'debian/source'
101=== renamed directory 'debian/source' => 'debian/source.moved'
102=== added file 'debian/source/format'
103--- debian/source/format 1970-01-01 00:00:00 +0000
104+++ debian/source/format 2012-03-20 10:09:18 +0000
105@@ -0,0 +1,1 @@
106+3.0 (quilt)

Subscribers

People subscribed via source and target branches

to all changes: