Merge lp:~ubuntu-branches/ubuntu/precise/bash/precise-201112011313 into lp:ubuntu/precise/bash

Proposed by Ubuntu Package Importer
Status: Needs review
Proposed branch: lp:~ubuntu-branches/ubuntu/precise/bash/precise-201112011313
Merge into: lp:ubuntu/precise/bash
Diff against target: 221 lines (+145/-0) (has conflicts)
4 files modified
debian/changelog (+14/-0)
debian/control (+8/-0)
debian/patches/harden-formatstring.dpatch (+35/-0)
debian/rules (+88/-0)
Text conflict in debian/changelog
Text conflict in debian/control
Text conflict in debian/rules
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/precise/bash/precise-201112011313
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+84102@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/precise/bash reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/precise/bash/precise-201112011313. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

56. By Steve Langasek

debian/patches/harden-formatstring.patch: Fix build error with
-Werror=format-security hardening flag; thanks to Pierre Chifflier
<email address hidden>. Closes: #641350.

55. By Steve Langasek

Build-depend on gettext:any instead of on gettext, so that apt-get can
properly resolve build-dependencies on the tool when cross-building.

54. By Steve Langasek

Add cross-compilation support. Closes: #629929.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2011-11-30 11:30:24 +0000
3+++ debian/changelog 2011-12-01 13:22:27 +0000
4@@ -1,3 +1,4 @@
5+<<<<<<< TREE
6 bash (4.2-1ubuntu1) precise; urgency=low
7
8 * Merge with Debian; remaining changes:
9@@ -74,6 +75,19 @@
10
11 -- Matthias Klose <doko@debian.org> Wed, 30 Nov 2011 07:29:05 +0100
12
13+=======
14+bash (4.2-0ubuntu5) UNRELEASED; urgency=low
15+
16+ * Add cross-compilation support. Closes: #629929.
17+ * Build-depend on gettext:any instead of on gettext, so that apt-get can
18+ properly resolve build-dependencies on the tool when cross-building.
19+ * debian/patches/harden-formatstring.patch: Fix build error with
20+ -Werror=format-security hardening flag; thanks to Pierre Chifflier
21+ <pollux@debian.org>. Closes: #641350.
22+
23+ -- Steve Langasek <steve.langasek@ubuntu.com> Sun, 06 Nov 2011 04:13:49 +0000
24+
25+>>>>>>> MERGE-SOURCE
26 bash (4.2-0ubuntu4) oneiric; urgency=low
27
28 * Apply upstream patches:
29
30=== modified file 'debian/control'
31--- debian/control 2011-11-30 11:30:24 +0000
32+++ debian/control 2011-12-01 13:22:27 +0000
33@@ -1,11 +1,19 @@
34 Source: bash
35 Section: base
36 Priority: required
37+<<<<<<< TREE
38 Maintainer: Matthias Klose <doko@debian.org>
39 Standards-Version: 3.9.2
40 Build-Depends: autoconf, autotools-dev, quilt, bison, libncurses5-dev,
41 texinfo, debhelper (>= 5), texi2html, locales, gettext, sharutils, time,
42 xz-utils, dpkg-dev (>= 1.16.1)
43+=======
44+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
45+XSBC-Original-Maintainer: Matthias Klose <doko@debian.org>
46+Standards-Version: 3.8.3
47+Build-Depends: autoconf, autotools-dev, patch, bison, libncurses5-dev,
48+ texinfo, debhelper (>= 5), texi2html, locales, gettext:any, sharutils, time, xz-utils, dpkg-dev (>= 1.16.1)
49+>>>>>>> MERGE-SOURCE
50 Build-Depends-Indep: texlive-latex-base, ghostscript
51 Homepage: http://tiswww.case.edu/php/chet/bash/bashtop.html
52 Vcs-Browser: https://code.launchpad.net/~doko/+junk/pkg-bash-debian
53
54=== added file 'debian/patches/harden-formatstring.dpatch'
55--- debian/patches/harden-formatstring.dpatch 1970-01-01 00:00:00 +0000
56+++ debian/patches/harden-formatstring.dpatch 2011-12-01 13:22:27 +0000
57@@ -0,0 +1,35 @@
58+#! /bin/sh -e
59+
60+if [ $# -eq 3 -a "$2" = '-d' ]; then
61+ pdir="-d $3"
62+elif [ $# -ne 1 ]; then
63+ echo >&2 "`basename $0`: script expects -patch|-unpatch as argument"
64+ exit 1
65+fi
66+case "$1" in
67+ -patch) patch $pdir -f --no-backup-if-mismatch -p1 < $0;;
68+ -unpatch) patch $pdir -f --no-backup-if-mismatch -R -p1 < $0;;
69+ *)
70+ echo >&2 "`basename $0`: script expects -patch|-unpatch as argument"
71+ exit 1
72+esac
73+exit 0
74+
75+# DP: <your description>
76+
77+Author: Pierre Chifflier
78+Description: Fix build error with -Werror=format-security hardening flag.
79+Bug-Debian: http://bugs.debian.org/641350
80+
81+diff -ruN bash-4.1.orig/print_cmd.c bash-4.1/print_cmd.c
82+--- bash-4.1.orig/print_cmd.c 2009-09-16 21:32:26.000000000 +0200
83++++ bash-4.1/print_cmd.c 2011-09-16 11:38:40.000000000 +0200
84+@@ -1374,7 +1374,7 @@
85+ for (i = 0; amount > 0; amount--)
86+ indentation_string[i++] = ' ';
87+ indentation_string[i] = '\0';
88+- cprintf (indentation_string);
89++ cprintf ("%s", indentation_string);
90+ }
91+
92+ static void
93
94=== modified file 'debian/rules'
95--- debian/rules 2011-11-30 11:30:24 +0000
96+++ debian/rules 2011-12-01 13:22:27 +0000
97@@ -24,6 +24,7 @@
98
99 with_gfdl = yes
100
101+<<<<<<< TREE
102 ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
103 CC = $(DEB_HOST_GNU_TYPE)-gcc
104 else
105@@ -34,6 +35,17 @@
106 CPPFLAGS := $(shell $(dpkg_buildflags) --get CPPFLAGS)
107 LDFLAGS := $(shell $(dpkg_buildflags) --get LDFLAGS)
108
109+=======
110+ifneq ($(DEB_HOST_GNU_TYPE),$(DEB_BUILD_GNU_TYPE))
111+CC = $(DEB_HOST_GNU_TYPE)-gcc
112+else
113+CC = gcc
114+endif
115+export DEB_CFLAGS_MAINT_APPEND = -Wall
116+CFLAGS = $(shell dpkg-buildflags --get CFLAGS)
117+LDFLAGS = $(shell dpkg-buildflags --get LDFLAGS)
118+
119+>>>>>>> MERGE-SOURCE
120 SHELL = /bin/bash
121 YACC = bison -y
122
123@@ -88,8 +100,12 @@
124 (test -d /dev/fd && test -r /dev/stdin < /dev/null) \
125 || (test -d /proc/self/fd && test -r /dev/stdin < /dev/null)
126 ifneq (,$(findstring $(DEB_HOST_ARCH_OS), linux freebsd))
127+<<<<<<< TREE
128 $(CC) $(CFLAGS) $(LDFLAGS) $(CPPFLAGS) -o clear_console \
129 debian/clear_console.c $(termcap_lib)
130+=======
131+ $(CC) $(CFLAGS) -o clear_console debian/clear_console.c $(LDFLAGS) -lncurses
132+>>>>>>> MERGE-SOURCE
133 endif
134
135 # ---------------------------------------------------------------------------
136@@ -419,6 +435,7 @@
137 fi
138 touch stamps/stamp-configure-$(build)
139
140+<<<<<<< TREE
141 patchdir = debian/patches
142
143 $(patchdir)/series: $(patchdir)/series.in
144@@ -427,6 +444,77 @@
145 -Darch_os_$(DEB_HOST_ARCH_OS) -Darch_$(DEB_HOST_ARCH) \
146 -o - $(patchdir)/series.in \
147 | egrep -v '^(#.*|$$)' > $(patchdir)/series
148+=======
149+patchdir = debian/patches
150+debian_patches = \
151+ bash42-001 \
152+ bash42-002 \
153+ bash42-003 \
154+ bash42-004 \
155+ bash42-005 \
156+ bash42-006 \
157+ bash42-007 \
158+ bash42-008 \
159+ bash42-009 \
160+ bash42-010 \
161+ bashbug-editor \
162+ deb-bash-config \
163+ deb-examples \
164+ man-arithmetic \
165+ man-fignore \
166+ man-bashrc \
167+ man-bashlogout \
168+ man-substring-exp \
169+ man-nocaseglob \
170+ man-test \
171+ man-test2 \
172+ privmode \
173+ rbash-manpage \
174+ bash-default-editor \
175+ bash-subst-param-length \
176+ pgrp-pipe \
177+ input-err \
178+ exec-redirections-man \
179+ bash-aliases-repeat \
180+ bash-amd64-no-static-libc \
181+ quoted-nulls \
182+ no-brk-caching \
183+ harden-formatstring \
184+
185+ifeq ($(with_gfdl),yes)
186+ debian_patches += \
187+ man-substring-exp-doc \
188+ man-test2-doc \
189+ exec-redirections-texi \
190+
191+endif
192+
193+# all debian_patches, without bash205b-*
194+# patches integrated in bashdb: builtins-shift, execute-cmd, man-arithmetic,
195+# man-builtin, man-fignore, random, rbash-manpage, report-155436,
196+# rl-8bit-init, s390-build
197+# and bashdb patch
198+# rbash-manpage \
199+
200+bashdb_patches = \
201+ bashdb \
202+ rl-examples-bdb \
203+ rl-inputrc \
204+ bashbug-editor \
205+ deb-bash-config \
206+ deb-examples \
207+ privmode \
208+
209+# various \
210+
211+# these are applied in bashdb cvs as well
212+# man-arithmetic \
213+# man-fignore \
214+# random \
215+# report-155436 \
216+# s390-build \
217+# builtins-shift
218+>>>>>>> MERGE-SOURCE
219
220 patch-$(bash_src): stamps/stamp-patch-$(bash_src)
221 stamps/stamp-patch-$(bash_src): $(patchdir)/series stamps/stamp-unpack-$(bash_src)

Subscribers

People subscribed via source and target branches

to all changes: