Merge lp:~ubuntu-branches/ubuntu/precise/ario/precise-201204021841 into lp:ubuntu/precise/ario

Proposed by Ubuntu Package Importer
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/precise/ario/precise-201204021841
Merge into: lp:ubuntu/precise/ario
Diff against target: 60 lines (+49/-0) (has conflicts)
2 files modified
debian/patches/glib-single-include.patch (+48/-0)
debian/patches/series (+1/-0)
Conflict adding file debian/patches.  Moved existing file to debian/patches.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/precise/ario/precise-201204021841
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+100496@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/precise/ario reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/precise/ario/precise-201204021841. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

16. By Andrew Starr-Bochicchio

glib-single-include.patch: Starting with glib 2.32 it is
now mandatory to include glib.h instead of individual
headers, or the compiler will generate an error.
Fixes FTBFS. From Debian BTS #665509.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'debian/patches'
2=== renamed directory 'debian/patches' => 'debian/patches.moved'
3=== added file 'debian/patches/glib-single-include.patch'
4--- debian/patches/glib-single-include.patch 1970-01-01 00:00:00 +0000
5+++ debian/patches/glib-single-include.patch 2012-04-02 18:45:30 +0000
6@@ -0,0 +1,48 @@
7+Description: Only <glib.h> can be included directly.
8+ Starting with glib 2.32 it is now mandatory to include glib.h
9+ instead of individual headers, or the compiler will generate
10+ an error.
11+Origin: vendor: Debian
12+Debian-Bug: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=665506
13+
14+Index: ario-1.5.1/src/ario-profiles.h
15+===================================================================
16+--- ario-1.5.1.orig/src/ario-profiles.h 2011-05-17 19:54:49.000000000 +0200
17++++ ario-1.5.1/src/ario-profiles.h 2012-03-30 07:10:46.285079675 +0200
18+@@ -20,7 +20,7 @@
19+ #ifndef __ARIO_PROFILES_H
20+ #define __ARIO_PROFILES_H
21+
22+-#include <glib/gslist.h>
23++#include <glib.h>
24+ #include "servers/ario-server.h"
25+
26+ G_BEGIN_DECLS
27+Index: ario-1.5.1/src/plugins/ario-plugin-info.c
28+===================================================================
29+--- ario-1.5.1.orig/src/plugins/ario-plugin-info.c 2011-02-27 16:07:28.000000000 +0100
30++++ ario-1.5.1/src/plugins/ario-plugin-info.c 2012-03-30 07:10:48.289079604 +0200
31+@@ -27,7 +27,7 @@
32+
33+ #include <string.h>
34+ #include <glib/gi18n.h>
35+-#include <glib/gkeyfile.h>
36++#include <glib.h>
37+
38+ #include "plugins/ario-plugin-info-priv.h"
39+ #include "ario-debug.h"
40+Index: ario-1.5.1/src/ario-util.h
41+===================================================================
42+--- ario-1.5.1.orig/src/ario-util.h 2011-02-27 16:07:31.000000000 +0100
43++++ ario-1.5.1/src/ario-util.h 2012-03-30 07:21:04.725057804 +0200
44+@@ -18,8 +18,8 @@
45+ */
46+
47+ #include "servers/ario-server.h"
48+-#include "glib/gslist.h"
49+-#include "gdk/gdkpixbuf.h"
50++#include <glib.h>
51++#include <gdk/gdkpixbuf.h>
52+
53+ /* Number of covers used to generate the drag & drop image */
54+ #define MAX_COVERS_IN_DRAG 3
55
56=== added file 'debian/patches/series'
57--- debian/patches/series 1970-01-01 00:00:00 +0000
58+++ debian/patches/series 2012-04-02 18:45:30 +0000
59@@ -0,0 +1,1 @@
60+glib-single-include.patch

Subscribers

People subscribed via source and target branches

to all changes: