Merge lp:~ubuntu-branches/ubuntu/oneiric/opendrim-lmp-ssh/oneiric-201107071349 into lp:ubuntu/oneiric/opendrim-lmp-ssh

Proposed by James Westby
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/oneiric/opendrim-lmp-ssh/oneiric-201107071349
Merge into: lp:ubuntu/oneiric/opendrim-lmp-ssh
Diff against target: 32 lines (+21/-0) (has conflicts)
2 files modified
debian/patches/01-ftbfs-add-opendrim-lib.patch (+20/-0)
debian/patches/series (+1/-0)
Conflict adding file debian/patches.  Moved existing file to debian/patches.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/oneiric/opendrim-lmp-ssh/oneiric-201107071349
Reviewer Review Type Date Requested Status
Didier Roche-Tolomelli Disapprove
Ubuntu branches Pending
Review via email: mp+67192@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archve and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/oneiric/opendrim-lmp-ssh reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/oneiric/opendrim-lmp-ssh/oneiric-201107071349. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.
Revision history for this message
Didier Roche-Tolomelli (didrocks) wrote :
review: Disapprove

Unmerged revisions

3. By Sebastian Carneiro

debian/patches/01-ftbfs-add-opendrim-lib.patch: Added library opendrim to
LIBS variable in check routine of acinclude.m4 to build with ld
--as-needed (LP: #756110)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'debian/patches'
2=== renamed directory 'debian/patches' => 'debian/patches.moved'
3=== added file 'debian/patches/01-ftbfs-add-opendrim-lib.patch'
4--- debian/patches/01-ftbfs-add-opendrim-lib.patch 1970-01-01 00:00:00 +0000
5+++ debian/patches/01-ftbfs-add-opendrim-lib.patch 2011-07-07 13:53:30 +0000
6@@ -0,0 +1,20 @@
7+Description: To fix FTBFS because of changes in defaults for toolchain (binutils)
8+ it is necessary to include library opendrim at linking time. This patch modifies
9+ acinclude.m4 adding such library to the LIBS variable.
10+ .
11+Forwarded: http://sourceforge.net/apps/trac/opendrim/ticket/1
12+Author: Sebastian Carneiro <scarneiro@fibertel.com.ar>
13+Last-Update: 2011-07-06
14+
15+Index: opendrim-lmp-ssh/acinclude.m4
16+===================================================================
17+--- opendrim-lmp-ssh.orig/acinclude.m4 2011-07-07 00:12:31.567179001 -0300
18++++ opendrim-lmp-ssh/acinclude.m4 2011-07-07 00:13:17.057222114 -0300
19+@@ -261,6 +261,7 @@
20+ if test -e $OPENDRIMCOMMONLIBDIR/libopendrim.so
21+ then
22+ AC_MSG_RESULT(yes)
23++ LIBS="${LIBS} -lopendrim"
24+ else
25+ AC_MSG_ERROR([[no. The OpenDRIM Common library could not be found (libopendrim.so)]])
26+ fi
27
28=== added file 'debian/patches/series'
29--- debian/patches/series 1970-01-01 00:00:00 +0000
30+++ debian/patches/series 2011-07-07 13:53:30 +0000
31@@ -0,0 +1,1 @@
32+01-ftbfs-add-opendrim-lib.patch

Subscribers

People subscribed via source and target branches

to all changes: