Merge lp:~ubuntu-branches/ubuntu/oneiric/gnome-shell/oneiric-proposed-201202171003 into lp:ubuntu/oneiric-proposed/gnome-shell

Proposed by Ubuntu Package Importer
Status: Merged
Merged at revision: not available
Proposed branch: lp:~ubuntu-branches/ubuntu/oneiric/gnome-shell/oneiric-proposed-201202171003
Merge into: lp:ubuntu/oneiric-proposed/gnome-shell
Diff against target: 299 lines (+250/-0) (has conflicts)
8 files modified
debian/gnome-shell-common.install (+4/-0)
debian/gnome-shell.install (+6/-0)
debian/patches/02_rpath-bluetooth-applet.patch (+32/-0)
debian/patches/04_remove-glx-dependency-on-armel.patch (+52/-0)
debian/patches/07-NetworkMenu-fix-logic-for-updating-wifi-icon.patch (+49/-0)
debian/patches/08-polkit-Find-the-best-user-to-authenticate-as.patch (+49/-0)
debian/patches/09-respect-NoDisplay-semantics-for-app-menu.patch (+27/-0)
debian/patches/10-bluetooth-fix-connection-from-gs-menu.patch (+31/-0)
Conflict adding file debian/gnome-shell-common.install.  Moved existing file to debian/gnome-shell-common.install.moved.
Conflict adding file debian/gnome-shell.install.  Moved existing file to debian/gnome-shell.install.moved.
Conflict adding file debian/patches/02_rpath-bluetooth-applet.patch.  Moved existing file to debian/patches/02_rpath-bluetooth-applet.patch.moved.
Conflict adding file debian/patches/04_remove-glx-dependency-on-armel.patch.  Moved existing file to debian/patches/04_remove-glx-dependency-on-armel.patch.moved.
Conflict adding file debian/patches/07-NetworkMenu-fix-logic-for-updating-wifi-icon.patch.  Moved existing file to debian/patches/07-NetworkMenu-fix-logic-for-updating-wifi-icon.patch.moved.
Conflict adding file debian/patches/08-polkit-Find-the-best-user-to-authenticate-as.patch.  Moved existing file to debian/patches/08-polkit-Find-the-best-user-to-authenticate-as.patch.moved.
Conflict adding file debian/patches/09-respect-NoDisplay-semantics-for-app-menu.patch.  Moved existing file to debian/patches/09-respect-NoDisplay-semantics-for-app-menu.patch.moved.
Conflict adding file debian/patches/10-bluetooth-fix-connection-from-gs-menu.patch.  Moved existing file to debian/patches/10-bluetooth-fix-connection-from-gs-menu.patch.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/oneiric/gnome-shell/oneiric-proposed-201202171003
Reviewer Review Type Date Requested Status
Ubuntu Development Team Pending
Review via email: mp+93546@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archive and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/oneiric-proposed/gnome-shell reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/oneiric/gnome-shell/oneiric-proposed-201202171003. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/gnome-shell-common.install'
2--- debian/gnome-shell-common.install 1970-01-01 00:00:00 +0000
3+++ debian/gnome-shell-common.install 2012-02-17 10:12:18 +0000
4@@ -0,0 +1,4 @@
5+debian/tmp/etc/gconf
6+debian/tmp/usr/share/glib-2.0
7+debian/tmp/usr/share/gnome-shell
8+debian/tmp/usr/share/locale
9
10=== renamed file 'debian/gnome-shell-common.install' => 'debian/gnome-shell-common.install.moved'
11=== added file 'debian/gnome-shell.install'
12--- debian/gnome-shell.install 1970-01-01 00:00:00 +0000
13+++ debian/gnome-shell.install 2012-02-17 10:12:18 +0000
14@@ -0,0 +1,6 @@
15+debian/tmp/usr/bin
16+debian/tmp/usr/lib/gnome-shell
17+debian/tmp/usr/lib/mozilla
18+debian/tmp/usr/share/applications
19+debian/tmp/usr/share/dbus-1
20+debian/tmp/usr/share/man
21
22=== renamed file 'debian/gnome-shell.install' => 'debian/gnome-shell.install.moved'
23=== added file 'debian/patches/02_rpath-bluetooth-applet.patch'
24--- debian/patches/02_rpath-bluetooth-applet.patch 1970-01-01 00:00:00 +0000
25+++ debian/patches/02_rpath-bluetooth-applet.patch 2012-02-17 10:12:18 +0000
26@@ -0,0 +1,32 @@
27+Description: Define rpath for linking against gnome-bluetooth
28+ Modified by Raphael Hertzog to actually make it work.
29+Author: Rico Tzschichholz <ricotz@ubuntu.com>
30+Forwarded: no
31+Last-Update: 2011-04-11
32+
33+Index: gnome-shell-3.2.1/src/Makefile.am
34+===================================================================
35+--- gnome-shell-3.2.1.orig/src/Makefile.am 2011-09-20 23:06:39.000000000 +0200
36++++ gnome-shell-3.2.1/src/Makefile.am 2011-12-03 06:31:28.812401727 +0100
37+@@ -259,7 +259,7 @@
38+ rm -f $(@F).tmp
39+ EXTRA_DIST += shell-enum-types.c.in
40+
41+-libgnome_shell_la_LDFLAGS = -avoid-version
42++libgnome_shell_la_LDFLAGS = -avoid-version -rpath $(pkglibdir):/usr/lib/gnome-bluetooth -R $(pkglibdir)
43+ libgnome_shell_la_LIBADD = \
44+ -lm \
45+ $(GNOME_SHELL_LIBS) \
46+Index: gnome-shell-3.2.1/src/Makefile.in
47+===================================================================
48+--- gnome-shell-3.2.1.orig/src/Makefile.in 2011-10-18 06:24:10.000000000 +0200
49++++ gnome-shell-3.2.1/src/Makefile.in 2011-12-03 06:31:28.816401727 +0100
50+@@ -888,7 +888,7 @@
51+ run_js_test_SOURCES = \
52+ run-js-test.c
53+
54+-libgnome_shell_la_LDFLAGS = -avoid-version
55++libgnome_shell_la_LDFLAGS = -avoid-version -rpath $(pkglibdir):/usr/lib/gnome-bluetooth -R $(pkglibdir)
56+ libgnome_shell_la_LIBADD = \
57+ -lm \
58+ $(GNOME_SHELL_LIBS) \
59
60=== renamed file 'debian/patches/02_rpath-bluetooth-applet.patch' => 'debian/patches/02_rpath-bluetooth-applet.patch.moved'
61=== added file 'debian/patches/04_remove-glx-dependency-on-armel.patch'
62--- debian/patches/04_remove-glx-dependency-on-armel.patch 1970-01-01 00:00:00 +0000
63+++ debian/patches/04_remove-glx-dependency-on-armel.patch 2012-02-17 10:12:18 +0000
64@@ -0,0 +1,52 @@
65+From: Robert Bragg <robert@linux.intel.com>
66+Date: Wed, 13 Jul 2011 12:20:43 +0100
67+Subject: [PATCH] Remove GLX dependency
68+
69+Index: oneiric/src/gnome-shell-plugin.c
70+===================================================================
71+--- oneiric.orig/src/gnome-shell-plugin.c 2011-09-04 04:01:43.713265027 -0400
72++++ oneiric/src/gnome-shell-plugin.c 2011-09-06 11:20:47.243195279 -0400
73+@@ -30,8 +30,11 @@
74+
75+ #include <clutter/clutter.h>
76+ #include <clutter/x11/clutter-x11.h>
77++#if defined (__arm__)
78++#else
79+ #include <GL/glx.h>
80+ #include <GL/glxext.h>
81++#endif
82+ #include <gjs/gjs.h>
83+ #include <meta/display.h>
84+ #include <meta/meta-plugin.h>
85+@@ -146,14 +149,23 @@
86+ gnome_shell_plugin_start (MetaPlugin *plugin)
87+ {
88+ GnomeShellPlugin *shell_plugin = GNOME_SHELL_PLUGIN (plugin);
89++#if defined (__arm__)
90++#else
91+ MetaScreen *screen;
92+ MetaDisplay *display;
93+ Display *xdisplay;
94++#endif
95+ GError *error = NULL;
96+ int status;
97++#if defined (__arm__)
98++#else
99+ const char *glx_extensions;
100++#endif
101+ GjsContext *gjs_context;
102+
103++#if defined (__arm__)
104++ shell_plugin->have_swap_event = 0;
105++#else
106+ screen = meta_plugin_get_screen (plugin);
107+ display = meta_screen_get_display (screen);
108+
109+@@ -166,6 +178,7 @@
110+ glx_extensions = glXQueryExtensionsString (xdisplay,
111+ meta_screen_get_screen_number (screen));
112+ shell_plugin->have_swap_event = strstr (glx_extensions, "GLX_INTEL_swap_event") != NULL;
113++#endif
114+
115+ shell_perf_log_define_event (shell_perf_log_get_default (),
116+ "glx.swapComplete",
117
118=== renamed file 'debian/patches/04_remove-glx-dependency-on-armel.patch' => 'debian/patches/04_remove-glx-dependency-on-armel.patch.moved'
119=== added file 'debian/patches/07-NetworkMenu-fix-logic-for-updating-wifi-icon.patch'
120--- debian/patches/07-NetworkMenu-fix-logic-for-updating-wifi-icon.patch 1970-01-01 00:00:00 +0000
121+++ debian/patches/07-NetworkMenu-fix-logic-for-updating-wifi-icon.patch 2012-02-17 10:12:18 +0000
122@@ -0,0 +1,49 @@
123+From 9aae5cf478fe3c04cb956b23b166fd49261b8d61 Mon Sep 17 00:00:00 2001
124+From: Giovanni Campagna <gcampagna@src.gnome.org>
125+Date: Sat, 29 Oct 2011 14:35:09 +0200
126+Subject: [PATCH 3/3] NetworkMenu: fix logic for updating wifi icon
127+
128+Previously, we connected to notify::strength only if there was
129+already a signal connected, and the AP changed (thus, by induction,
130+we never connected). As a result, the icon became stale and different
131+from that shown inside the menu (which is correctly updated).
132+
133+https://bugzilla.gnome.org/show_bug.cgi?id=650007
134+---
135+ js/ui/status/network.js | 12 +++++++-----
136+ 1 files changed, 7 insertions(+), 5 deletions(-)
137+
138+diff --git a/js/ui/status/network.js b/js/ui/status/network.js
139+index aa9b277..d40f7a6 100644
140+--- a/js/ui/status/network.js
141++++ b/js/ui/status/network.js
142+@@ -2061,10 +2061,11 @@ NMApplet.prototype = {
143+ }
144+ this.setIcon('network-wireless-connected');
145+ } else {
146+- if (this._accessPointUpdateId && this._activeAccessPoint != ap) {
147+- this._activeAccessPoint.disconnect(this._accessPointUpdateId);
148++ if (this._activeAccessPoint != ap) {
149++ if (this._accessPointUpdateId)
150++ this._activeAccessPoint.disconnect(this._accessPointUpdateId);
151+ this._activeAccessPoint = ap;
152+- this._activeAccessPointUpdateId = ap.connect('notify::strength', Lang.bind(function() {
153++ this._activeAccessPointUpdateId = ap.connect('notify::strength', Lang.bind(this, function() {
154+ this.setIcon('network-wireless-signal-' + signalToIcon(ap.strength));
155+ }));
156+ }
157+@@ -2091,8 +2092,9 @@ NMApplet.prototype = {
158+ break;
159+ }
160+
161+- if (this._mobileUpdateId && this._mobileUpdateDevice != dev) {
162+- this._mobileUpdateDevice.disconnect(this._mobileUpdateId);
163++ if (dev.mobileDevice != this._mobileUpdateDevice) {
164++ if (this._mobileUpdateId)
165++ this._mobileUpdateDevice.disconnect(this._mobileUpdateId);
166+ this._mobileUpdateDevice = dev.mobileDevice;
167+ this._mobileUpdateId = dev.mobileDevice.connect('notify::signal-quality', Lang.bind(this, function() {
168+ this.setIcon('network-cellular-signal-' + signalToIcon(dev.mobileDevice.signal_quality));
169+--
170+1.7.7.3
171+
172
173=== renamed file 'debian/patches/07-NetworkMenu-fix-logic-for-updating-wifi-icon.patch' => 'debian/patches/07-NetworkMenu-fix-logic-for-updating-wifi-icon.patch.moved'
174=== added file 'debian/patches/08-polkit-Find-the-best-user-to-authenticate-as.patch'
175--- debian/patches/08-polkit-Find-the-best-user-to-authenticate-as.patch 1970-01-01 00:00:00 +0000
176+++ debian/patches/08-polkit-Find-the-best-user-to-authenticate-as.patch 2012-02-17 10:12:18 +0000
177@@ -0,0 +1,49 @@
178+From b98e1daac76ea0a5417ca1efd0ba668fb8ec4816 Mon Sep 17 00:00:00 2001
179+From: Matthias Clasen <mclasen@redhat.com>
180+Date: Thu, 17 Nov 2011 22:42:37 -0500
181+Subject: [PATCH] polkit: Find the best user to authenticate as
182+
183+We prefer to ask the user for his own password. If PolicyKit
184+is not configured to accept that, try the root password. If
185+PolicyKit does not accept that either, ask for password of
186+the first user that PolicyKit _will_ accept. The last case
187+is a bit broken, but should rarely occur in real-life
188+configurations.
189+
190+https://bugzilla.gnome.org/show_bug.cgi?id=651547
191+---
192+ js/ui/polkitAuthenticationAgent.js | 9 +++++++--
193+ 1 files changed, 7 insertions(+), 2 deletions(-)
194+
195+diff --git a/js/ui/polkitAuthenticationAgent.js b/js/ui/polkitAuthenticationAgent.js
196+index 2d7063a..6f01039 100644
197+--- a/js/ui/polkitAuthenticationAgent.js
198++++ b/js/ui/polkitAuthenticationAgent.js
199+@@ -27,6 +27,7 @@ const AccountsService = imports.gi.AccountsService;
200+ const Clutter = imports.gi.Clutter;
201+ const St = imports.gi.St;
202+ const Pango = imports.gi.Pango;
203++const GLib = imports.gi.GLib;
204+ const Gio = imports.gi.Gio;
205+ const Mainloop = imports.mainloop;
206+ const Polkit = imports.gi.Polkit;
207+@@ -88,10 +89,14 @@ AuthenticationDialog.prototype = {
208+ if (userNames.length > 1) {
209+ log('polkitAuthenticationAgent: Received ' + userNames.length +
210+ ' identities that can be used for authentication. Only ' +
211+- 'considering the first one.');
212++ 'considering one.');
213+ }
214+
215+- let userName = userNames[0];
216++ let userName = GLib.get_user_name();
217++ if (userNames.indexOf(userName) < 0)
218++ userName = 'root';
219++ if (userNames.indexOf(userName) < 0)
220++ userName = userNames[0];
221+
222+ this._user = AccountsService.UserManager.get_default().get_user(userName);
223+ let userRealName = this._user.get_real_name()
224+--
225+1.7.7.3
226+
227
228=== renamed file 'debian/patches/08-polkit-Find-the-best-user-to-authenticate-as.patch' => 'debian/patches/08-polkit-Find-the-best-user-to-authenticate-as.patch.moved'
229=== added file 'debian/patches/09-respect-NoDisplay-semantics-for-app-menu.patch'
230--- debian/patches/09-respect-NoDisplay-semantics-for-app-menu.patch 1970-01-01 00:00:00 +0000
231+++ debian/patches/09-respect-NoDisplay-semantics-for-app-menu.patch 2012-02-17 10:12:18 +0000
232@@ -0,0 +1,27 @@
233+From 3013e942d862840e46eb07de9e84f9d80e7e13cc Mon Sep 17 00:00:00 2001
234+From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20P=C3=A9ters?= <fpeters@0d.be>
235+Date: Sun, 4 Sep 2011 15:29:38 +0200
236+Subject: [PATCH] Also respect NoDisplay semantics for applications menu
237+
238+https://bugzilla.gnome.org/show_bug.cgi?id=658176
239+---
240+ src/shell-app-system.c | 6 +-----
241+ 1 files changed, 1 insertions(+), 5 deletions(-)
242+
243+Index: gnome-shell-3.2.1/src/shell-app-system.c
244+===================================================================
245+--- gnome-shell-3.2.1.orig/src/shell-app-system.c 2011-10-17 17:24:49.000000000 +0200
246++++ gnome-shell-3.2.1/src/shell-app-system.c 2011-12-03 06:31:39.572401347 +0100
247+@@ -102,11 +102,7 @@
248+ NULL,
249+ (GDestroyNotify)g_object_unref);
250+
251+- /* For now, we want to pick up Evince, Nautilus, etc. We'll
252+- * handle NODISPLAY semantics at a higher level or investigate them
253+- * case by case.
254+- */
255+- priv->apps_tree = gmenu_tree_new ("applications.menu", GMENU_TREE_FLAGS_INCLUDE_NODISPLAY);
256++ priv->apps_tree = gmenu_tree_new ("applications.menu", 0);
257+ g_signal_connect (priv->apps_tree, "changed", G_CALLBACK (on_apps_tree_changed_cb), self);
258+
259+ priv->settings_tree = gmenu_tree_new ("gnomecc.menu", 0);
260
261=== renamed file 'debian/patches/09-respect-NoDisplay-semantics-for-app-menu.patch' => 'debian/patches/09-respect-NoDisplay-semantics-for-app-menu.patch.moved'
262=== added file 'debian/patches/10-bluetooth-fix-connection-from-gs-menu.patch'
263--- debian/patches/10-bluetooth-fix-connection-from-gs-menu.patch 1970-01-01 00:00:00 +0000
264+++ debian/patches/10-bluetooth-fix-connection-from-gs-menu.patch 2012-02-17 10:12:18 +0000
265@@ -0,0 +1,31 @@
266+From 0ed0dc89b51f8e584dd21c87a7178ba138bed44b Mon Sep 17 00:00:00 2001
267+From: Alessandro Crismani <alessandro.crismani@gmail.com>
268+Date: Tue, 13 Dec 2011 10:01:34 +0100
269+Subject: [PATCH] Bluetooth: fix connecting devices from GS's panel on 3.2.1
270+
271+Connecting devices from Gnome Shell's panel on Gnome 3.2.1 fails because
272+of an undefined variable in
273+js/ui/status/bluetooth.js:buildDeviceSubMenu. More explicitly, the
274+menuitem variable is not declared and hence connecting and disconnecting
275+fails. Fix it to make the bluetooth panel menu item work.
276+---
277+ js/ui/status/bluetooth.js | 3 ++-
278+ 1 files changed, 2 insertions(+), 1 deletions(-)
279+
280+diff --git a/js/ui/status/bluetooth.js b/js/ui/status/bluetooth.js
281+index f2d95f5..3aa7960 100644
282+--- a/js/ui/status/bluetooth.js
283++++ b/js/ui/status/bluetooth.js
284+@@ -205,7 +205,8 @@ Indicator.prototype = {
285+ _buildDeviceSubMenu: function(item, device) {
286+ if (device.can_connect) {
287+ item._connected = device.connected;
288+- item._connectedMenuitem = new PopupMenu.PopupSwitchMenuItem(_("Connection"), device.connected);
289++ let menuitem = new PopupMenu.PopupSwitchMenuItem(_("Connection"), device.connected);
290++ item._connectedMenuitem = menuitem;
291+ item._connectedMenuitem.connect('toggled', Lang.bind(this, function() {
292+ if (item._connected > ConnectionState.CONNECTED) {
293+ // operation already in progress, revert
294+--
295+1.7.8
296+
297
298=== renamed file 'debian/patches/10-bluetooth-fix-connection-from-gs-menu.patch' => 'debian/patches/10-bluetooth-fix-connection-from-gs-menu.patch.moved'
299=== modified file 'js/ui/status/network.js'

Subscribers

People subscribed via source and target branches

to all changes: