Merge lp:~ubuntu-branches/ubuntu/oneiric/cdpr/oneiric-201108212106 into lp:ubuntu/oneiric/cdpr

Proposed by Ubuntu Package Importer
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/oneiric/cdpr/oneiric-201108212106
Merge into: lp:ubuntu/oneiric/cdpr
Diff against target: 33 lines (+27/-0) (has conflicts)
1 file modified
debian/patches/0003-fix-as-needed-build.patch (+27/-0)
Conflict adding file debian/patches/0003-fix-as-needed-build.patch.  Moved existing file to debian/patches/0003-fix-as-needed-build.patch.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/oneiric/cdpr/oneiric-201108212106
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+72359@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archve and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/oneiric/cdpr reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/oneiric/cdpr/oneiric-201108212106. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

5. By Charlie_Smotherman

* debian/patches/0003-fix-as-needed-build.patch:
  - fix build with ld --as-needed (LP: #803174)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added file 'debian/patches/0003-fix-as-needed-build.patch'
2--- debian/patches/0003-fix-as-needed-build.patch 1970-01-01 00:00:00 +0000
3+++ debian/patches/0003-fix-as-needed-build.patch 2011-08-21 21:10:24 +0000
4@@ -0,0 +1,27 @@
5+Description: fix build with ld --as-needed
6+ when building with ld --as-needed libraries must be placed
7+ after object files needing them on the command line so the symbols
8+ of the libraries are registered as needed.
9+Author: Julian Taylor <jtaylor.debian@googlemail.com>
10+Bug-Ubuntu: https://bugs.launchpad.net/ubuntu/+source/cdpr/+bug/803174
11+Bug-Debian: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=632665
12+--- cdpr-2.4.orig/Makefile
13++++ cdpr-2.4/Makefile
14+@@ -16,7 +16,7 @@ CFLAGS = -Wall -W -O2
15+ # Build for Solaris with the pcap headers/libs one dir up
16+ #CFLAGS = -DSOLARIS -Wall -I. -I../libpcap-0.7.1 -L../libpcap-0.7.1 -ggdb
17+
18+-LDFLAGS = -lpcap
19++LIBS = -lpcap
20+
21+ # Build for Solaris
22+ #LDFLAGS = -lsocket -lnsl -lpcap
23+@@ -33,7 +33,7 @@ conffile.o: conffile.c cdp.h cdpr.h
24+ gcc -c $(CFLAGS) conffile.c
25+
26+ cdpr: cdpr.o cdprs.o conffile.o
27+- gcc $(LDFLAGS) -o cdpr cdpr.o cdprs.o conffile.o
28++ gcc $(LDFLAGS) -o cdpr cdpr.o cdprs.o conffile.o $(LIBS)
29+
30+ install: all
31+ mkdir -p $(DESTDIR)$(prefix)/sbin/
32
33=== renamed file 'debian/patches/0003-fix-as-needed-build.patch' => 'debian/patches/0003-fix-as-needed-build.patch.moved'

Subscribers

People subscribed via source and target branches

to all changes: