Merge lp:~ubuntu-branches/ubuntu/natty/openldap/natty-201103250224 into lp:ubuntu/natty/openldap

Proposed by James Westby
Status: Work in progress
Proposed branch: lp:~ubuntu-branches/ubuntu/natty/openldap/natty-201103250224
Merge into: lp:ubuntu/natty/openldap
Diff against target: 233 lines (+152/-74) (has conflicts)
1 file modified
debian/patches/service-operational-before-detach (+152/-74)
Text conflict in debian/patches/service-operational-before-detach
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/natty/openldap/natty-201103250224
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+55071@code.launchpad.net

Description of the change

The package history in the archive and the history in the bzr branch differ. As the archive is authoritative the history of lp:ubuntu/natty/openldap now reflects that and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/natty/openldap/natty-201103250224. A merge should be performed if necessary.

To post a comment you must log in.

Unmerged revisions

35. By Dave Walker

debian/patches/service-operational-before-detach: New patch replacing
old one of same name as previous could cause database corruption,
based on upstream commits. (LP: #727973)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/patches/service-operational-before-detach'
2--- debian/patches/service-operational-before-detach 2011-03-02 20:33:08 +0000
3+++ debian/patches/service-operational-before-detach 2011-03-28 07:14:19 +0000
4@@ -1,77 +1,155 @@
5-Description: Wait for database startup before parent exits.
6- This patch replaces the previous one named the same name,
7- but is based on upstream commits; as the previous applied
8- patch could cause database corruption.
9- .
10- Patch is based on upstream commits as described below:
11- libraries/liblutil/detach.c 1.25 -> 1.26
12- include/lutil.h 1.81 -> 1.82
13- servers/slapd/main.c 1.276 -> 1.278
14- .
15-Forwarded: not-needed
16-Origin: upstream, commit:1.26
17-Origin: upstream, commit:1.82
18-Origin: upstream, commit:1.278
19-Bug: http://www.openldap.org/its/index.cgi/?findid=6848
20-Bug-Ubuntu: https://launchpad.net/bugs/727973
21-Reviewed-by: Dave Walker (Daviey) <DaveWalker@ubuntu.com>
22-Last-Update: 2011-03-02
23-
24---- a/include/lutil.h
25-+++ b/include/lutil.h
26-@@ -48,7 +48,7 @@
27- size_t));
28-
29- /* detach.c */
30--LDAP_LUTIL_F( void )
31-+LDAP_LUTIL_F( int )
32- lutil_detach LDAP_P((
33- int debug,
34- int do_close));
35---- a/libraries/liblutil/detach.c
36-+++ b/libraries/liblutil/detach.c
37-@@ -49,10 +49,10 @@
38-
39- #include "lutil.h"
40-
41--void
42-+int
43- lutil_detach( int debug, int do_close )
44- {
45-- int i, sd, nbits;
46-+ int i, sd, nbits, pid;
47-
48- #ifdef HAVE_SYSCONF
49- nbits = sysconf( _SC_OPEN_MAX );
50-@@ -71,10 +71,11 @@
51- if ( debug == 0 ) {
52- for ( i = 0; i < 5; i++ ) {
53- #ifdef HAVE_THR
54-- switch ( fork1() )
55-+ pid = fork1();
56- #else
57-- switch ( fork() )
58-+ pid = fork();
59- #endif
60-+ switch ( pid )
61- {
62- case -1:
63- sleep( 5 );
64-@@ -84,7 +85,7 @@
65- break;
66-
67- default:
68-- _exit( EXIT_SUCCESS );
69-+ return pid;
70- }
71- break;
72- }
73-@@ -139,4 +140,5 @@
74- #ifdef SIGPIPE
75- (void) SIGNAL( SIGPIPE, SIG_IGN );
76- #endif
77-+ return 0;
78- }
79+<<<<<<< TREE
80+Description: Wait for database startup before parent exits.
81+ This patch replaces the previous one named the same name,
82+ but is based on upstream commits; as the previous applied
83+ patch could cause database corruption.
84+ .
85+ Patch is based on upstream commits as described below:
86+ libraries/liblutil/detach.c 1.25 -> 1.26
87+ include/lutil.h 1.81 -> 1.82
88+ servers/slapd/main.c 1.276 -> 1.278
89+ .
90+Forwarded: not-needed
91+Origin: upstream, commit:1.26
92+Origin: upstream, commit:1.82
93+Origin: upstream, commit:1.278
94+Bug: http://www.openldap.org/its/index.cgi/?findid=6848
95+Bug-Ubuntu: https://launchpad.net/bugs/727973
96+Reviewed-by: Dave Walker (Daviey) <DaveWalker@ubuntu.com>
97+Last-Update: 2011-03-02
98+
99+--- a/include/lutil.h
100++++ b/include/lutil.h
101+@@ -48,7 +48,7 @@
102+ size_t));
103+
104+ /* detach.c */
105+-LDAP_LUTIL_F( void )
106++LDAP_LUTIL_F( int )
107+ lutil_detach LDAP_P((
108+ int debug,
109+ int do_close));
110+--- a/libraries/liblutil/detach.c
111++++ b/libraries/liblutil/detach.c
112+@@ -49,10 +49,10 @@
113+
114+ #include "lutil.h"
115+
116+-void
117++int
118+ lutil_detach( int debug, int do_close )
119+ {
120+- int i, sd, nbits;
121++ int i, sd, nbits, pid;
122+
123+ #ifdef HAVE_SYSCONF
124+ nbits = sysconf( _SC_OPEN_MAX );
125+@@ -71,10 +71,11 @@
126+ if ( debug == 0 ) {
127+ for ( i = 0; i < 5; i++ ) {
128+ #ifdef HAVE_THR
129+- switch ( fork1() )
130++ pid = fork1();
131+ #else
132+- switch ( fork() )
133++ pid = fork();
134+ #endif
135++ switch ( pid )
136+ {
137+ case -1:
138+ sleep( 5 );
139+@@ -84,7 +85,7 @@
140+ break;
141+
142+ default:
143+- _exit( EXIT_SUCCESS );
144++ return pid;
145+ }
146+ break;
147+ }
148+@@ -139,4 +140,5 @@
149+ #ifdef SIGPIPE
150+ (void) SIGNAL( SIGPIPE, SIG_IGN );
151+ #endif
152++ return 0;
153+ }
154+=======
155+Description: Wait for database startup before parent exits.
156+ This patch replaces the previous one named the same name,
157+ but is based on upstream commits; as the previous applied
158+ patch could cause database corruption.
159+ .
160+ Patch is based on upstream commits as described below:
161+ libraries/liblutil/detach.c 1.25 -> 1.26
162+ include/lutil.h 1.81 -> 1.82
163+ servers/slapd/main.c 1.276 -> 1.278
164+ .
165+Forwarded: not-needed
166+Origin: upstream, commit:1.26
167+Origin: upstream, commit:1.82
168+Origin: upstream, commit:1.278
169+Bug: http://www.openldap.org/its/index.cgi/?findid=6848
170+Bug-Ubuntu: https://launchpad.net/bugs/727973
171+Bug-Debian: http://bugs.debian.org/589915
172+Reviewed-by: Dave Walker (Daviey) <DaveWalker@ubuntu.com>
173+Last-Update: 2011-03-02
174+
175+--- a/include/lutil.h
176++++ b/include/lutil.h
177+@@ -48,7 +48,7 @@
178+ size_t));
179+
180+ /* detach.c */
181+-LDAP_LUTIL_F( void )
182++LDAP_LUTIL_F( int )
183+ lutil_detach LDAP_P((
184+ int debug,
185+ int do_close));
186+--- a/libraries/liblutil/detach.c
187++++ b/libraries/liblutil/detach.c
188+@@ -49,10 +49,10 @@
189+
190+ #include "lutil.h"
191+
192+-void
193++int
194+ lutil_detach( int debug, int do_close )
195+ {
196+- int i, sd, nbits;
197++ int i, sd, nbits, pid;
198+
199+ #ifdef HAVE_SYSCONF
200+ nbits = sysconf( _SC_OPEN_MAX );
201+@@ -71,10 +71,11 @@
202+ if ( debug == 0 ) {
203+ for ( i = 0; i < 5; i++ ) {
204+ #ifdef HAVE_THR
205+- switch ( fork1() )
206++ pid = fork1();
207+ #else
208+- switch ( fork() )
209++ pid = fork();
210+ #endif
211++ switch ( pid )
212+ {
213+ case -1:
214+ sleep( 5 );
215+@@ -84,7 +85,7 @@
216+ break;
217+
218+ default:
219+- _exit( EXIT_SUCCESS );
220++ return pid;
221+ }
222+ break;
223+ }
224+@@ -139,4 +140,5 @@
225+ #ifdef SIGPIPE
226+ (void) SIGNAL( SIGPIPE, SIG_IGN );
227+ #endif
228++ return 0;
229+ }
230+>>>>>>> MERGE-SOURCE
231 --- a/servers/slapd/main.c
232 +++ b/servers/slapd/main.c
233 @@ -364,6 +364,9 @@

Subscribers

People subscribed via source and target branches

to all changes: