Merge lp:~ubuntu-branches/ubuntu/natty/kbarcode/collision into lp:ubuntu/natty/kbarcode

Proposed by James Westby
Status: Rejected
Rejected by: Martin Pitt
Proposed branch: lp:~ubuntu-branches/ubuntu/natty/kbarcode/collision
Merge into: lp:ubuntu/natty/kbarcode
Diff against target: 61 lines (+29/-1)
4 files modified
debian/changelog (+7/-0)
debian/control (+2/-1)
debian/patches/10_fix_ftbfs_binutils-gold.diff (+19/-0)
debian/patches/series (+1/-0)
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/natty/kbarcode/collision
Reviewer Review Type Date Requested Status
Dave Walker (community) Disapprove
Ubuntu branches Pending
Review via email: mp+51809@code.launchpad.net

Description of the change

This would have been what the importer did had it not found a bug.

These are the changes that Daviey put in the branch, and should be
assessed to see if they should be included in the next upload.

To post a comment you must log in.
Revision history for this message
Dave Walker (davewalker) wrote :

Not needed, the divergence between package in archive and this is pretty much cosmetic.

Thanks!

review: Disapprove

Unmerged revisions

15. By Tarun K. Mall

* debian/patches/10_fix_ftbfs_binutils-gold:diff
  - Fix FTBFS with binutils-gold. (LP: #726405, Closes: #615967)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2010-08-11 08:50:45 +0000
3+++ debian/changelog 2011-03-01 20:44:19 +0000
4@@ -1,3 +1,10 @@
5+kbarcode (2.0.7-3ubuntu1) natty; urgency=low
6+
7+ * debian/patches/10_fix_ftbfs_binutils-gold:diff
8+ - Fix FTBFS with binutils-gold. (LP: #726405, Closes: #615967)
9+
10+ -- Tarun Kumar Mall <c2tarun@gmail.com> Tue, 01 Mar 2011 12:07:58 +0000
11+
12 kbarcode (2.0.7-3) unstable; urgency=low
13
14 * Add missing Name key to kbarcode-label desktop file. (Closes: #570129)
15
16=== modified file 'debian/control'
17--- debian/control 2010-08-11 08:50:45 +0000
18+++ debian/control 2011-03-01 20:44:19 +0000
19@@ -1,7 +1,8 @@
20 Source: kbarcode
21 Section: kde
22 Priority: optional
23-Maintainer: Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>
24+Maintainer: Ubuntu Developers <ubuntu-devel-discuss@lists.ubuntu.com>
25+XSBC-Original-Maintainer: Debian KDE Extras Team <pkg-kde-extras@lists.alioth.debian.org>
26 Uploaders: Fathi Boudra <fabo@debian.org>, Mark Purcell <msp@debian.org>
27 Build-Depends: cdbs (>= 0.4.52), debhelper (>= 7), quilt, automake, kdelibs4-dev
28 Standards-Version: 3.9.1
29
30=== added file 'debian/patches/10_fix_ftbfs_binutils-gold.diff'
31--- debian/patches/10_fix_ftbfs_binutils-gold.diff 1970-01-01 00:00:00 +0000
32+++ debian/patches/10_fix_ftbfs_binutils-gold.diff 2011-03-01 20:44:19 +0000
33@@ -0,0 +1,19 @@
34+From: Tarun Kumar Mall <c2tarun@gmail.com>
35+Description: This patch fixex FTBFS problem by adding certain libraries to
36+ file kbarcode-2.0.7.orig/kbarcode/Makefile.am
37+Bug-Ubuntu: https://launchpad.net/bugs/726405
38+Bug-Debian: http://bugs.debian.org/615967
39+
40+Index: kbarcode-2.0.7/kbarcode/Makefile.am
41+===================================================================
42+--- kbarcode-2.0.7.orig/kbarcode/Makefile.am 2011-03-01 09:24:57.447560008 +0000
43++++ kbarcode-2.0.7/kbarcode/Makefile.am 2011-03-01 09:25:23.667559799 +0000
44+@@ -21,7 +21,7 @@
45+
46+ kbarcode_LDFLAGS = $(KDE_RPATH) $(all_libraries)
47+ kbarcode_LDADD = $(LIB_KABC) $(LIB_KSPELL) $(LIB_KDEPRINT) \
48+- $(LIB_KDEUI) -lkjs -lpcre
49++ $(LIB_KDEUI) -lkjs -lpcre -lkio -lqt-mt -lDCOP -lkdecore
50+
51+ noinst_HEADERS = barcodecombo.h barcodedialog.h barcodedialogs.h commands.h \
52+ configdialog.h confwizard.h csvimportdlg.h databasebrowser.h definition.h \
53
54=== modified file 'debian/patches/series'
55--- debian/patches/series 2010-08-11 08:50:45 +0000
56+++ debian/patches/series 2011-03-01 20:44:19 +0000
57@@ -6,3 +6,4 @@
58 07_autoconf2.64.diff
59 08_automake-1.1x.diff
60 09_missing_name_key.diff
61+10_fix_ftbfs_binutils-gold.diff

Subscribers

People subscribed via source and target branches

to all changes: