Merge lp:~ubuntu-branches/ubuntu/natty/gvfs/natty-201108221812 into lp:ubuntu/natty/gvfs

Proposed by Ubuntu Package Importer
Status: Rejected
Rejected by: James Westby
Proposed branch: lp:~ubuntu-branches/ubuntu/natty/gvfs/natty-201108221812
Merge into: lp:ubuntu/natty/gvfs
Diff against target: 491 lines (+449/-6) (has conflicts)
7 files modified
debian/gvfs-backends.debhelper.log (+0/-1)
debian/gvfs-bin.debhelper.log (+0/-1)
debian/gvfs-fuse.debhelper.log (+0/-1)
debian/gvfs.debhelper.log (+0/-1)
debian/libgvfscommon-dev.debhelper.log (+0/-1)
debian/libgvfscommon0.debhelper.log (+0/-1)
debian/patches/90_git_leaks_fixes.patch (+449/-0)
Conflict adding file debian/patches/90_git_leaks_fixes.patch.  Moved existing file to debian/patches/90_git_leaks_fixes.patch.moved.
To merge this branch: bzr merge lp:~ubuntu-branches/ubuntu/natty/gvfs/natty-201108221812
Reviewer Review Type Date Requested Status
Ubuntu branches Pending
Review via email: mp+72482@code.launchpad.net

Description of the change

The package importer has detected a possible inconsistency between the package history in the archve and the history in bzr. As the archive is authoritative the importer has made lp:ubuntu/natty/gvfs reflect what is in the archive and the old bzr branch has been pushed to lp:~ubuntu-branches/ubuntu/natty/gvfs/natty-201108221812. This merge proposal was created so that an Ubuntu developer can review the situations and perform a merge/upload if necessary. There are three typical cases where this can happen.
  1. Where someone pushes a change to bzr and someone else uploads the package without that change. This is the reason that this check is done by the importer. If this appears to be the case then a merge/upload should be done if the changes that were in bzr are still desirable.
  2. The importer incorrectly detected the above situation when someone made a change in bzr and then uploaded it.
  3. The importer incorrectly detected the above situation when someone just uploaded a package and didn't touch bzr.

If this case doesn't appear to be the first situation then set the status of the merge proposal to "Rejected" and help avoid the problem in future by filing a bug at https://bugs.launchpad.net/udd linking to this merge proposal.

(this is an automatically generated message)

To post a comment you must log in.

Unmerged revisions

156. By Sebastien Bacher

releasing version 1.8.0-0ubuntu2

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== removed file 'debian/gvfs-backends.debhelper.log'
2--- debian/gvfs-backends.debhelper.log 2010-10-25 19:30:18 +0000
3+++ debian/gvfs-backends.debhelper.log 1970-01-01 00:00:00 +0000
4@@ -1,1 +0,0 @@
5-dh_autoreconf_clean
6
7=== removed file 'debian/gvfs-bin.debhelper.log'
8--- debian/gvfs-bin.debhelper.log 2010-10-25 19:30:18 +0000
9+++ debian/gvfs-bin.debhelper.log 1970-01-01 00:00:00 +0000
10@@ -1,1 +0,0 @@
11-dh_autoreconf_clean
12
13=== removed file 'debian/gvfs-fuse.debhelper.log'
14--- debian/gvfs-fuse.debhelper.log 2010-10-25 19:30:18 +0000
15+++ debian/gvfs-fuse.debhelper.log 1970-01-01 00:00:00 +0000
16@@ -1,1 +0,0 @@
17-dh_autoreconf_clean
18
19=== removed file 'debian/gvfs.debhelper.log'
20--- debian/gvfs.debhelper.log 2010-10-25 19:30:18 +0000
21+++ debian/gvfs.debhelper.log 1970-01-01 00:00:00 +0000
22@@ -1,1 +0,0 @@
23-dh_autoreconf_clean
24
25=== removed file 'debian/libgvfscommon-dev.debhelper.log'
26--- debian/libgvfscommon-dev.debhelper.log 2010-10-25 19:30:18 +0000
27+++ debian/libgvfscommon-dev.debhelper.log 1970-01-01 00:00:00 +0000
28@@ -1,1 +0,0 @@
29-dh_autoreconf_clean
30
31=== removed file 'debian/libgvfscommon0.debhelper.log'
32--- debian/libgvfscommon0.debhelper.log 2010-10-25 19:30:18 +0000
33+++ debian/libgvfscommon0.debhelper.log 1970-01-01 00:00:00 +0000
34@@ -1,1 +0,0 @@
35-dh_autoreconf_clean
36
37=== added file 'debian/patches/90_git_leaks_fixes.patch'
38--- debian/patches/90_git_leaks_fixes.patch 1970-01-01 00:00:00 +0000
39+++ debian/patches/90_git_leaks_fixes.patch 2011-08-22 18:25:34 +0000
40@@ -0,0 +1,449 @@
41+From caf8ba57f5c20c588bf685c648d842e8d46bf769 Mon Sep 17 00:00:00 2001
42+From: Alexander Larsson <alexl@redhat.com>
43+Date: Fri, 15 Apr 2011 11:05:30 +0000
44+Subject: Don't leak dbus messages
45+
46+We're missing a lot of dbus_message_unref after sending messages, add them.
47+---
48+diff --git a/daemon/daemon-main.c b/daemon/daemon-main.c
49+index 22cebe6..13e4780 100644
50+--- a/daemon/daemon-main.c
51++++ b/daemon/daemon-main.c
52+@@ -127,6 +127,7 @@ send_spawned (DBusConnection *connection, gboolean succeeded, char *error_messag
53+ _g_dbus_oom ();
54+
55+ dbus_connection_send (connection, message, NULL);
56++ dbus_message_unref (message);
57+ /* Make sure the message is sent */
58+ dbus_connection_flush (connection);
59+ }
60+diff --git a/daemon/gvfsjobcopy.c b/daemon/gvfsjobcopy.c
61+index 730e1e2..e833168 100644
62+--- a/daemon/gvfsjobcopy.c
63++++ b/daemon/gvfsjobcopy.c
64+@@ -104,6 +104,8 @@ g_vfs_job_copy_new (DBusConnection *connection,
65+ dbus_error_free (&derror);
66+
67+ dbus_connection_send (connection, reply, NULL);
68++ dbus_message_unref (reply);
69++
70+ return NULL;
71+ }
72+
73+diff --git a/daemon/gvfsjobcreatemonitor.c b/daemon/gvfsjobcreatemonitor.c
74+index 074a866..e825de3 100644
75+--- a/daemon/gvfsjobcreatemonitor.c
76++++ b/daemon/gvfsjobcreatemonitor.c
77+@@ -104,6 +104,7 @@ g_vfs_job_create_monitor_new (DBusConnection *connection,
78+ dbus_error_free (&derror);
79+
80+ dbus_connection_send (connection, reply, NULL);
81++ dbus_message_unref (reply);
82+ return NULL;
83+ }
84+
85+diff --git a/daemon/gvfsjobdelete.c b/daemon/gvfsjobdelete.c
86+index 688e604..bbc3891 100644
87+--- a/daemon/gvfsjobdelete.c
88++++ b/daemon/gvfsjobdelete.c
89+@@ -96,6 +96,7 @@ g_vfs_job_delete_new (DBusConnection *connection,
90+ dbus_error_free (&derror);
91+
92+ dbus_connection_send (connection, reply, NULL);
93++ dbus_message_unref (reply);
94+ return NULL;
95+ }
96+
97+diff --git a/daemon/gvfsjobenumerate.c b/daemon/gvfsjobenumerate.c
98+index 90ff452..208f0ba 100644
99+--- a/daemon/gvfsjobenumerate.c
100++++ b/daemon/gvfsjobenumerate.c
101+@@ -110,6 +110,7 @@ g_vfs_job_enumerate_new (DBusConnection *connection,
102+ dbus_error_free (&derror);
103+
104+ dbus_connection_send (connection, reply, NULL);
105++ dbus_message_unref (reply);
106+ return NULL;
107+ }
108+
109+diff --git a/daemon/gvfsjobmakedirectory.c b/daemon/gvfsjobmakedirectory.c
110+index 2e9c7e2..61257d9 100644
111+--- a/daemon/gvfsjobmakedirectory.c
112++++ b/daemon/gvfsjobmakedirectory.c
113+@@ -96,6 +96,7 @@ g_vfs_job_make_directory_new (DBusConnection *connection,
114+ dbus_error_free (&derror);
115+
116+ dbus_connection_send (connection, reply, NULL);
117++ dbus_message_unref (reply);
118+ return NULL;
119+ }
120+
121+diff --git a/daemon/gvfsjobmakesymlink.c b/daemon/gvfsjobmakesymlink.c
122+index 157e70f..0ea22fa 100644
123+--- a/daemon/gvfsjobmakesymlink.c
124++++ b/daemon/gvfsjobmakesymlink.c
125+@@ -99,6 +99,7 @@ g_vfs_job_make_symlink_new (DBusConnection *connection,
126+ dbus_error_free (&derror);
127+
128+ dbus_connection_send (connection, reply, NULL);
129++ dbus_message_unref (reply);
130+ return NULL;
131+ }
132+
133+diff --git a/daemon/gvfsjobmountmountable.c b/daemon/gvfsjobmountmountable.c
134+index 1d60836..6cc2ea2 100644
135+--- a/daemon/gvfsjobmountmountable.c
136++++ b/daemon/gvfsjobmountmountable.c
137+@@ -109,6 +109,7 @@ g_vfs_job_mount_mountable_new (DBusConnection *connection,
138+ dbus_error_free (&derror);
139+
140+ dbus_connection_send (connection, reply, NULL);
141++ dbus_message_unref (reply);
142+ return NULL;
143+ }
144+
145+diff --git a/daemon/gvfsjobmove.c b/daemon/gvfsjobmove.c
146+index 0f3b7a2..9a6bd89 100644
147+--- a/daemon/gvfsjobmove.c
148++++ b/daemon/gvfsjobmove.c
149+@@ -104,6 +104,7 @@ g_vfs_job_move_new (DBusConnection *connection,
150+ dbus_error_free (&derror);
151+
152+ dbus_connection_send (connection, reply, NULL);
153++ dbus_message_unref (reply);
154+ return NULL;
155+ }
156+
157+diff --git a/daemon/gvfsjobopenforread.c b/daemon/gvfsjobopenforread.c
158+index 31265db..d217c27 100644
159+--- a/daemon/gvfsjobopenforread.c
160++++ b/daemon/gvfsjobopenforread.c
161+@@ -106,6 +106,7 @@ g_vfs_job_open_for_read_new (DBusConnection *connection,
162+ dbus_error_free (&derror);
163+
164+ dbus_connection_send (connection, reply, NULL);
165++ dbus_message_unref (reply);
166+ return NULL;
167+ }
168+
169+diff --git a/daemon/gvfsjobopenforwrite.c b/daemon/gvfsjobopenforwrite.c
170+index 6d368f8..6e7396c 100644
171+--- a/daemon/gvfsjobopenforwrite.c
172++++ b/daemon/gvfsjobopenforwrite.c
173+@@ -116,6 +116,7 @@ g_vfs_job_open_for_write_new (DBusConnection *connection,
174+ dbus_error_free (&derror);
175+
176+ dbus_connection_send (connection, reply, NULL);
177++ dbus_message_unref (reply);
178+ g_free (path);
179+ return NULL;
180+ }
181+diff --git a/daemon/gvfsjobopeniconforread.c b/daemon/gvfsjobopeniconforread.c
182+index 1e36a24..59e813a 100644
183+--- a/daemon/gvfsjobopeniconforread.c
184++++ b/daemon/gvfsjobopeniconforread.c
185+@@ -87,6 +87,7 @@ g_vfs_job_open_icon_for_read_new (DBusConnection *connection,
186+ dbus_error_free (&derror);
187+
188+ dbus_connection_send (connection, reply, NULL);
189++ dbus_message_unref (reply);
190+ return NULL;
191+ }
192+
193+diff --git a/daemon/gvfsjobpollmountable.c b/daemon/gvfsjobpollmountable.c
194+index 4fa67b1..ac59da2 100644
195+--- a/daemon/gvfsjobpollmountable.c
196++++ b/daemon/gvfsjobpollmountable.c
197+@@ -99,6 +99,7 @@ g_vfs_job_poll_mountable_new (DBusConnection *connection,
198+ dbus_error_free (&derror);
199+
200+ dbus_connection_send (connection, reply, NULL);
201++ dbus_message_unref (reply);
202+ return NULL;
203+ }
204+
205+diff --git a/daemon/gvfsjobpull.c b/daemon/gvfsjobpull.c
206+index 4d66bf0..1d4bc78 100644
207+--- a/daemon/gvfsjobpull.c
208++++ b/daemon/gvfsjobpull.c
209+@@ -107,6 +107,7 @@ g_vfs_job_pull_new (DBusConnection *connection,
210+ dbus_error_free (&derror);
211+
212+ dbus_connection_send (connection, reply, NULL);
213++ dbus_message_unref (reply);
214+ return NULL;
215+ }
216+
217+diff --git a/daemon/gvfsjobpush.c b/daemon/gvfsjobpush.c
218+index 49680b3..b4b3874 100644
219+--- a/daemon/gvfsjobpush.c
220++++ b/daemon/gvfsjobpush.c
221+@@ -107,6 +107,7 @@ g_vfs_job_push_new (DBusConnection *connection,
222+ dbus_error_free (&derror);
223+
224+ dbus_connection_send (connection, reply, NULL);
225++ dbus_message_unref (reply);
226+ return NULL;
227+ }
228+
229+diff --git a/daemon/gvfsjobqueryattributes.c b/daemon/gvfsjobqueryattributes.c
230+index 426a26b..3307cfa 100644
231+--- a/daemon/gvfsjobqueryattributes.c
232++++ b/daemon/gvfsjobqueryattributes.c
233+@@ -100,6 +100,7 @@ g_vfs_job_query_attributes_new (DBusConnection *connection,
234+ dbus_error_free (&derror);
235+
236+ dbus_connection_send (connection, reply, NULL);
237++ dbus_message_unref (reply);
238+ return NULL;
239+ }
240+
241+diff --git a/daemon/gvfsjobqueryfsinfo.c b/daemon/gvfsjobqueryfsinfo.c
242+index cce7ded..e464590 100644
243+--- a/daemon/gvfsjobqueryfsinfo.c
244++++ b/daemon/gvfsjobqueryfsinfo.c
245+@@ -101,6 +101,7 @@ g_vfs_job_query_fs_info_new (DBusConnection *connection,
246+ dbus_error_free (&derror);
247+
248+ dbus_connection_send (connection, reply, NULL);
249++ dbus_message_unref (reply);
250+ return NULL;
251+ }
252+
253+diff --git a/daemon/gvfsjobqueryinfo.c b/daemon/gvfsjobqueryinfo.c
254+index 3a52539..27c8edc 100644
255+--- a/daemon/gvfsjobqueryinfo.c
256++++ b/daemon/gvfsjobqueryinfo.c
257+@@ -110,6 +110,7 @@ g_vfs_job_query_info_new (DBusConnection *connection,
258+ dbus_error_free (&derror);
259+
260+ dbus_connection_send (connection, reply, NULL);
261++ dbus_message_unref (reply);
262+ return NULL;
263+ }
264+
265+diff --git a/daemon/gvfsjobsetattribute.c b/daemon/gvfsjobsetattribute.c
266+index c908216..ad2a8a2 100644
267+--- a/daemon/gvfsjobsetattribute.c
268++++ b/daemon/gvfsjobsetattribute.c
269+@@ -120,6 +120,7 @@ g_vfs_job_set_attribute_new (DBusConnection *connection,
270+ _("Invalid dbus message"));
271+
272+ dbus_connection_send (connection, reply, NULL);
273++ dbus_message_unref (reply);
274+ return NULL;
275+ }
276+
277+diff --git a/daemon/gvfsjobsetdisplayname.c b/daemon/gvfsjobsetdisplayname.c
278+index 9ac10a3..0816c8b 100644
279+--- a/daemon/gvfsjobsetdisplayname.c
280++++ b/daemon/gvfsjobsetdisplayname.c
281+@@ -100,6 +100,7 @@ g_vfs_job_set_display_name_new (DBusConnection *connection,
282+ dbus_error_free (&derror);
283+
284+ dbus_connection_send (connection, reply, NULL);
285++ dbus_message_unref (reply);
286+ return NULL;
287+ }
288+
289+diff --git a/daemon/gvfsjobstartmountable.c b/daemon/gvfsjobstartmountable.c
290+index e862846..b4492db 100644
291+--- a/daemon/gvfsjobstartmountable.c
292++++ b/daemon/gvfsjobstartmountable.c
293+@@ -105,6 +105,7 @@ g_vfs_job_start_mountable_new (DBusConnection *connection,
294+ dbus_error_free (&derror);
295+
296+ dbus_connection_send (connection, reply, NULL);
297++ dbus_message_unref (reply);
298+ return NULL;
299+ }
300+
301+diff --git a/daemon/gvfsjobstopmountable.c b/daemon/gvfsjobstopmountable.c
302+index 31f480a..c291d38 100644
303+--- a/daemon/gvfsjobstopmountable.c
304++++ b/daemon/gvfsjobstopmountable.c
305+@@ -107,6 +107,7 @@ g_vfs_job_stop_mountable_new (DBusConnection *connection,
306+ dbus_error_free (&derror);
307+
308+ dbus_connection_send (connection, reply, NULL);
309++ dbus_message_unref (reply);
310+ return NULL;
311+ }
312+
313+diff --git a/daemon/gvfsjobtrash.c b/daemon/gvfsjobtrash.c
314+index e6f6388..338bf0d 100644
315+--- a/daemon/gvfsjobtrash.c
316++++ b/daemon/gvfsjobtrash.c
317+@@ -96,6 +96,7 @@ g_vfs_job_trash_new (DBusConnection *connection,
318+ dbus_error_free (&derror);
319+
320+ dbus_connection_send (connection, reply, NULL);
321++ dbus_message_unref (reply);
322+ return NULL;
323+ }
324+
325+diff --git a/daemon/gvfsjobunmount.c b/daemon/gvfsjobunmount.c
326+index ee2cb7e..17e364f 100644
327+--- a/daemon/gvfsjobunmount.c
328++++ b/daemon/gvfsjobunmount.c
329+@@ -106,6 +106,7 @@ g_vfs_job_unmount_new (DBusConnection *connection,
330+ dbus_error_free (&derror);
331+
332+ dbus_connection_send (connection, reply, NULL);
333++ dbus_message_unref (reply);
334+ return NULL;
335+ }
336+
337+diff --git a/daemon/gvfsjobunmountmountable.c b/daemon/gvfsjobunmountmountable.c
338+index ed648ca..9cf9c2d 100644
339+--- a/daemon/gvfsjobunmountmountable.c
340++++ b/daemon/gvfsjobunmountmountable.c
341+@@ -108,6 +108,7 @@ g_vfs_job_unmount_mountable_new (DBusConnection *connection,
342+ dbus_error_free (&derror);
343+
344+ dbus_connection_send (connection, reply, NULL);
345++ dbus_message_unref (reply);
346+ return NULL;
347+ }
348+
349+diff --git a/daemon/gvfsmonitor.c b/daemon/gvfsmonitor.c
350+index 4b91ece..8947099 100644
351+--- a/daemon/gvfsmonitor.c
352++++ b/daemon/gvfsmonitor.c
353+@@ -184,8 +184,9 @@ vfs_monitor_message_callback (DBusConnection *connection,
354+ derror.name,
355+ derror.message);
356+ dbus_error_free (&derror);
357+-
358++
359+ dbus_connection_send (connection, reply, NULL);
360++ dbus_message_unref (reply);
361+ }
362+ else
363+ {
364+@@ -199,8 +200,9 @@ vfs_monitor_message_callback (DBusConnection *connection,
365+
366+ reply = dbus_message_new_method_return (message);
367+ dbus_connection_send (connection, reply, NULL);
368++ dbus_message_unref (reply);
369+ }
370+-
371++
372+ return DBUS_HANDLER_RESULT_HANDLED;
373+ }
374+ else if (dbus_message_is_method_call (message,
375+@@ -216,8 +218,9 @@ vfs_monitor_message_callback (DBusConnection *connection,
376+ derror.name,
377+ derror.message);
378+ dbus_error_free (&derror);
379+-
380++
381+ dbus_connection_send (connection, reply, NULL);
382++ dbus_message_unref (reply);
383+ }
384+ else
385+ {
386+@@ -235,9 +238,10 @@ vfs_monitor_message_callback (DBusConnection *connection,
387+ break;
388+ }
389+ }
390+-
391++
392+ reply = dbus_message_new_method_return (message);
393+ dbus_connection_send (connection, reply, NULL);
394++ dbus_message_unref (reply);
395+
396+ g_object_unref (monitor);
397+ }
398+diff --git a/daemon/mount.c b/daemon/mount.c
399+index 2331559..6eb07d3 100644
400+--- a/daemon/mount.c
401++++ b/daemon/mount.c
402+@@ -757,6 +757,7 @@ register_mount (DBusConnection *connection,
403+ _g_dbus_oom ();
404+
405+ dbus_connection_send (connection, reply, NULL);
406++ dbus_message_unref (reply);
407+ }
408+
409+ typedef struct {
410+@@ -778,6 +779,7 @@ automount_done (VfsMountable *mountable,
411+ G_IO_ERROR, G_IO_ERROR_NOT_MOUNTED,
412+ _("Automount failed: %s"), error->message);
413+ dbus_connection_send (data->connection, reply, NULL);
414++ dbus_message_unref (reply);
415+ }
416+ else
417+ lookup_mount (data->connection,
418+@@ -870,7 +872,10 @@ lookup_mount (DBusConnection *connection,
419+
420+ g_mount_spec_unref (spec);
421+ if (reply != NULL)
422+- dbus_connection_send (connection, reply, NULL);
423++ {
424++ dbus_connection_send (connection, reply, NULL);
425++ dbus_message_unref (reply);
426++ }
427+ }
428+
429+ static void
430+@@ -910,9 +915,12 @@ lookup_mount_by_fuse_path (DBusConnection *connection,
431+ reply = dbus_message_new_error (message,
432+ DBUS_ERROR_INVALID_ARGS,
433+ "Invalid arguments");
434+-
435++
436+ if (reply != NULL)
437+- dbus_connection_send (connection, reply, NULL);
438++ {
439++ dbus_connection_send (connection, reply, NULL);
440++ dbus_message_unref (reply);
441++ }
442+ }
443+
444+ static void
445+@@ -958,8 +966,9 @@ list_mounts (DBusConnection *connection,
446+
447+ if (!dbus_message_iter_close_container (&iter, &array_iter))
448+ _g_dbus_oom ();
449+-
450++
451+ dbus_connection_send (connection, reply, NULL);
452++ dbus_message_unref (reply);
453+ }
454+
455+ static void
456+@@ -1047,7 +1056,10 @@ mount_location (DBusConnection *connection,
457+ }
458+
459+ if (reply)
460+- dbus_connection_send (connection, reply, NULL);
461++ {
462++ dbus_connection_send (connection, reply, NULL);
463++ dbus_message_unref (reply);
464++ }
465+ else
466+ {
467+ GMountSource *source;
468+@@ -1099,8 +1111,9 @@ list_mount_types (DBusConnection *connection,
469+
470+ if (!dbus_message_iter_close_container (&iter, &array_iter))
471+ _g_dbus_oom ();
472+-
473++
474+ dbus_connection_send (connection, reply, NULL);
475++ dbus_message_unref (reply);
476+ }
477+
478+ static void
479+@@ -1140,8 +1153,9 @@ list_mountable_info (DBusConnection *connection,
480+
481+ if (!dbus_message_iter_close_container (&iter, &array_iter))
482+ _g_dbus_oom ();
483+-
484++
485+ dbus_connection_send (connection, reply, NULL);
486++ dbus_message_unref (reply);
487+ }
488+
489+ static DBusHandlerResult
490
491=== renamed file 'debian/patches/90_git_leaks_fixes.patch' => 'debian/patches/90_git_leaks_fixes.patch.moved'

Subscribers

People subscribed via source and target branches

to all changes: