Merge ubuntu-archive-tools:clean-up-java-hard-coding into ubuntu-archive-tools:main

Proposed by Steve Langasek
Status: Needs review
Proposed branch: ubuntu-archive-tools:clean-up-java-hard-coding
Merge into: ubuntu-archive-tools:main
Diff against target: 35 lines (+12/-7)
1 file modified
update-i386-whitelist (+12/-7)
Reviewer Review Type Date Requested Status
Matthias Klose Pending
Ubuntu Package Archive Administrators Pending
Review via email: mp+465016@code.launchpad.net

Description of the change

Don't hard-code all openjdk versions across all Ubuntu releases. We should be selective about which series we hard-code which versions for, so that we can eventually age these out instead of having the list grow indefinitely.

I'm not sure I've gotten this exactly right in terms of which releases we want to allow where, however (due to ppas) so I'm requesting review.

To post a comment you must log in.

Unmerged commits

ab5ed54... by Steve Langasek

Only hard-code intermediate openjdk releases on series where they're shipped

Allow the LTS-supported releases and the currently-latest release to be
whitelisted across all releases. For all other openjdk releases, only
whitelist them for series where they're actually shipped in the archive.

e83ef86... by Steve Langasek

Only hard-code openjdk-21 (and deps) in focal, jammy, mantic

openjdk-21 was introduced in the LTS series post-release and was not the
default in mantic

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/update-i386-whitelist b/update-i386-whitelist
2index e00287c..594a4d4 100755
3--- a/update-i386-whitelist
4+++ b/update-i386-whitelist
5@@ -89,18 +89,23 @@ if __name__ == '__main__':
6
7 # needed to bootstrap openjdk-N
8 newSet.update(['openjdk-lts'])
9- newSet.update(['openjdk-13'])
10- newSet.update(['openjdk-16'])
11 newSet.update(['openjdk-17'])
12- newSet.update(['openjdk-18'])
13- newSet.update(['openjdk-19'])
14- newSet.update(['openjdk-20'])
15- newSet.update(['openjdk-21'])
16- newSet.update(['openjdk-22'])
17 newSet.update(['openjdk-23'])
18 newSet.update(['gsfonts'])
19 if opts.release in ('focal','jammy','mantic'):
20+ newSet.update(['openjdk-21', 'java-atk-wrapper', 'x11-utils'])
21 newSet.update(['openjdk-8'])
22+ if opts.release == 'focal':
23+ newSet.update(['openjdk-13'])
24+ newSet.update(['openjdk-16'])
25+ if opts.release in ('jammy', 'mantic'):
26+ newSet.update(['openjdk-19'])
27+ if opts.release == 'jammy':
28+ newSet.update(['openjdk-18'])
29+ if opts.release in ('mantic', 'noble'):
30+ newSet.update(['openjdk-22'])
31+ if opts.release == 'mantic':
32+ newSet.update(['openjdk-20'])
33
34 newSet.update(['llvm-toolchain-9'])
35 newSet.update(['llvm-toolchain-11'])

Subscribers

People subscribed via source and target branches