Merge ubuntu-archive-tools:unsubscribe-dry-run into ubuntu-archive-tools:main

[Brian Murray]

Add a dry-run mode because you have to be a member of the team for the script to work.

Also create a dictionary of teams and packages which a team should not be unsubscribed from e.g. bugs can get filed about the subiquity package and the Foundations team should still check that package for bugs. (It's also useful for the rls- reports.)

70474fc... by Brian Murray on 2022-08-19

Fix a pep8 error

3b3aa67... by Brian Murray on 2022-08-19

Add chromium-browser as a keeper for desktop-packages

088823e... by Brian Murray on 2022-08-19

Use a set not a list

[Utkarsh Gupta (utkarsh)]

Nice, this looks good. I haven't ran this myself but seems to do the work. +1 with two trivial points. :)

review: Approve

diff --git a/unsubscribe-team b/unsubscribe-team
index 134f585..24638dd 100755
--- a/unsubscribe-team
+++ b/unsubscribe-team
@@ -9,8 +9,15 @@ import sys
 from urllib.request import urlopen
 from package_subscribers import source_names
 
+# Never unsubscribe a team from a package if it appears here
+KEEPERS = {'foundations-bugs':
+           ('subiquity', 'linux-firmware-raspi2'),
+           'desktop-packages':
+           ('chromium-browser')
+           }
 
-def unsubscribe(lp, user, ubuntu, current_packages):
+
+def unsubscribe(lp, dry_run, user, ubuntu, current_packages):
     try:
         lpuser = lp.people[user]
     except KeyError:
@@ -23,6 +30,9 @@ def unsubscribe(lp, user, ubuntu, current_packages):
 
     stale_packages = subscriptions - current_packages
     for package in stale_packages:
+        # Don't unsubscribe the team if they want the subscription
+        if user in KEEPERS and package in KEEPERS[user]:
+            continue
         srcpkg = ubuntu.getSourcePackage(name=package)
         # if the srcpkg has an open MIR bug keep the subscription
         mir_bug = any([task for task in
@@ -30,10 +40,13 @@ def unsubscribe(lp, user, ubuntu, current_packages):
                        if "[MIR]" in task.title])
         if mir_bug:
             continue
-        print("Unsubscribing from %s" % package)
-        srcpkg = ubuntu.getSourcePackage(name=package)
-        srcpkg.removeBugSubscription(subscriber=lpuser)
-        print('%s is now unsubscribed for all bugs about %s' % (user, package))
+        if dry_run:
+            print("Would unsubscribe from %s" % package)
+        else:
+            srcpkg = ubuntu.getSourcePackage(name=package)
+            srcpkg.removeBugSubscription(subscriber=lpuser)
+            print('%s is now unsubscribed for all bugs about %s' %
+                  (user, package))
 
 
 def main(argv):
@@ -47,6 +60,9 @@ def main(argv):
         help="Select the Launchpad instance to run against. Defaults to "
         "'production'")
     parser.add_option(
+        "-n", "--dry-run", default=False, action="store_true",
+        help="Only show the subscriptions that would be removed")
+    parser.add_option(
         '-q', '--quiet', action='store_true', default=False,
         help="Quieten progress messages")
     parser.add_option(
@@ -75,7 +91,7 @@ def main(argv):
     current_packages = source_names(options)
 
     for user in args:
-        unsubscribe(lp, user, ubuntu, current_packages)
+        unsubscribe(lp, options.dry_run, user, ubuntu, current_packages)
 
 
 if __name__ == '__main__':