ubuntu-archive-tools

Merge ubuntu-archive-tools:fix-nbs-report into ubuntu-archive-tools:main

  1. Git
  2. lp:ubuntu-archive-tools
  3. fix-nbs-report
  4. Merge into main
Proposed by Steve Langasek
Status: Merged
Merged at revision: 0db086daab3287b2e18f9414496357c89b708929
Proposed branch: ubuntu-archive-tools:fix-nbs-report
Merge into: ubuntu-archive-tools:main
Diff against target: 12 lines (+1/-1)
1 file modified
nbs-report (+1/-1)
Reviewer Review Type Date Requested Status
Andy Whitcroft Approve
Sebastien Bacher Abstain
Brian Murray Approve
Review via email: mp+415395@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Brian Murray (brian-murray) wrote :

This looks good to me.

review: Approve
Revision history for this message
Sebastien Bacher (seb128) wrote :

it's a bit suboptimal to hardcode a filename but probably ok to fix the report now, would be better to not fail when files can't be parsed though

review: Abstain
Revision history for this message
Andy Whitcroft (apw) wrote :

Looks ok; if a little sad.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/nbs-report b/nbs-report
2index 32eaf9a..d8e3de4 100755
3--- a/nbs-report
4+++ b/nbs-report
5@@ -290,7 +290,7 @@ def main():
6 nbs = defaultdict(dict)
7
8 for f in os.listdir(args[0]):
9- if f.startswith('.') or f.endswith('.html'):
10+ if f.startswith('.') or f.endswith('.html') or f == '00FTBFS':
11 continue
12 parse_checkrdepends_file(os.path.join(args[0], f), nbs[f])
13

Subscribers

People subscribed via source and target branches