Merge ~u-d/apparmor-profiles:thunderbird/links into ~apparmor-dev/apparmor-profiles/+git/apparmor-profiles-old:master

Proposed by Ulrike Uhlig
Status: Merged
Merged at revision: cfecf1dea1d5c4ea568d9dd7ab1c95f391b5b0d8
Proposed branch: ~u-d/apparmor-profiles:thunderbird/links
Merge into: ~apparmor-dev/apparmor-profiles/+git/apparmor-profiles-old:master
Diff against target: 17 lines (+6/-0)
1 file modified
ubuntu/17.04/usr.bin.thunderbird (+6/-0)
Reviewer Review Type Date Requested Status
Steve Beattie Approve
intrigeri Approve
Review via email: mp+320285@code.launchpad.net

Description of the change

When clicking on links in emails, users would expect the browser to open them.

This is a patch by Douglas Bagnall <email address hidden> for XFCE.
Origin: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=853929

To post a comment you must log in.
Revision history for this message
intrigeri (intrigeri) wrote :

This looks alright to me, I would merge it! Note that there's some overlap with https://code.launchpad.net/~u-d/apparmor-profiles/+git/apparmor-profiles/+merge/320276 so the other MR will need updating once the other is merged.

review: Approve
Revision history for this message
intrigeri (intrigeri) wrote :

FTR https://code.launchpad.net/~sdeziel/apparmor-profiles/+git/apparmor-profiles/+merge/330183 is a superset of this MR, so if/once Simon's one is merged we can close this one as obsolete.

Revision history for this message
Steve Beattie (sbeattie) wrote :

Looks good. I went ahead and merged this, even though it was a subset of Simon's branch, just to get the origins/credit correct. I forget to amend my commit message before pushing, but I also copied the changes to the 17.10 branch (which didn't exist when the merge request was originally made :/ ).

Thanks again, and my apologies for the delay!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/ubuntu/17.04/usr.bin.thunderbird b/ubuntu/17.04/usr.bin.thunderbird
2index e74e9f5..4cbf708 100644
3--- a/ubuntu/17.04/usr.bin.thunderbird
4+++ b/ubuntu/17.04/usr.bin.thunderbird
5@@ -175,6 +175,12 @@ profile thunderbird /usr/lib/thunderbird/thunderbird {
6 /{usr/,}bin/uname Uxr,
7 /usr/bin/locale Uxr,
8
9+ # For Xubuntu to launch the browser
10+ /usr/bin/exo-open ixr,
11+ /usr/lib/@{multiarch}/xfce4/exo-1/exo-helper-1 ixr,
12+ /etc/xdg/xdg-xubuntu/xfce4/helpers.rc r,
13+ /etc/xdg/xfce4/helpers.rc r,
14+
15 /usr/bin/gpg Cx -> gpg,
16
17 profile gpg {

Subscribers

People subscribed via source and target branches