Code review comment for lp:~tyler-baker/lava-dispatcher/dummy-deploy-fix

Revision history for this message
Antonio Terceiro (terceiro) wrote :

On Tue, Sep 10, 2013 at 02:35:38PM -0000, Tyler Baker wrote:
> A true dummy_deploy should not have a dependancy on a master image. It
> should load the deployment data and finish.

I was thinking that one needs to be aware that with this change, if you
run a job with dummy_deploy against a device which does have a master
image, that the tests *may* run in the master image ... but then the
logic in e.g. lava_test_shell should already make sure the proper master
image/test image switching already takes place anyway, so +1

 review approve

review: Approve

« Back to merge proposal