Merge lp:~tyler-baker/lava-dispatcher/dummy-deploy-fix into lp:lava-dispatcher

Proposed by Tyler Baker on 2013-09-10
Status: Merged
Merged at revision: 676
Proposed branch: lp:~tyler-baker/lava-dispatcher/dummy-deploy-fix
Merge into: lp:lava-dispatcher
Diff against target: 9 lines (+0/-1)
1 file modified
lava_dispatcher/actions/deploy.py (+0/-1)
To merge this branch: bzr merge lp:~tyler-baker/lava-dispatcher/dummy-deploy-fix
Reviewer Review Type Date Requested Status
Antonio Terceiro Approve on 2013-09-10
Dave Pigott 2013-09-10 Approve on 2013-09-10
Review via email: mp+184791@code.launchpad.net

Description of the change

A true dummy_deploy should not have a dependancy on a master image. It should load the deployment data and finish.

To post a comment you must log in.
Dave Pigott (dpigott) wrote :

+1

review: Approve
Antonio Terceiro (terceiro) wrote :

On Tue, Sep 10, 2013 at 02:35:38PM -0000, Tyler Baker wrote:
> A true dummy_deploy should not have a dependancy on a master image. It
> should load the deployment data and finish.

I was thinking that one needs to be aware that with this change, if you
run a job with dummy_deploy against a device which does have a master
image, that the tests *may* run in the master image ... but then the
logic in e.g. lava_test_shell should already make sure the proper master
image/test image switching already takes place anyway, so +1

 review approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'lava_dispatcher/actions/deploy.py'
2--- lava_dispatcher/actions/deploy.py 2013-08-30 22:15:05 +0000
3+++ lava_dispatcher/actions/deploy.py 2013-09-10 14:34:56 +0000
4@@ -136,5 +136,4 @@
5
6 def run(self, target_type):
7 device = self.client.target_device
8- device.boot_master_image()
9 device.deployment_data = device.target_map[target_type]

Subscribers

People subscribed via source and target branches