Light Display Manager

Merge lp:~tyhicks/lightdm/guest-dir-perms into lp:lightdm

  1. guest-dir-perms
  2. Merge into trunk
Proposed by Tyler Hicks
Status: Merged
Merged at revision: 2480
Proposed branch: lp:~tyhicks/lightdm/guest-dir-perms
Merge into: lp:lightdm
Diff against target: 12 lines (+1/-1)
1 file modified
debian/guest-account.sh (+1/-1)
To merge this branch: bzr merge lp:~tyhicks/lightdm/guest-dir-perms
Reviewer Review Type Date Requested Status
Robert Ancell Approve
Review via email: mp+322906@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tyler Hicks (tyhicks) wrote :

No CVE or security updates are needed here. This change is just making sure that we do the right thing with the directory permissions from the start.

Revision history for this message
Robert Ancell (robert-ancell) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/guest-account.sh'
2--- debian/guest-account.sh 2017-04-04 21:24:12 +0000
3+++ debian/guest-account.sh 2017-04-21 00:47:36 +0000
4@@ -36,7 +36,7 @@
5 GUEST_HOME=$(echo ${temp_home} | tr '[:upper:]' '[:lower:]')
6 GUEST_USER=${GUEST_HOME#/tmp/}
7 if [ "${GUEST_HOME}" != "${temp_home}" ]; then
8- mkdir "${GUEST_HOME}" || {
9+ mkdir -m 700 "${GUEST_HOME}" || {
10 echo "Failed to create ${GUEST_USER}'s home directory (${GUEST_HOME})"
11 exit 1
12 }

Subscribers

People subscribed via source and target branches