Merge lp:~tyhicks/ecryptfs/xattr.sh-failure into lp:ecryptfs

Proposed by Tyler Hicks
Status: Merged
Merged at revision: 834
Proposed branch: lp:~tyhicks/ecryptfs/xattr.sh-failure
Merge into: lp:ecryptfs
Diff against target: 12 lines (+2/-0)
1 file modified
tests/kernel/xattr/test.c (+2/-0)
To merge this branch: bzr merge lp:~tyhicks/ecryptfs/xattr.sh-failure
Reviewer Review Type Date Requested Status
Colin Ian King (community) Approve
Review via email: mp+230727@code.launchpad.net

Description of the change

Fixes a false positive failure in xattr.sh that was reported by bjf while he was testing in a 14.04 i386 VM.

To post a comment you must log in.
Revision history for this message
Colin Ian King (colin-king) wrote :

Looks good to me.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/kernel/xattr/test.c'
2--- tests/kernel/xattr/test.c 2014-07-14 06:53:54 +0000
3+++ tests/kernel/xattr/test.c 2014-08-13 22:44:52 +0000
4@@ -89,6 +89,8 @@
5 if (len != names_len || len > sizeof(buffer))
6 exit(EXIT_FAILURE);
7
8+ memset(buffer, 0, sizeof(buffer));
9+
10 len = listxattr(file, buffer, sizeof(buffer));
11 if (len != names_len)
12 exit(EXIT_FAILURE);

Subscribers

People subscribed via source and target branches