Prometheus2 charm

Merge ~txiao/charm-prometheus2:fix-broken-recipe into charm-prometheus2:master

  1. Git
  2. lp:~txiao/charm-prometheus2
  3. fix-broken-recipe
  4. Merge into master
Proposed by Tianqi Xiao
Status: Merged
Approved by: Robert Gildein
Approved revision: 3886c42e71e1dc7843de3f3fea821b405469cefc
Merged at revision: 631fb3428e34cf1ccad33fd9df90b8972a9e3104
Proposed branch: ~txiao/charm-prometheus2:fix-broken-recipe
Merge into: charm-prometheus2:master
Diff against target: 13 lines (+2/-0)
1 file modified
charmcraft.yaml (+2/-0)
Reviewer Review Type Date Requested Status
Robert Gildein Approve
🤖 prod-jenkaas-bootstack (community) continuous-integration Approve
Eric Chen Approve
Review via email: mp+453001@code.launchpad.net

Commit message

 Add python dependencies to resolve build error with charm recipe [1]

[1]: https://launchpad.net/~llama-charmers/charm-prometheus2/+charm/charm-prometheus2/+build/14737

Description of the change

libpython3-dev seems to be missing in Launchpad CI machine, causing build error with latest `charm` snap. Adding the missing package resolves the issue.

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Tianqi Xiao (txiao) wrote :

Successful build run: https://launchpad.net/~txiao/charm-prometheus2/+charm/test-build/+build/14758

Revision history for this message
Eric Chen (eric-chen) wrote :

LGTM

review: Approve
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

FAILED: Continuous integration, rev:3886c42e71e1dc7843de3f3fea821b405469cefc
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/27/
Executed test runs:
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/583/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/27//rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
🤖 prod-jenkaas-bootstack (prod-jenkaas-bootstack) wrote :

PASSED: Continuous integration, rev:3886c42e71e1dc7843de3f3fea821b405469cefc
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/28/
Executed test runs:
    SUCCESS: https://jenkins.canonical.com/bootstack/job/lp-charm-test-functest/1917/
    None: https://jenkins.canonical.com/bootstack/job/lp-update-mp/586/

Click here to trigger a rebuild:
https://jenkins.canonical.com/bootstack/job/lp-charm-prometheus2-ci/28//rebuild

review: Approve (continuous-integration)
Revision history for this message
Robert Gildein (rgildein) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision 631fb3428e34cf1ccad33fd9df90b8972a9e3104

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charmcraft.yaml b/charmcraft.yaml
2index bd509eb..76b24b2 100644
3--- a/charmcraft.yaml
4+++ b/charmcraft.yaml
5@@ -5,6 +5,8 @@ parts:
6 plugin: reactive
7 build-snaps:
8 - charm
9+ build-packages:
10+ - libpython3-dev
11 bases:
12 - build-on:
13 - name: ubuntu

Subscribers

People subscribed via source and target branches

to all changes: