Merge ~txiao/charm-prometheus-openstack-exporter:jammy-support into charm-prometheus-openstack-exporter:master

Proposed by Tianqi Xiao
Status: Merged
Approved by: Eric Chen
Approved revision: f71c2d56af7e4ec5091ee4d0e51726f52bf8dbd3
Merged at revision: f3d9bf3f6f5ff8def9ad2a732d5e943477f39dd4
Proposed branch: ~txiao/charm-prometheus-openstack-exporter:jammy-support
Merge into: charm-prometheus-openstack-exporter:master
Diff against target: 150 lines (+29/-16)
7 files modified
charmcraft.yaml (+4/-4)
src/metadata.yaml (+1/-3)
src/tests/functional/requirements.txt (+2/-1)
src/tests/functional/tests/bundles/focal.yaml (+2/-4)
src/tests/functional/tests/bundles/jammy.yaml (+9/-3)
src/tests/functional/tests/tests.yaml (+1/-1)
src/tox.ini (+10/-0)
Reviewer Review Type Date Requested Status
Eric Chen Approve
BootStack Reviewers Pending
Review via email: mp+427240@code.launchpad.net

Commit message

Add jammy support, remove legacy series support, and resolve LP#1925278

Description of the change

This commit:
    1. Added jammy support and functional tests.
    2. Removed xenial, trusty, and yakkety support from the main
    development track due to package dependency issue.
    3. Resolved LP#1925278 bug for zaza tests
    4. Update keystone version to focal and switch mysql instance to mysql-innodb-cluster in focal and jammy functional test.

func-test: https://pastebin.ubuntu.com/p/rZXpPZf9ht/

To post a comment you must log in.
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

This merge proposal is being monitored by mergebot. Change the status to Approved to merge.

Revision history for this message
Eric Chen (eric-chen) :
review: Needs Information
Revision history for this message
Tianqi Xiao (txiao) :
Revision history for this message
Eric Chen (eric-chen) :
review: Approve
Revision history for this message
🤖 Canonical IS Merge Bot (canonical-is-mergebot) wrote :

Change successfully merged at revision f3d9bf3f6f5ff8def9ad2a732d5e943477f39dd4

Revision history for this message
Robert Gildein (rgildein) wrote :

This has already been merged, but how was it tested? Can we add the
results of these tests here?

Revision history for this message
Tianqi Xiao (txiao) wrote :

Thanks Robert for your feedback. I've added the func-test result to the MP description.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/charmcraft.yaml b/charmcraft.yaml
2index 1f750bc..3d3c2fb 100644
3--- a/charmcraft.yaml
4+++ b/charmcraft.yaml
5@@ -7,19 +7,19 @@ parts:
6 bases:
7 - build-on:
8 - name: ubuntu
9- channel: "20.04"
10+ channel: "22.04"
11 architectures: ["amd64"]
12 run-on:
13 - name: ubuntu
14- channel: "20.04"
15+ channel: "22.04"
16 architectures:
17 - amd64
18 - name: ubuntu
19- channel: "18.04"
20+ channel: "20.04"
21 architectures:
22 - amd64
23 - name: ubuntu
24- channel: "16.04"
25+ channel: "18.04"
26 architectures:
27 - amd64
28
29diff --git a/src/metadata.yaml b/src/metadata.yaml
30index f47cb95..97a6694 100644
31--- a/src/metadata.yaml
32+++ b/src/metadata.yaml
33@@ -24,11 +24,9 @@ provides:
34 dashboards:
35 interface: grafana-dashboard
36 series:
37- - xenial
38 - bionic
39- - trusty
40- - yakkety
41 - focal
42+ - jammy
43 extra-bindings:
44 public:
45 admin:
46diff --git a/src/tests/functional/requirements.txt b/src/tests/functional/requirements.txt
47index daa080c..593ef44 100644
48--- a/src/tests/functional/requirements.txt
49+++ b/src/tests/functional/requirements.txt
50@@ -1,2 +1,3 @@
51 git+https://github.com/openstack-charmers/zaza.git#egg=zaza
52-requests<2.25.0
53\ No newline at end of file
54+requests<2.25.0
55+python-openstackclient
56\ No newline at end of file
57diff --git a/src/tests/functional/tests/bundles/focal.yaml b/src/tests/functional/tests/bundles/focal.yaml
58index 2b05215..65a51c1 100644
59--- a/src/tests/functional/tests/bundles/focal.yaml
60+++ b/src/tests/functional/tests/bundles/focal.yaml
61@@ -11,12 +11,10 @@ applications:
62 num_units: 1
63 keystone:
64 charm: ch:keystone
65- series: bionic
66 num_units: 1
67 mysql:
68- charm: ch:percona-cluster
69- series: bionic
70- num_units: 1
71+ charm: ch:mysql-innodb-cluster
72+ num_units: 3
73 grafana:
74 charm: ch:grafana
75 num_units: 1
76diff --git a/src/tests/functional/tests/bundles/xenial.yaml b/src/tests/functional/tests/bundles/jammy.yaml
77similarity index 83%
78rename from src/tests/functional/tests/bundles/xenial.yaml
79rename to src/tests/functional/tests/bundles/jammy.yaml
80index 60c4212..2d788b6 100644
81--- a/src/tests/functional/tests/bundles/xenial.yaml
82+++ b/src/tests/functional/tests/bundles/jammy.yaml
83@@ -1,4 +1,4 @@
84-series: xenial
85+series: jammy
86 applications:
87 prometheus-openstack-exporter:
88 options:
89@@ -6,18 +6,24 @@ applications:
90 num_units: 1
91 nrpe:
92 charm: ch:nrpe
93+ channel: latest/edge
94+ series: focal # have to use focal here because nrpe has no official jammy
95+ # jammy support. Needs to be removed in the future.
96 prometheus:
97 charm: ch:prometheus2
98 num_units: 1
99+ series: focal
100 keystone:
101 charm: ch:keystone
102+ series: focal
103 num_units: 1
104 mysql:
105- charm: ch:percona-cluster
106- num_units: 1
107+ charm: ch:mysql-innodb-cluster
108+ num_units: 3
109 grafana:
110 charm: ch:grafana
111 num_units: 1
112+ series: focal
113
114 relations:
115 - - prometheus-openstack-exporter:nrpe-external-master
116diff --git a/src/tests/functional/tests/tests.yaml b/src/tests/functional/tests/tests.yaml
117index 50310f4..14ea8d6 100644
118--- a/src/tests/functional/tests/tests.yaml
119+++ b/src/tests/functional/tests/tests.yaml
120@@ -1,8 +1,8 @@
121 charm_name: prometheus-openstack-exporter
122 gate_bundles:
123+ - jammy
124 - focal
125 - bionic
126- - xenial
127 smoke_bundles:
128 - bionic
129 dev_bundles:
130diff --git a/src/tox.ini b/src/tox.ini
131index f804ddc..0ab2129 100644
132--- a/src/tox.ini
133+++ b/src/tox.ini
134@@ -21,6 +21,16 @@ passenv =
135 NO_PROXY
136 SNAP_HTTP_PROXY
137 SNAP_HTTPS_PROXY
138+ OS_REGION_NAME
139+ OS_AUTH_VERSION
140+ OS_AUTH_URL
141+ OS_PROJECT_DOMAIN_NAME
142+ OS_USERNAME
143+ OS_PASSWORD
144+ OS_PROJECT_ID
145+ OS_USER_DOMAIN_NAME
146+ OS_PROJECT_NAME
147+ OS_IDENTITY_API_VERSION
148
149 [testenv:lint]
150 commands =

Subscribers

People subscribed via source and target branches

to all changes: